From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE975C433DB for ; Tue, 5 Jan 2021 17:41:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A10A22D01 for ; Tue, 5 Jan 2021 17:41:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A10A22D01 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vZVvXnOMk4JPEwC6sKPSVA+KAIFKXDZrWq55ILVPWqY=; b=RwXdeQLQXSl+tI34JU4n8VCXP Lg0u5o0APH8BBTrTjMETz3y4hspdQU9xF8MEtHS13RBWS1c55SrS7uaLAcbGDqVTXhl9i0yIzjrLH Ne7rpj246OJLpKImPwHged+bGTw5Z4h4axwb7pJMld9zSq5PtTTOkHs6Jt0XfM196+FEWwT7Q0a4r 6C1tmWYiyOtAvxtMJVBeqlg96Zitsd6Lj544CZLEKagETx+RRK5N+OX700TqBaX1OIcXF8XOZstc/ r39o+q8dbgnNqo/QsBcrs6AK/kNopM4FurlTtPA8DC6M9jEvaaDrVxR393p0H6rxLjdaMMNXW/SQ7 Y0NjoCdsg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwqJg-0005DK-GJ; Tue, 05 Jan 2021 17:40:20 +0000 Received: from mail-io1-f46.google.com ([209.85.166.46]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwqJd-0005C2-MS; Tue, 05 Jan 2021 17:40:18 +0000 Received: by mail-io1-f46.google.com with SMTP id n4so76161iow.12; Tue, 05 Jan 2021 09:40:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8QCUqXr2bzGc5ddkxZAj8Vxc5oTvsGwo9juSuaK/DNc=; b=LRfWmk3W4FBXPmlIVx+88ahZupHca0L7LfMFqXR5lf07Jw2YvtDfDPHokqMA/oipon OqOhQtR5/P/n3JhTgoTKNBvdBN7VPKnVPfWILlm9FCJWo2P5Q8GyodmJQx0HJBiTcEHM 7wrhXzLP9sH60fA4m7tIQ3Tsh6/6Li2oKo+W6IRiQIon8qMQyG7DV68Pl5I30oK/MsAP bM7/0yKWRZvdpFhiZtYXT8gNSqMoxCcCQNGBP4h+asLCynDL144tpe7NPwK/o4549IKA Zp8guOj3ZXWP90adq714wNh8lXFcN6PWYahgc1YlX8OdSO7f0sM4c23eOC3vCc9dPt7M 0uSQ== X-Gm-Message-State: AOAM5301fOtCYchgGT62F1b3kMpL9bf+kNqKQMulL2XQtbJBSVj1IQgj ev7yPTNJnSnsct5K9yRsGQ== X-Google-Smtp-Source: ABdhPJxCW42aLPbGC5oVtd7TRg3rkrFk+Qrm1SC6TjLARKSfiB9JNiyQ7YL2gLDjCHBjUScpozxZgA== X-Received: by 2002:a02:7692:: with SMTP id z140mr666018jab.21.1609868414264; Tue, 05 Jan 2021 09:40:14 -0800 (PST) Received: from robh.at.kernel.org ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id y15sm121208ili.65.2021.01.05.09.40.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jan 2021 09:40:13 -0800 (PST) Received: (nullmailer pid 426116 invoked by uid 1000); Tue, 05 Jan 2021 17:40:08 -0000 Date: Tue, 5 Jan 2021 10:40:08 -0700 From: Rob Herring To: Greg Kroah-Hartman Subject: Re: [PATCH] dt-bindings: Add missing array size constraints Message-ID: <20210105174008.GB1875909@robh.at.kernel.org> References: <20210104230253.2805217-1-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210105_124017_776766_9436E253 X-CRM114-Status: GOOD ( 29.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , linux-usb@vger.kernel.org, linux-iio@vger.kernel.org, Linus Walleij , linux-remoteproc@vger.kernel.org, alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, Bjorn Andersson , linux-ide@vger.kernel.org, Thierry Reding , linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org, Chanwoo Choi , Marc Zyngier , Bartosz Golaszewski , Chen-Yu Tsai , MyungJoo Ham , linux-serial@vger.kernel.org, linux-input@vger.kernel.org, Jakub Kicinski , linux-media@vger.kernel.org, Ohad Ben-Cohen , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-gpio@vger.kernel.org, Thomas Gleixner , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, Jens Axboe , Stephen Boyd , netdev@vger.kernel.org, Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Sebastian Reichel , "David S. Miller" , Jonathan Cameron Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 05, 2021 at 02:04:14PM +0100, Greg Kroah-Hartman wrote: > On Mon, Jan 04, 2021 at 04:02:53PM -0700, Rob Herring wrote: > > DT properties which can have multiple entries need to specify what the > > entries are and define how many entries there can be. In the case of > > only a single entry, just 'maxItems: 1' is sufficient. > > > > Add the missing entry constraints. These were found with a modified > > meta-schema. Unfortunately, there are a few cases where the size > > constraints are not defined such as common bindings, so the meta-schema > > can't be part of the normal checks. > > > > Cc: Jens Axboe > > Cc: Stephen Boyd > > Cc: Thierry Reding > > Cc: MyungJoo Ham > > Cc: Chanwoo Choi > > Cc: Linus Walleij > > Cc: Bartosz Golaszewski > > Cc: Jonathan Cameron > > Cc: Dmitry Torokhov > > Cc: Thomas Gleixner > > Cc: Marc Zyngier > > Cc: Mauro Carvalho Chehab > > Cc: Chen-Yu Tsai > > Cc: Ulf Hansson > > Cc: "David S. Miller" > > Cc: Jakub Kicinski > > Cc: Sebastian Reichel > > Cc: Ohad Ben-Cohen > > Cc: Bjorn Andersson > > Cc: Greg Kroah-Hartman > > Signed-off-by: Rob Herring > > > > > diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > index 247ef00381ea..f76b25f7fc7a 100644 > > --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > @@ -83,6 +83,7 @@ properties: > > Phandle of a companion. > > > > phys: > > + maxItems: 1 > > description: PHY specifier for the USB PHY > > > > phy-names: > > diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > > index 2178bcc401bc..8e2bd61f2075 100644 > > --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml > > +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > > @@ -71,6 +71,7 @@ properties: > > Overrides the detected port count > > > > phys: > > + maxItems: 1 > > description: PHY specifier for the USB PHY > > > > phy-names: > > diff --git a/Documentation/devicetree/bindings/usb/ingenic,musb.yaml b/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > > index 678396eeeb78..f506225a4d57 100644 > > --- a/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > > +++ b/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > > @@ -40,7 +40,7 @@ properties: > > - const: mc > > > > phys: > > - description: PHY specifier for the USB PHY > > + maxItems: 1 > > > > usb-role-switch: > > type: boolean > > Any reason you dropped the description for this entry, but not the other > ones above? No, I should have dropped those too. I dropped cases of genericish descriptions on common properties. There's nothing specific to this binding here really. > > > diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > > index 388245b91a55..adce36e48bc9 100644 > > --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > > +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > > @@ -15,13 +15,14 @@ properties: > > - const: ti,j721e-usb > > > > reg: > > - description: module registers > > + maxItems: 1 > > > > power-domains: > > description: > > PM domain provider node and an args specifier containing > > the USB device id value. See, > > Documentation/devicetree/bindings/soc/ti/sci-pm-domain.txt > > + maxItems: 1 > > > > clocks: > > description: Clock phandles to usb2_refclk and lpm_clk > > Same here, why remove the description? Really, the question is why keep 'description' on power-domains. Perhaps there's a little value in the reference to sci-pm-domain.txt, so I left it. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel