From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D876C433E6 for ; Wed, 6 Jan 2021 06:27:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0B07F207B2 for ; Wed, 6 Jan 2021 06:27:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B07F207B2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7p+TaAa4CsG0xCbbceDOuCffK79OyT8hIAfwr9xznf8=; b=0aupbDo/gXGzTguhzNlzaP1Ke 3Yn3SHkBjgIA2CoWcx8YGbrGxWKfG31MkCn7m/gPd25oNae7UGLwXvcRCrgfBtZG87Whq/IxeXMq7 spBc6ej5l6tekvZocktxVQb9QhiaS2Vor3PnWKjHv5RTLnzs029N4AbuK63Smsb9SIvrmIvcphSf+ +xzjXxE7M8zyliUnDZoeLgndCQQY9q2labN2Bfqll3Y49JqHnN+9XyeiG+kBgk8/N6P7AYKMUjzuv 3wOxSAiI5A+x66Yoa7OxbBpG/ACdZrGX28YAKNHTjcIoRpy+qdCZTS3EKh0is1Oim9nI1vBJBqD9O c0KgNXlJw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kx2Ff-0007Fj-Md; Wed, 06 Jan 2021 06:24:59 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kx2Fe-0007FK-8s for linux-arm-kernel@lists.infradead.org; Wed, 06 Jan 2021 06:24:59 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 49481207B2; Wed, 6 Jan 2021 06:24:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609914297; bh=y+0zaAn5avtMtf02YYNkF8iT84BXfRL1v9Z7Is+W+hA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jx+3v0oBYO/hbO1+6ETQe3F/VFiOZPtbTBNgXD/Pp8xpN4LKh4330rBi2fW2Pxy5V oq7OzA+Ju4lCk4t/QJM5NAh20PhgPrgGV/9ubUHefeM01tmGnoDL1JhZG7zCq3l+z5 5WgMrVHJbB01zZCMtE2KVDgb4/amrSe5BB7i9NaVNSzgxX6qqn0UDuG3IeqVeOSSlp B49X0Lvf2YoMbWTSVnKdbm/Yxre2D5XSmZr1Uy5Gp4eevi82xKegKZRVIQuhqeBcuP 8BEl82ipSIbXDsb074gjtW8zUjWN5gCd5IxtBh4ImE3I9blxSWG4kDkBcqjFp6kxn8 9rbKeAgYHHnNg== Date: Wed, 6 Jan 2021 11:54:53 +0530 From: Vinod Koul To: Alexandre Belloni Subject: Re: [PATCH] dmaengine: at_hdmac: remove platform data header Message-ID: <20210106062453.GR2771@vkoul-mobl> References: <20201228203022.2674133-1-alexandre.belloni@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201228203022.2674133-1-alexandre.belloni@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210106_012458_445868_B3E0D417 X-CRM114-Status: UNSURE ( 9.39 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tudor Ambarus , linux-kernel@vger.kernel.org, Ludovic Desroches , dmaengine@vger.kernel.org, Dan Williams , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28-12-20, 21:30, Alexandre Belloni wrote: > linux/platform_data/dma-atmel.h is only used by the at_hdmac driver. Move > the CFG bits definitions back in at_hdmac_regs.h and the remaining > definitions in the driver. Applied, thanks... > /* Bitfields in CFG */ > -/* are in at_hdmac.h */ > +#define ATC_PER_MSB(h) ((0x30U & (h)) >> 4) /* Extract most significant bits of a handshaking identifier */ > + > +#define ATC_SRC_PER(h) (0xFU & (h)) /* Channel src rq associated with periph handshaking ifc h */ > +#define ATC_DST_PER(h) ((0xFU & (h)) << 4) /* Channel dst rq associated with periph handshaking ifc h */ > +#define ATC_SRC_REP (0x1 << 8) /* Source Replay Mod */ > +#define ATC_SRC_H2SEL (0x1 << 9) /* Source Handshaking Mod */ > +#define ATC_SRC_H2SEL_SW (0x0 << 9) > +#define ATC_SRC_H2SEL_HW (0x1 << 9) > +#define ATC_SRC_PER_MSB(h) (ATC_PER_MSB(h) << 10) /* Channel src rq (most significant bits) */ > +#define ATC_DST_REP (0x1 << 12) /* Destination Replay Mod */ > +#define ATC_DST_H2SEL (0x1 << 13) /* Destination Handshaking Mod */ > +#define ATC_DST_H2SEL_SW (0x0 << 13) > +#define ATC_DST_H2SEL_HW (0x1 << 13) > +#define ATC_DST_PER_MSB(h) (ATC_PER_MSB(h) << 14) /* Channel dst rq (most significant bits) */ > +#define ATC_SOD (0x1 << 16) /* Stop On Done */ > +#define ATC_LOCK_IF (0x1 << 20) /* Interface Lock */ > +#define ATC_LOCK_B (0x1 << 21) /* AHB Bus Lock */ > +#define ATC_LOCK_IF_L (0x1 << 22) /* Master Interface Arbiter Lock */ > +#define ATC_LOCK_IF_L_CHUNK (0x0 << 22) > +#define ATC_LOCK_IF_L_BUFFER (0x1 << 22) > +#define ATC_AHB_PROT_MASK (0x7 << 24) /* AHB Protection */ > +#define ATC_FIFOCFG_MASK (0x3 << 28) /* FIFO Request Configuration */ > +#define ATC_FIFOCFG_LARGESTBURST (0x0 << 28) > +#define ATC_FIFOCFG_HALFFIFO (0x1 << 28) > +#define ATC_FIFOCFG_ENOUGHSPACE (0x2 << 28) Make these use BIT() or GENMASK() later..? -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel