From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBF38C433DB for ; Wed, 6 Jan 2021 09:13:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60DE62255F for ; Wed, 6 Jan 2021 09:13:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60DE62255F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4FLiF9UDPOnxqxt9t/lqEJzH/uFZ48mHciEJYzuA6Nw=; b=ntc9K6/rgx6myvmVdn2koMR0R wmuBWVZUe+fedND6pmJB3TjhNZ/wy9UtB9Bfpy9Yc5FgDdlJRGSvHF2TC7+nWFr1xTBC+65+Bqb3V G11FFYN/Z+U2+DiU0kWyQypIcLy+kI1gO4XBKUT0zxUjrD0VZSVndxgbLJXXHobeSZg+7SHyvSph7 8AM+8r5G8tLWMmu0G1dpyXmx1rjBd7wnVwahSlA/+26E1Pp6o5EOa44nIe3+H7yev6KygzALJjwXs OxQSoAz1XsvDqiDLISZP8Y1Yp0pYoi3ZfHu8TiGhLsAeKidY/GCiF8i7GJwxO6zhJvpKhM0MvEr3n IdbTMvEtg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kx4qz-0000EI-BM; Wed, 06 Jan 2021 09:11:41 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kx4qv-0000DA-Fa for linux-arm-kernel@lists.infradead.org; Wed, 06 Jan 2021 09:11:39 +0000 X-Originating-IP: 86.202.109.140 Received: from localhost (lfbn-lyo-1-13-140.w86-202.abo.wanadoo.fr [86.202.109.140]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 49C3E240011; Wed, 6 Jan 2021 09:11:32 +0000 (UTC) Date: Wed, 6 Jan 2021 10:11:31 +0100 From: Alexandre Belloni To: Vinod Koul Subject: Re: [PATCH] dmaengine: at_hdmac: remove platform data header Message-ID: <20210106091131.GL122615@piout.net> References: <20201228203022.2674133-1-alexandre.belloni@bootlin.com> <20210106062453.GR2771@vkoul-mobl> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210106062453.GR2771@vkoul-mobl> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210106_041137_617675_2F0314C1 X-CRM114-Status: GOOD ( 12.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tudor Ambarus , linux-kernel@vger.kernel.org, Ludovic Desroches , dmaengine@vger.kernel.org, Dan Williams , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06/01/2021 11:54:53+0530, Vinod Koul wrote: > On 28-12-20, 21:30, Alexandre Belloni wrote: > > linux/platform_data/dma-atmel.h is only used by the at_hdmac driver. Move > > the CFG bits definitions back in at_hdmac_regs.h and the remaining > > definitions in the driver. > > Applied, thanks... > > > /* Bitfields in CFG */ > > -/* are in at_hdmac.h */ > > +#define ATC_PER_MSB(h) ((0x30U & (h)) >> 4) /* Extract most significant bits of a handshaking identifier */ > > + > > +#define ATC_SRC_PER(h) (0xFU & (h)) /* Channel src rq associated with periph handshaking ifc h */ > > +#define ATC_DST_PER(h) ((0xFU & (h)) << 4) /* Channel dst rq associated with periph handshaking ifc h */ > > +#define ATC_SRC_REP (0x1 << 8) /* Source Replay Mod */ > > +#define ATC_SRC_H2SEL (0x1 << 9) /* Source Handshaking Mod */ > > +#define ATC_SRC_H2SEL_SW (0x0 << 9) > > +#define ATC_SRC_H2SEL_HW (0x1 << 9) > > +#define ATC_SRC_PER_MSB(h) (ATC_PER_MSB(h) << 10) /* Channel src rq (most significant bits) */ > > +#define ATC_DST_REP (0x1 << 12) /* Destination Replay Mod */ > > +#define ATC_DST_H2SEL (0x1 << 13) /* Destination Handshaking Mod */ > > +#define ATC_DST_H2SEL_SW (0x0 << 13) > > +#define ATC_DST_H2SEL_HW (0x1 << 13) > > +#define ATC_DST_PER_MSB(h) (ATC_PER_MSB(h) << 14) /* Channel dst rq (most significant bits) */ > > +#define ATC_SOD (0x1 << 16) /* Stop On Done */ > > +#define ATC_LOCK_IF (0x1 << 20) /* Interface Lock */ > > +#define ATC_LOCK_B (0x1 << 21) /* AHB Bus Lock */ > > +#define ATC_LOCK_IF_L (0x1 << 22) /* Master Interface Arbiter Lock */ > > +#define ATC_LOCK_IF_L_CHUNK (0x0 << 22) > > +#define ATC_LOCK_IF_L_BUFFER (0x1 << 22) > > +#define ATC_AHB_PROT_MASK (0x7 << 24) /* AHB Protection */ > > +#define ATC_FIFOCFG_MASK (0x3 << 28) /* FIFO Request Configuration */ > > +#define ATC_FIFOCFG_LARGESTBURST (0x0 << 28) > > +#define ATC_FIFOCFG_HALFFIFO (0x1 << 28) > > +#define ATC_FIFOCFG_ENOUGHSPACE (0x2 << 28) > > Make these use BIT() or GENMASK() later..? > Sure but for this patch, I wanted to make it clear that this was just moving code around. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel