From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FFAEC433DB for ; Wed, 6 Jan 2021 15:15:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06FA12311B for ; Wed, 6 Jan 2021 15:15:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06FA12311B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tbA6WdA3umn5iBkPgD3kOWGf7AkvjClA9NhMBJ7VFgk=; b=jD+UsMTXMo3AEiv7PZ2q+8OBe IbJ2SwA8utzYpztFVXd/uME1oUNZlE/C6JC2sbq0JYgNHlSIApMFFMjxOFuVXF7+4n1WkL+Acabsp JOKLuwYCAykW3pOJkn6crxWqTKF2R42iepXhDJL3w5b+LfX6MsjAcxdhqmm5Cfgc1B/UbmrvuSJH4 Yz/o2AxfDE44lnQVPY00M8GZ4awWtd8gIjmCCds18dNT1Qgm1YjmUURcTKpSLHyZpn0ngorHsAO3y PzsK3PV2az8Skhv7QCVfHEbo8Q6HpDzJeVgZInpG6TweY++vcehdW3b1MkYRiwpHbXtG23S9sVei4 vOf5M9WqQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxAUJ-0006Za-Pt; Wed, 06 Jan 2021 15:12:39 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxAUF-0006Yg-QF for linux-arm-kernel@lists.infradead.org; Wed, 06 Jan 2021 15:12:37 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 860F05C00FE; Wed, 6 Jan 2021 10:12:35 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 06 Jan 2021 10:12:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=P5/Tb7LCaQ16J1NVwYWbEViIiEf m9aUGJePzAFUKyxU=; b=e+fdxNwrL9Mkdbm3OSoQB4EZOWDfLAzCF5AMwr3SaYE 3cOlgBiXyNMuLC1hoeH5i3dDSPFIK0sVblM6f5irtZiOS5FDdiVnOFJ8sEt7uGVt Gkaaxc9JQtqvHUELb8dW1E0YAHUzMjG8ZbUZ5yhGiJXrQLmHlSnc9Ep7/N7f4sAd HPxm1B+er9ptFe523Rmo56B/CPNWMsyTnGyDFXDZ4iN2mJ3CCvw2/vL52Kwp6KN2 Phak5i8PXj3OWhJve0JTFY0uZyboL/NLfwts93PcpsBzBxv6TJuJ289iIL9RgJKO ++d2HK0/a9FuLbo5MmRjQRutHE8ihQaO/caRQ8clXIQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=P5/Tb7 LCaQ16J1NVwYWbEViIiEfm9aUGJePzAFUKyxU=; b=ZuY1KCgGGjy0ebo7b46DGb 7E9nufoQwxfcZIYaquXX0T31VAOZyHTbkCxMDWIl9GiVgv4M9O6nuSsRK2BejNR0 0mU3dTr3xzIzsEyRUZdle2Vl05Sr77y8oT7e/nxG3dQX7MdwNo0sXdDdJ1ymC/WO jU0HB09C5V/HTYMnE5Ap5pzqw3VI9xYakb28UvhFabfrctHKNChG4QgutX5/BdWN Mitk3j7zfdEP6iOvHebG/jtosfM1v5Kv6HKU4k2pympTNs4xMoG5ZR5oReMWfyyg Z1NEfGuq70zWQ5vgZUxPZtUDz9+Rk8lHNKT5p5QyWrFRKUD/dch0l36aoCPeshTg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdefledgjeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepffetteevieejteeuhfffgeektefghfeileehhedtuddutefhhfejtddvtddu ledvnecuffhomhgrihhnpeguvghvihgtvghtrhgvvgdrohhrghenucfkphepledtrdekle drieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 576AD240066; Wed, 6 Jan 2021 10:12:33 -0500 (EST) Date: Wed, 6 Jan 2021 16:12:32 +0100 From: Maxime Ripard To: Stefan Wahren Subject: Re: [PATCH V2 4/4] dt-bindings: gpu: Convert v3d to json-schema Message-ID: <20210106151232.egv2d33rtw462iiw@gilmour> References: <1608755714-18233-1-git-send-email-stefan.wahren@i2se.com> <1608755714-18233-5-git-send-email-stefan.wahren@i2se.com> MIME-Version: 1.0 In-Reply-To: <1608755714-18233-5-git-send-email-stefan.wahren@i2se.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210106_101235_953219_73D63CA0 X-CRM114-Status: GOOD ( 25.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, David Airlie , dri-devel@lists.freedesktop.org, Eric Anholt , Rob Herring , linux-arm-kernel@lists.infradead.org, Daniel Vetter , Nicolas Saenz Julienne Content-Type: multipart/mixed; boundary="===============0472272982461035880==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0472272982461035880== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tnol5fwcnhnynxmr" Content-Disposition: inline --tnol5fwcnhnynxmr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 23, 2020 at 09:35:14PM +0100, Stefan Wahren wrote: > This converts the v3d bindings to yaml format. >=20 > Signed-off-by: Stefan Wahren > --- > .../devicetree/bindings/gpu/brcm,bcm-v3d.txt | 33 ---------- > .../devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 76 ++++++++++++++++= ++++++ > 2 files changed, 76 insertions(+), 33 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.txt > create mode 100644 Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.ya= ml >=20 > diff --git a/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.txt b/Doc= umentation/devicetree/bindings/gpu/brcm,bcm-v3d.txt > deleted file mode 100644 > index b2df82b..0000000 > --- a/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.txt > +++ /dev/null > @@ -1,33 +0,0 @@ > -Broadcom V3D GPU > - > -Only the Broadcom V3D 3.x and newer GPUs are covered by this binding. > -For V3D 2.x, see brcm,bcm-vc4.txt. > - > -Required properties: > -- compatible: Should be "brcm,7268-v3d" or "brcm,7278-v3d" > -- reg: Physical base addresses and lengths of the register areas > -- reg-names: Names for the register areas. The "hub" and "core0" > - register areas are always required. The "gca" register area > - is required if the GCA cache controller is present. The > - "bridge" register area is required if an external reset > - controller is not present. > -- interrupts: The interrupt numbers. The first interrupt is for the hub, > - while the following interrupts are separate interrupt lines > - for the cores (if they don't share the hub's interrupt). > - See bindings/interrupt-controller/interrupts.txt > - > -Optional properties: > -- clocks: The core clock the unit runs on > -- resets: The reset line for v3d, if not using a mapping of the bridge > - See bindings/reset/reset.txt > - > -v3d { > - compatible =3D "brcm,7268-v3d"; > - reg =3D <0xf1204000 0x100>, > - <0xf1200000 0x4000>, > - <0xf1208000 0x4000>, > - <0xf1204100 0x100>; > - reg-names =3D "bridge", "hub", "core0", "gca"; > - interrupts =3D <0 78 4>, > - <0 77 4>; > -}; > diff --git a/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml b/Do= cumentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml > new file mode 100644 > index 0000000..a2b06d42 > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml > @@ -0,0 +1,76 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/gpu/brcm,bcm-v3d.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Broadcom V3D GPU Bindings > + > +maintainers: > + - Eric Anholt > + - Nicolas Saenz Julienne > + > +properties: > + $nodename: > + pattern: '^gpu@[a-f0-9]+$' > + > + compatible: > + enum: > + - brcm,7268-v3d > + - brcm,7278-v3d > + > + reg: > + items: > + - description: hub register > + - description: core0 register > + - description: GCA cache controller register (if GCA controller) > + - description: bridge register (if no external reset controller) > + minItems: 2 > + maxItems: 4 > + > + reg-names: > + items: > + enum: [ bridge, core0, gca, hub ] > + minItems: 2 > + maxItems: 4 It's not really clear here what interrupts are expected. I assume that bridge and core0 are always supposed to be here, but gca and hub are optional? It would be a bit cumbersome to get it to check properly, but we can at least make it obvious in the binding with a comment or the description > + > + interrupts: > + items: > + - description: hub interrupt > + - description: core interrupt (if it doesn't share the hub's inter= rupt) > + minItems: 1 > + maxItems: 2 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + maxItems: 1 This property wasn't in the previous binding? Maxime --tnol5fwcnhnynxmr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX/XTYAAKCRDj7w1vZxhR xeX5AP9AviPTqeBta4BqK7rpLkhbLmluVMjvq1x/qNn1nKXXRwD+JlpAS4gfPcmh zcmHc6mNlGhVfxLdgD+Zp5v+4b0fJws= =Yix0 -----END PGP SIGNATURE----- --tnol5fwcnhnynxmr-- --===============0472272982461035880== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0472272982461035880==--