From: Bjorn Helgaas <helgaas@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Realtek linux nic maintainers <nic_swsd@realtek.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Jakub Kicinski <kuba@kernel.org>,
David Miller <davem@davemloft.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/3] ARM: iop32x: improve N2100 PCI broken parity quirk'
Date: Wed, 6 Jan 2021 11:37:25 -0600 [thread overview]
Message-ID: <20210106173725.GA1316633@bjorn-Precision-5520> (raw)
In-Reply-To: <5b100322-7a53-8f5e-32f9-a67c3cd2beeb@gmail.com>
On Wed, Jan 06, 2021 at 12:05:41PM +0100, Heiner Kallweit wrote:
> Use new PCI core function pci_quirk_broken_parity(), in addition to
> setting broken_parity_status is disables parity checking.
That sentence has a typo or something so it doesn't read quite right.
Maybe:
Use new PCI core function pci_quirk_broken_parity() to disable
parity checking.
"broken_parity_status" is basically internal to the PCI core and
doesn't really seem relevant here. The only uses are the sysfs
store/show functions and edac.
> This allows us to remove a quirk in r8169 driver.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> v2:
> - remove additional changes from this patch
> ---
> arch/arm/mach-iop32x/n2100.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-iop32x/n2100.c b/arch/arm/mach-iop32x/n2100.c
> index 78b9a5ee4..9f2aae3cd 100644
> --- a/arch/arm/mach-iop32x/n2100.c
> +++ b/arch/arm/mach-iop32x/n2100.c
> @@ -125,7 +125,7 @@ static void n2100_fixup_r8169(struct pci_dev *dev)
> if (dev->bus->number == 0 &&
> (dev->devfn == PCI_DEVFN(1, 0) ||
> dev->devfn == PCI_DEVFN(2, 0)))
> - dev->broken_parity_status = 1;
> + pci_quirk_broken_parity(dev);
> }
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_REALTEK, PCI_ANY_ID, n2100_fixup_r8169);
>
> --
> 2.30.0
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-06 17:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 11:01 [PATCH v2 0/3] PCI: Disable parity checking if broken_parity is set Heiner Kallweit
2021-01-06 11:03 ` [PATCH v2 1/3] " Heiner Kallweit
2021-01-06 11:05 ` [PATCH v2 2/3] ARM: iop32x: improve N2100 PCI broken parity quirk Heiner Kallweit
2021-01-06 17:37 ` Bjorn Helgaas [this message]
2021-01-06 17:47 ` [PATCH v2 2/3] ARM: iop32x: improve N2100 PCI broken parity quirk' Heiner Kallweit
2021-01-06 11:06 ` [PATCH v2 3/3] r8169: simplify broken parity handling now that PCI core takes care Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210106173725.GA1316633@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).