From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F75EC433DB for ; Wed, 6 Jan 2021 17:40:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17A1A20657 for ; Wed, 6 Jan 2021 17:40:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17A1A20657 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID:Subject:To:From: Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=Cxk3SOu7ix+QBEmEedQZHu7Fz8H4SNCDscY/em38umM=; b=mSlRgqtw8Li+pitdvDF3MLdhy xPq/1eQV7BBENISl3QpicrAQqi2CyJ33WN2U40RbUypuD+c9JOYM/EQoZ8DUVXcLF68n0+rHPyv4A 5F33ZYQW0gqeDIPHNpipxtDRpyQiINrsdsTuuEIuRrrEykFm3PjkLWkHsEcRCbZxUMLa0uPNJFOFA Mc3Yg21lFA6h5kdYVC+vkiws16vV9xZFL3Q+vhGaB7rPvN9w80q7qiF9Xavy3XeiH3iUReNpk/Bj7 sRYtXXtBiQ4n8ZtfNHmb0P8MG/AeMByXKrCEL274y+VzieemIl0KnctYwoPZR1IEkGKb5Fsp+WcdR oq5MVeYKg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxCkU-00055i-Rv; Wed, 06 Jan 2021 17:37:30 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxCkS-00055I-Kz for linux-arm-kernel@lists.infradead.org; Wed, 06 Jan 2021 17:37:29 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 227E020657; Wed, 6 Jan 2021 17:37:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609954647; bh=wvCVgOmz5rBzTWJyX2HIEq3vemRTXSP5tILnLdbiAZw=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=XgqHOe0d7ap68Z6006lUxnkcWOBj/0K2UTyaLuPru5ONzSPJZfXL+q0+fTFqrIgyD QQsSDapc5Qg7l0wd35+8zkewKTj+A4JosJ5vBgW6ggWUHtWJPk9YnB8mMiAbmX5/wo smIlQotSwH+mwEbEwER/4UayfFNHYcUSTtRZSAeZEZxmgRbdoumoUd6MGe5BvYNhzd ZrcRjKrTRX4845TkN6QU50e/CsHpKXVki3STuroxXWAbVdADv5oRSlHviQFAWMXIXO iFriYHv6EQmG1cteXacXLRID4PyaIqay15NDttgMMEKcLbtwncfjnlQ7ExvaOKO95C RNnU4KwwFhM2w== Date: Wed, 6 Jan 2021 11:37:25 -0600 From: Bjorn Helgaas To: Heiner Kallweit Subject: Re: [PATCH v2 2/3] ARM: iop32x: improve N2100 PCI broken parity quirk' Message-ID: <20210106173725.GA1316633@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5b100322-7a53-8f5e-32f9-a67c3cd2beeb@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210106_123728_774764_C3D7FC89 X-CRM114-Status: GOOD ( 18.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Realtek linux nic maintainers , "linux-pci@vger.kernel.org" , Russell King - ARM Linux , "netdev@vger.kernel.org" , Bjorn Helgaas , Jakub Kicinski , David Miller , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 06, 2021 at 12:05:41PM +0100, Heiner Kallweit wrote: > Use new PCI core function pci_quirk_broken_parity(), in addition to > setting broken_parity_status is disables parity checking. That sentence has a typo or something so it doesn't read quite right. Maybe: Use new PCI core function pci_quirk_broken_parity() to disable parity checking. "broken_parity_status" is basically internal to the PCI core and doesn't really seem relevant here. The only uses are the sysfs store/show functions and edac. > This allows us to remove a quirk in r8169 driver. > > Signed-off-by: Heiner Kallweit > --- > v2: > - remove additional changes from this patch > --- > arch/arm/mach-iop32x/n2100.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-iop32x/n2100.c b/arch/arm/mach-iop32x/n2100.c > index 78b9a5ee4..9f2aae3cd 100644 > --- a/arch/arm/mach-iop32x/n2100.c > +++ b/arch/arm/mach-iop32x/n2100.c > @@ -125,7 +125,7 @@ static void n2100_fixup_r8169(struct pci_dev *dev) > if (dev->bus->number == 0 && > (dev->devfn == PCI_DEVFN(1, 0) || > dev->devfn == PCI_DEVFN(2, 0))) > - dev->broken_parity_status = 1; > + pci_quirk_broken_parity(dev); > } > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_REALTEK, PCI_ANY_ID, n2100_fixup_r8169); > > -- > 2.30.0 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel