From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5FABC433E0 for ; Wed, 6 Jan 2021 17:49:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 900612311B for ; Wed, 6 Jan 2021 17:49:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 900612311B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kLfg/2yzqMcMP6o61+eHfuMyhwKQcSd/8qWmHB0UD0Y=; b=DsgnQErJecssuccfI4bo6NTqf 06YkLfNuY2y9yWgZu/2LC85/m+ZdDbu9B2Kxw/DpEROrhpCVLx9mNGh5RoMppEMmoH6SsKWaaD7rc PV46Hknn187ozcW0QPeJLXvTBFsJpS41Asm/YBx0fH6UPQQqhfuGaVNwL18HsfzbQgNC/92IF8ke5 Tv0vlliw7KIKNRNJ//6bsqPZI0gv3i+we52GQ7tiY3n/er5WVU3qmV0MheZRZxmj+K1FEIbNNiFdt /CgX4d5bmk8+717TkSSZ7FKJ2O6Dk1KHK+VsqPBbceW9wRa2k//AbfDIgqWiZ/hRtUv9DmI4O2kfp IS4vPbkwQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxCsu-0006Bj-Bb; Wed, 06 Jan 2021 17:46:12 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxCsr-0006B9-Hf for linux-arm-kernel@lists.infradead.org; Wed, 06 Jan 2021 17:46:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=yg/yc1gkRipPRCPATrDmoHEixH/ByfJCw5yp10C32Mw=; b=iLVcD3MNntOoNsrc0twA4vn/2 dcdOulHlRF7RTJYqGc7d5mZGg13191U1JDHaH1aIqf0pRRtwAn4Pg1OGDHAYNhOHfFFmLH+amL9ms 4EiYNSBK6NJmg8NG9un8MeQv/3HgXzySX/tEQV9F7Knv5+ubCrSEHJk7TY8P22yr5hw67KlcwBlgc 9vGwVl8roCskmgHfp670zsadJr6CNkw6tlfM2hEjxpx3i4UHkNRhIRFC2hccL84FAeYy5mrY4OM/l W/qZ5Y43ELnfV5RDxklcOm8Ml/c/S0qL1u7UtdrDffTeQHle9+ErM3cLTUW6jHHcUawXNmjh7xYbY 4ZtL9/bmQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:45192) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kxCso-0001rk-Pm; Wed, 06 Jan 2021 17:46:06 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kxCsn-0000QR-Qs; Wed, 06 Jan 2021 17:46:05 +0000 Date: Wed, 6 Jan 2021 17:46:05 +0000 From: Russell King - ARM Linux admin To: Will Deacon Subject: Re: Aarch64 EXT4FS inode checksum failures - seems to be weak memory ordering issues Message-ID: <20210106174605.GL1551@shell.armlinux.org.uk> References: <20210105154726.GD1551@shell.armlinux.org.uk> <20210106115359.GB26994@C02TD0UTHF1T.local> <20210106135253.GJ1551@shell.armlinux.org.uk> <20210106172033.GA2165@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210106172033.GA2165@willie-the-truck> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210106_124609_653780_D30D7107 X-CRM114-Status: GOOD ( 20.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Theodore Ts'o , linux-kernel@vger.kernel.org, Andreas Dilger , linux-ext4@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 06, 2021 at 05:20:34PM +0000, Will Deacon wrote: > I've managed to reproduce the corruption on my AMD Seattle board (8x A57). > I haven't had a chance to dig deeper yet, but here's the recipe which works > for me: > > 1. I'm using GCC 4.9.4 simply to try to get as close as I can to rmk's > setup. I don't know if this is necessary or not, but the toolchain is > here: > > https://kernel.org/pub/tools/crosstool/files/bin/arm64/4.9.4/arm64-gcc-4.9.4-nolibc-aarch64-linux-gnu.tar.xz > > and I needed to pull down an old libmpfr to get cc1 to work: > > http://ports.ubuntu.com/pool/main/m/mpfr4/libmpfr4_3.1.2-1_arm64.deb > > 2. I build a 5.9 kernel with the config here: > > https://mirrors.edge.kernel.org/pub/linux/kernel/people/will/bugs/rmk/config-5.9.0 > > and the resulting Image is here: > > https://mirrors.edge.kernel.org/pub/linux/kernel/people/will/bugs/rmk/Image-5.9.0 > > 3. Using that kernel, I boot into a 64-bit Debian 10 filesystem and open a > couple of terminals over SSH. > > 4. In one terminal, I run: > > $ while (true); do find /var /usr /bin /sbin -type f -print0 | xargs -0 > md5sum > /dev/null; echo 2 | sudo tee /proc/sys/vm/drop_caches; done > > (note that sudo will prompt you for a password on the first iteration) > > 5. In the other terminal, I run: > > $ while (true); do ./hackbench ; sleep 1; done > > where hackbench is built from: > > https://people.redhat.com/mingo/cfs-scheduler/tools/hackbench.c > > and compiled according to comment in the source code. > > With that, I see the following after ten seconds or so: > > EXT4-fs error (device sda2): ext4_lookup:1707: inode #674497: comm md5sum: iget: checksum invalid > > Russell, Mark -- does this recipe explode reliably for you too? It took a couple of iterations of the find loop (4) here on a kernel where I'd dropped BLK_WBT=y from my .config... whereas I wasn't able to provoke it before. So running hackbench in parallel seems to increase the probability. I rebooted, set it going again, and on the first iteration it exploded with ext4 inode checksum failure. And again on the following reboot. So yes, it looks like you've found a way to more reliably reproduce it. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel