From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 458DFC433DB for ; Wed, 6 Jan 2021 19:21:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 096AE2311B for ; Wed, 6 Jan 2021 19:21:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 096AE2311B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID:Subject:To:From: Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=aLmN8BVKIgR3l9Cs9TlD5R0R9RH596lvFZ2LhMfsFjI=; b=KqicpqCHu05HCuqU3V8m6G6rt px5wQZm+kwdYB1VVWik7UwELcCPhOEPBGDFfUTJwh4PZ1QngVUz0GwPLjuQ8SuMveRI5RhtD2V73h bCme4fHBzvHpjlKeBNXz2Xhtb9CiVEcN380WBbsqI9hysoKDKKb9IpB2dRqIlcgADWZdYfabqphsg li3fAjn2kyTxOsMEyIXbWl9fPeC5CcpfPvHuhhC+3Y3s0C7V8HUODTpEc9XmR7lVGsTvNjvhRe9HS rmZ/nXMKGKATGu0Xcq5AGTVgXvubVhEEolMjJWTKzwHiTPXtWUXz5BQYAfzOZUpuVp0Msu9GCVUqV fkK17HBOw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxELa-0006lr-QC; Wed, 06 Jan 2021 19:19:54 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxELY-0006lT-5U; Wed, 06 Jan 2021 19:19:52 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id B221C2311B; Wed, 6 Jan 2021 19:19:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609960791; bh=U+g+SuPIZ3hN3vmlC/G3kLSsF0KrlCHBBpEFAdw5Ufc=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=DONdN+za2JdOMS2tkNX8Udx10Mgoz1zTTX4/LKKwowRFEzME2OtA9A7gmmeMPWWqo ViCopXvbUuS9KNaQHGfPb2KNJUv2pQY+2eSXaKusAxA1jHrDa7Aw3OVlSSdCjf2F7b LUiof3UhPYIzqo04pYAHvwWWdU1jbFg50riZk1G1XuGS38/rFuqksebfc6jnNU84vT 0QIqwREaJTIxPCw/n2g7XnsER++6GD/SsPJtmOIpPcnX5eGZ0CybB0GsIYWsLc9/Zn Jw5P9CuYgde/UB1DwI5gwNDrz8BP+06XjI+7xckZG4jU1Ri2ar71uDh3FYw7LGlzt9 h2rtn0rv1WNfg== Date: Wed, 6 Jan 2021 13:19:49 -0600 From: Bjorn Helgaas To: Jim Quinlan Subject: Re: [PATCH v2 5/6] PCI: brcmstb: Add panic/die handler to RC driver Message-ID: <20210106191949.GA1328757@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201130211145.3012-6-james.quinlan@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210106_141952_295366_B8786084 X-CRM114-Status: GOOD ( 10.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Lorenzo Pieralisi , linux-pci@vger.kernel.org, open list , broonie@kernel.org, bcm-kernel-feedback-list@broadcom.com, "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Bjorn Helgaas , Florian Fainelli , Nicolas Saenz Julienne Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 30, 2020 at 04:11:42PM -0500, Jim Quinlan wrote: > Whereas most PCIe HW returns 0xffffffff on illegal accesses and the like, > by default Broadcom's STB PCIe controller effects an abort. This simple > handler determines if the PCIe controller was the cause of the abort and if > so, prints out diagnostic info. > > Example output: > brcm-pcie 8b20000.pcie: Error: Mem Acc: 32bit, Read, @0x38000000 > brcm-pcie 8b20000.pcie: Type: TO=0 Abt=0 UnspReq=1 AccDsble=0 BadAddr=0 What does this mean for all the other PCI core code that expects 0xffffffff data returns? Does it work? Does it break differently on STB than on other platforms? > +/* > + * Dump out pcie errors on die or panic. s/pcie/PCIe/ This could be a single-line comment. > + */ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel