From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E572EC433DB for ; Wed, 6 Jan 2021 19:24:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 921482311B for ; Wed, 6 Jan 2021 19:24:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 921482311B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID:Subject:To:From: Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=V7Jg8jhRwsKJIv/4Qj/Ktu6aOeHkNVAWT5aKFv+kFSs=; b=pPenhH6tdzczGs73vovybIavr 8Q150ALadubtafKEKHRk6wmtaVsX6V4e7lrZghXrUpqkGWQ22f4uePQBcLa44JMyCNn2k9m4CtkLh SUN7VIUX03gz2i/PkaBpBvpXUSqh7SDFdq7QzjhkPK9WzQj/RnOpVYGYDHpCleiitXI0hA8g/Fzun Np20IEvlFbCJ7/bSeiEX7EaD89sDBlPWCGQ7a/ldMlxyLAP5X1+qnL8G9KAAHUY9PRGnfaFrgOngn WhwKI7oy+G+WJ9Zc5e959EkPpi4xiEVIuiPVF6E7+UXKJK0gsx+/K7VM9zveqZqJ1qPx6bvAQnlwr NvPpTUBmw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxEOF-0007Af-0X; Wed, 06 Jan 2021 19:22:39 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxEOC-0007A7-E8 for linux-arm-kernel@lists.infradead.org; Wed, 06 Jan 2021 19:22:37 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1201C2311B; Wed, 6 Jan 2021 19:22:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609960955; bh=RXHsLQtWdosGRs1gseCy3y7sgHRpinIQi/zgMsifvFU=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=Vl2LOzH8x0qYlMyLbJ0l++GdU/D8nW3gLhL03xYpjX0RewIERSygJpcK+X2Z+JLQK oJnxuQnQxWrp8irH1HISVj/tlZDS6obZ1KGLwN1mB2LyLGAODFI1OxV8t1dtI7E9N8 z/04+t6tTqqiNfriq6OtRs3hWydrCyXGlZnPrwz8tu8eFEUDD+jYoHRCs3/EmFE99g DH8PnI2XNL9f0pNj9ifWlqYpVOdONJXcrK75zs97JPowp9ChR7Julndq+7sbvIykFK S/zpTvjK/bB3rxZ2D9nUkNmBKA/AetCPyKSNGtmkFpYL3pAL3wY6/iO6ESWkxDeOnS bHAvP0pUtjiKA== Date: Wed, 6 Jan 2021 13:22:33 -0600 From: Bjorn Helgaas To: Heiner Kallweit Subject: Re: [PATCH v3 1/3] PCI: Disable parity checking if broken_parity is set Message-ID: <20210106192233.GA1329080@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210106_142236_625332_99EF3C2B X-CRM114-Status: GOOD ( 21.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Realtek linux nic maintainers , "linux-pci@vger.kernel.org" , Russell King - ARM Linux , "netdev@vger.kernel.org" , Bjorn Helgaas , Jakub Kicinski , David Miller , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 06, 2021 at 06:50:22PM +0100, Heiner Kallweit wrote: > If we know that a device has broken parity checking, then disable it. > This avoids quirks like in r8169 where on the first parity error > interrupt parity checking will be disabled if broken_parity_status > is set. Make pci_quirk_broken_parity() public so that it can be used > by platform code, e.g. for Thecus N2100. > > Signed-off-by: Heiner Kallweit > Reviewed-by: Leon Romanovsky Acked-by: Bjorn Helgaas This series should all go together. Let me know if you want me to do anything more (would require acks for arm and r8169, of course). > --- > drivers/pci/quirks.c | 17 +++++++++++------ > include/linux/pci.h | 2 ++ > 2 files changed, 13 insertions(+), 6 deletions(-) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index 653660e3b..ab54e26b8 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -205,17 +205,22 @@ static void quirk_mmio_always_on(struct pci_dev *dev) > DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_ANY_ID, PCI_ANY_ID, > PCI_CLASS_BRIDGE_HOST, 8, quirk_mmio_always_on); > > +void pci_quirk_broken_parity(struct pci_dev *dev) > +{ > + u16 cmd; > + > + dev->broken_parity_status = 1; /* This device gives false positives */ > + pci_read_config_word(dev, PCI_COMMAND, &cmd); > + pci_write_config_word(dev, PCI_COMMAND, cmd & ~PCI_COMMAND_PARITY); > +} > + > /* > * The Mellanox Tavor device gives false positive parity errors. Mark this > * device with a broken_parity_status to allow PCI scanning code to "skip" > * this now blacklisted device. > */ > -static void quirk_mellanox_tavor(struct pci_dev *dev) > -{ > - dev->broken_parity_status = 1; /* This device gives false positives */ > -} > -DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_MELLANOX, PCI_DEVICE_ID_MELLANOX_TAVOR, quirk_mellanox_tavor); > -DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_MELLANOX, PCI_DEVICE_ID_MELLANOX_TAVOR_BRIDGE, quirk_mellanox_tavor); > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_MELLANOX, PCI_DEVICE_ID_MELLANOX_TAVOR, pci_quirk_broken_parity); > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_MELLANOX, PCI_DEVICE_ID_MELLANOX_TAVOR_BRIDGE, pci_quirk_broken_parity); > > /* > * Deal with broken BIOSes that neglect to enable passive release, > diff --git a/include/linux/pci.h b/include/linux/pci.h > index b32126d26..161dcc474 100644 > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -1916,6 +1916,8 @@ enum pci_fixup_pass { > pci_fixup_suspend_late, /* pci_device_suspend_late() */ > }; > > +void pci_quirk_broken_parity(struct pci_dev *dev); > + > #ifdef CONFIG_HAVE_ARCH_PREL32_RELOCATIONS > #define __DECLARE_PCI_FIXUP_SECTION(sec, name, vendor, device, class, \ > class_shift, hook) \ > -- > 2.30.0 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel