From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21890C433E0 for ; Thu, 7 Jan 2021 03:21:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C779122BEA for ; Thu, 7 Jan 2021 03:21:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C779122BEA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uZoF698PlyJusssTakQ2nRCnc6mf4OCbwIK1hD5XlOU=; b=Q9v/nHwwcHQGAXqeOYcbeuzJo M02Ym/EVH5jzgg4n2kztmHCOQP00hol0DGPTcFlcBOSzV2Ad5PCQYJpaXPJK8KFCayTalSCnPbVlb 1w+2qVvWHnfuZ36C88nHUaq33nrz5BbxJis6A/Mz2faj6lgnQPKStOXiBzfJe7xKheX1tAehcjCEJ zfguXz/VIv+kpWGBJsu5jE7P1F7h0o4I+EcfcNM6Xp71whmBt44+IenPHqEc/dU2zKpNfXeRP65Fw QmZCS/ZIWKFGoCUfmNyzUDMU/r0syN7jM0yOM35CtPq5Sbh2U5+bmfQfSCBTelTM4J3HquXEHHsw5 H9DieulDg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxLpq-0008Sm-IR; Thu, 07 Jan 2021 03:19:38 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxLpo-0008SO-Tz for linux-arm-kernel@lists.infradead.org; Thu, 07 Jan 2021 03:19:37 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 480D822BEA; Thu, 7 Jan 2021 03:19:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609989575; bh=l6Wn9Rs2IWSTtUm8c7IW6SPvlrUk79/vwe/pvPbmstU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rmd5/I8pwnF4RnmyAmTzpQ21qzL1fXSeebeU3vM3mhyn8Jq0tvzLN1yUm0BDCKO4Y kYTFkxKlgPFCIsMsdTFnIHrIN/QQcaXyNvqQX7uafXBOXE6NTWP0bPXWvs3jog0FR9 Hg4F8qQNnzICa6RoM6y1vk1AlJpmwUOPqrU4fmuYFzKUzSH3sg4ArBMbELmpdj+K51 It6afItoG9BLz7SLz7JydxsevcxDbioUWXxWAE9ZaP5rtSqvqmhsH/CZ+43yX42WCN 07FtVPAYaR+uKCnjMow11EzVRC7Yw3UUqHsudpAdTCv0euLhjqJLu7qWEHBmsBkmIo UJ93kl4YVyZfg== Date: Thu, 7 Jan 2021 11:19:29 +0800 From: Shawn Guo To: Oleksij Rempel Subject: Re: [PATCH v1] ARM: imx: mach-imx6ul: remove 14x14 EVK specific PHY fixup Message-ID: <20210107031928.GS4142@dragon> References: <20201209122051.26151-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201209122051.26151-1-o.rempel@pengutronix.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210106_221937_057420_EAB08C88 X-CRM114-Status: GOOD ( 17.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Florian Fainelli , netdev@vger.kernel.org, Sascha Hauer , linux-kernel@vger.kernel.org, Russell King , Philippe Schenker , linux-imx@nxp.com, kernel@pengutronix.de, David Jander , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 09, 2020 at 01:20:51PM +0100, Oleksij Rempel wrote: > Remove board specific PHY fixup introduced by commit: > > | 709bc0657fe6f9f5 ("ARM: imx6ul: add fec MAC refrence clock and phy fixup init") > > This fixup addresses boards with a specific configuration: a KSZ8081RNA > PHY with attached clock source to XI (Pin 8) of the PHY equal to 50MHz. > > For the KSZ8081RND PHY, the meaning of the reg 0x1F bit 7 is different > (compared to the KSZ8081RNA). A set bit means: > > - KSZ8081RNA: clock input to XI (Pin 8) is 50MHz for RMII > - KSZ8081RND: clock input to XI (Pin 8) is 25MHz for RMII > > In other configurations, for example a KSZ8081RND PHY or a KSZ8081RNA > with 25Mhz clock source, the PHY will glitch and stay in not recoverable > state. > > It is not possible to detect the clock source frequency of the PHY. And > it is not possible to automatically detect KSZ8081 PHY variant - both > have same PHY ID. It is not possible to overwrite the fixup > configuration by providing proper device tree description. The only way > is to remove this fixup. > > If this patch breaks network functionality on your board, fix it by > adding PHY node with following properties: > > ethernet-phy@x { > ... > micrel,led-mode = <1>; > clocks = <&clks IMX6UL_CLK_ENET_REF>; > clock-names = "rmii-ref"; > ... > }; > > The board which was referred in the initial patch is already fixed. > See: arch/arm/boot/dts/imx6ul-14x14-evk.dtsi > > Signed-off-by: Oleksij Rempel Applied, thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel