From: Sascha Hauer <s.hauer@pengutronix.de>
To: linux-edac@vger.kernel.org
Cc: Tony Luck <tony.luck@intel.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Robert Richter <rrichter@marvell.com>,
James Morse <james.morse@arm.com>,
kernel@pengutronix.de, Borislav Petkov <bp@alien8.de>,
York Sun <york.sun@nxp.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/1] Add L1 and L2 error detection for A53 and A57
Date: Thu, 7 Jan 2021 11:38:18 +0100 [thread overview]
Message-ID: <20210107103819.13552-1-s.hauer@pengutronix.de> (raw)
Hi all,
It's been a while since I last sent this, so here's an update.
Like Rob suggested I dropped using a virtual device tree node
to attach the driver to, so from the original three patches series
is only one patch left now. I think I have integrated all review
feedback I got last time, please have a look.
One thing that I find unfortunate in the driver is that I have to
register the "cpu" hierarchy under edac for all CPUs. Only the
CPUs supported by this driver actually count anything. On JUNO for
example we have four cortex-a53 cores (which are supported by this
driver) and four cortex-a72 cores (which are not supported).
Nevertheless we create the directory hierarchy for all eight cores.
I don't know how I should work around this, but maybe James has an
idea.
As usual, feedback welcome.
Sascha
Changes since v2:
- drop usage of virtual dt node (Robh)
- use read_sysreg_s instead of open coded variant (James Morse)
- separate error retrieving from error reporting
- use smp_call_function_single rather than smp_call_function_single_async
- make driver single instance and register all 'cpu' hierarchy up front once
Changes since v1:
- Split dt-binding into separate patch
- Sort local function variables in reverse-xmas tree order
- drop unnecessary comparison and make variable bool
Sascha Hauer (1):
drivers/edac: Add L1 and L2 error detection for A53 and A57
drivers/edac/Kconfig | 6 +
drivers/edac/Makefile | 1 +
drivers/edac/cortex_arm64_l1_l2.c | 218 ++++++++++++++++++++++++++++++
3 files changed, 225 insertions(+)
create mode 100644 drivers/edac/cortex_arm64_l1_l2.c
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2021-01-07 10:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 10:38 Sascha Hauer [this message]
2021-01-07 10:38 ` [PATCH 1/1] drivers/edac: Add L1 and L2 error detection for A53 and A57 Sascha Hauer
2021-01-07 11:05 ` Marc Zyngier
2021-01-07 11:15 ` Mark Rutland
2021-01-07 12:36 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210107103819.13552-1-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rrichter@marvell.com \
--cc=tony.luck@intel.com \
--cc=york.sun@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox