From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 176A9C433DB for ; Thu, 7 Jan 2021 22:46:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE106235FA for ; Thu, 7 Jan 2021 22:46:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE106235FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P69nRI6Veqwg7yI7ERxCS/1gnEBt5KM2+4dcM4yIiC0=; b=ALkfO3X+1rI54yJDewMglAilG xfO/lVB34WEy+f+aqnP7O2fmdnEV4iD42mWAzwkA2rJtGHtMPl/eQOXo2pT1g+VRtI9G/5riMbhM3 DEp/ZLj+ZSYtbyvIxN72F5R2uoHsneB9ffNdEVL4gXsRQFXEFtqvBpi0VBLLf8GnltyMh+zeX1zKr S/hmx9VMwPIzSgqlxwo2JD0eopuv2/0tLeaYwWZWSMLJ9gS5hMPG4DbxwestRECSJHcywD4g2ewvL vWuZcyPkNdZZNjfeQhuiV1BtmThP5SOpk9azIfQuRA5XdPqPoanxgEvyyDXPVBNM1GuXaxjWw5B2i XK7SiXyog==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxe1Z-0002fA-7o; Thu, 07 Jan 2021 22:44:57 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxe1V-0002e2-TP for linux-arm-kernel@lists.infradead.org; Thu, 07 Jan 2021 22:44:55 +0000 Received: by mail-pj1-x1030.google.com with SMTP id b5so5028863pjk.2 for ; Thu, 07 Jan 2021 14:44:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Xy+0Wf/XBKC2krvhyfRiZMGzAb4maQJy3OQAnfkQkMU=; b=hsnk/TljudfgBTilsXRtE3DyqLWx19RlNt7pJrmtbueV5GV1Ol6lZqtMn79gZQFcdF qpR5VxBsznA9PSdPyzr/wSNR+UlPuM50yZ8aUWD2n2E44rmQ4CWAWM3sstdfpPziiHW+ zZNQGQGfiUJT5NvXsz4Z34VS2CH4a7sRvV2SZsvlhIi3bGZpe11E6TFpp4BP03jGkoJ1 aVOBqP8jCjtiVSIYZFTUpSu341pFEjG9/hyuyFQPa9DiJ3XgluQTek4f4583q9I/xewQ H1bDHgMpRnCU7RQibL8P/EBqv2lj5auT9LzNGuZuWLZ0DMTNM3ANJZ6Ba4d97aPvuCns v8Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Xy+0Wf/XBKC2krvhyfRiZMGzAb4maQJy3OQAnfkQkMU=; b=EU4+eT7X6Q79wMzeTq5fkTv8x9vylmoVQ4uWWJix+gXhGokUrrhsBNTBe3zE6+vKWa IK0YWhMMZ+iOJC7a1wf2+mPnVDoT6A8HgAXa5wPDdYU7gjAVpbL7XKEP7RhyiTtwedeq dCwXrwGt7MJn/BhcTa6QCtyjb8YiOejfV8F4ScEIT7sfoIpVlxmdx3Itv0kjUp/ugDiv lCoe5eF7DhHqVKki+2EHS14sau+Ji9PhczIRcL0u/UYq3H0lZ/VYADy/njZ+l2LLa6IL 4rnJr/m7m4EPo8K9oCAxzvCKEFJJUZ1cgg1u8I7q9dt7tjEJzYx1HP12KyN5Z49jEOYZ HQmw== X-Gm-Message-State: AOAM531HKubaBc2gz3Q0WcG44beINiYmSwD90elv7PswqWe9q+xP4CCN 3uE12840s/3XMYrAlmvrQMoT7A== X-Google-Smtp-Source: ABdhPJzAQ9RA9JKB0gtITGbuYddKSMfQtTts02BCc6DMDF0Q74OZgPLC/3M7ibTt9QMmJu8uU0l8Sg== X-Received: by 2002:a17:90a:8a8b:: with SMTP id x11mr685794pjn.54.1610059491904; Thu, 07 Jan 2021 14:44:51 -0800 (PST) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id x5sm5776179pjr.38.2021.01.07.14.44.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jan 2021 14:44:50 -0800 (PST) Date: Thu, 7 Jan 2021 15:44:48 -0700 From: Mathieu Poirier To: Suman Anna Subject: Re: [PATCH v2 0/5] Introduce PRU remoteproc consumer API Message-ID: <20210107224448.GB43045@xps15> References: <20201216165239.2744-1-grzegorz.jaszczyk@linaro.org> <20210106232704.GE9149@xps15> <11303a1b-5ab4-def5-77b1-c500894c9c87@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <11303a1b-5ab4-def5-77b1-c500894c9c87@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210107_174454_262803_054CE953 X-CRM114-Status: GOOD ( 29.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ohad@wizery.com, devicetree@vger.kernel.org, Grzegorz Jaszczyk , praneeth@ti.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, rogerq@kernel.org, robh+dt@kernel.org, ssantosh@kernel.org, linux-omap@vger.kernel.org, lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 06, 2021 at 06:03:25PM -0600, Suman Anna wrote: > Hi Mathieu, > > On 1/6/21 5:27 PM, Mathieu Poirier wrote: > > On Wed, Dec 16, 2020 at 05:52:34PM +0100, Grzegorz Jaszczyk wrote: > >> Hi All, > >> > >> The Programmable Real-Time Unit and Industrial Communication Subsystem > >> (PRU-ICSS or simply PRUSS) on various TI SoCs consists of dual 32-bit > >> RISC cores (Programmable Real-Time Units, or PRUs) for program execution. > >> > >> There are 3 foundation components for PRUSS subsystem: the PRUSS platform > >> driver, the PRUSS INTC driver and the PRUSS remoteproc driver. All were > >> already merged and can be found under: > >> 1) drivers/soc/ti/pruss.c > >> Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml > >> 2) drivers/irqchip/irq-pruss-intc.c > >> Documentation/devicetree/bindings/interrupt-controller/ti,pruss-intc.yaml > >> 3) drivers/remoteproc/pru_rproc.c > >> Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml > >> > >> The programmable nature of the PRUs provide flexibility to implement custom > >> peripheral interfaces, fast real-time responses, or specialized data handling. > >> Example of a PRU consumer drivers will be: > >> - Software UART over PRUSS > >> - PRU-ICSS Ethernet EMAC > >> > >> In order to make usage of common PRU resources and allow the consumer drivers to > >> configure the PRU hardware for specific usage the PRU API is introduced. > >> > >> Patch #3 of this series depends on one not merged remteproc related patch [1]. > >> > >> Please see the individual patches for exact changes in each patch, following is > >> the only change from v1: > >> - Change the 'prus' property name to 'ti,prus' as suggested by Rob Herring, > >> which influences patch #1 and patch #2 > >> > >> [1] https://patchwork.kernel.org/project/linux-remoteproc/patch/20201121030156.22857-3-s-anna@ti.com/ > >> > >> Best regards, > >> Grzegorz > >> > >> Roger Quadros (1): > >> remoteproc: pru: Add pru_rproc_set_ctable() function > >> > >> Suman Anna (2): > >> dt-bindings: remoteproc: Add PRU consumer bindings > >> remoteproc: pru: Deny rproc sysfs ops for PRU client driven boots > >> > >> Tero Kristo (2): > >> remoteproc: pru: Add APIs to get and put the PRU cores > >> remoteproc: pru: Configure firmware based on client setup > >> > >> .../bindings/remoteproc/ti,pru-consumer.yaml | 64 +++++ > >> drivers/remoteproc/pru_rproc.c | 221 +++++++++++++++++- > >> include/linux/pruss.h | 78 +++++++ > > > > This patchset is giving checkpatch.pl errors and as such will not go further > > with this revision. > > Yeah, I am aware of those. Greg has intentionally skipped the checkpatch > warnings around ENOTSUPP, based on some similar discussion on a different patch, > https://lkml.org/lkml/2020/11/10/764. I only see input from Andy and Lars in the thread you point out, nothing from Greg. I have also taken a look at the patch [1] that made checkpatch complain about ENOTSUPP. From what I see in that commit log the goal is to prevent new additions of ENOTSUPP to the kernel. Please modify and resend, otherwise I'm sure someone will send another patch to fix it before the end of the cycle. Thanks, Mathieu [1]. 6b9ea5ff5abd checkpatch: warn about uses of ENOTSUPP > > Let me know if you prefer that we change these to EOPNOTSUPP. > > regards > Suman > > > > >> 3 files changed, 360 insertions(+), 3 deletions(-) > >> create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml > >> create mode 100644 include/linux/pruss.h > >> > >> -- > >> 2.29.0 > >> > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel