From: Maxime Ripard <maxime@cerno.tech>
To: Sergio Sota <sergiosota@fanamoel.com>
Cc: devicetree@vger.kernel.org, jernej.skrabec@siol.net,
linux-kernel@vger.kernel.org, wens@csie.org, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: sun5i: add A10s/A13 display frontend support fallback
Date: Fri, 8 Jan 2021 10:22:48 +0100 [thread overview]
Message-ID: <20210108092248.c3pmjrextonnf33q@gilmour> (raw)
In-Reply-To: <20210107105927.2815198-1-sergiosota@fanamoel.com>
Hi,
On Thu, Jan 07, 2021 at 11:59:27AM +0100, Sergio Sota wrote:
> The A10s/A13 display frontend driver is not implemented
> Set A10 display frontend driver as a fallback for A10s/A13
> Tested with Olimex-A13-SOM / Olimex-A13-OlinuXino-MICRO
> "modetest -M sun4i-drm -s 49@47:800x480-60" ( 7.0" tft lcd)
> "modetest -M sun4i-drm -s 49@47:1024x600-60" (10.1" tft lcd)
>
> Signed-off-by: Sergio Sota <sergiosota@fanamoel.com>
> ---
You should mention the version number (using -v in git send-email or
format-patch), and add a changelog here
> arch/arm/boot/dts/sun5i.dtsi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sun5i.dtsi b/arch/arm/boot/dts/sun5i.dtsi
> index c2b4fbf552a3..4ef14a8695ef 100644
> --- a/arch/arm/boot/dts/sun5i.dtsi
> +++ b/arch/arm/boot/dts/sun5i.dtsi
> @@ -734,7 +734,8 @@ timer@1c60000 {
> };
>
> fe0: display-frontend@1e00000 {
> - compatible = "allwinner,sun5i-a13-display-frontend";
> + compatible = "allwinner,sun5i-a13-display-frontend",
> + "allwinner,sun4i-a10-display-frontend";
The comment on the first version still apply here, even more so with the
additional details you provided in the commit message
Maxime
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-01-08 9:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 10:59 [PATCH] ARM: dts: sun5i: add A10s/A13 display frontend support fallback Sergio Sota
2021-01-08 9:22 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210108092248.c3pmjrextonnf33q@gilmour \
--to=maxime@cerno.tech \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sergiosota@fanamoel.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox