From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2C9DC433E0 for ; Sun, 10 Jan 2021 17:05:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 321C422225 for ; Sun, 10 Jan 2021 17:05:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 321C422225 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sigxcpu.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QHfX8LrRzObMjOm2Y/mgNL9RJPv/fe50UjtbSuWynCc=; b=q8swDwYEPODlz2k1r6aBMtmVp 96twjR3X8nPUiacIDiipCeZ4SZ1AXAdVkGN7hOR2tzN9LEl5LYcJ4q3RrjqT1jDhMZ2l4dWQwGF8I 0ngtg1ZEaUlTQ+OWRJx4in+9hsaUBOTMSwkjjO45OnfFHQ3exNQ3yhisXZ4x0/SD9/7rIP6b9P/j6 OmZQU6OAMpOlmYMgPSizD8t0N43fPcqjXWdwPOjbimz5CG2P/GLovf9NR2A9Z0MPQgZV+NHjtxMQW 8DPHtx6tGhyFe3uMRlyjZ2XIP471Ut86ZKsD0rFrctS74L4EPkZoOelQyFvX+0JREvaViXiw9Df5m kPk3e7xsw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kye7m-0007TR-Hh; Sun, 10 Jan 2021 17:03:30 +0000 Received: from honk.sigxcpu.org ([24.134.29.49]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kye7g-0007RH-Kz for linux-arm-kernel@lists.infradead.org; Sun, 10 Jan 2021 17:03:27 +0000 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id 19E31FB03; Sun, 10 Jan 2021 18:03:23 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j46i6NiFsSWV; Sun, 10 Jan 2021 18:03:22 +0100 (CET) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id A9B3A40885; Sun, 10 Jan 2021 18:03:21 +0100 (CET) Date: Sun, 10 Jan 2021 18:03:21 +0100 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Shawn Guo Subject: Re: [PATCH] arm64: dts: imx8mq: Add clock parents for mipi dphy Message-ID: <20210110170321.GA30072@bogon.m.sigxcpu.org> References: <20210110124629.GO28365@dragon> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210110124629.GO28365@dragon> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210110_120326_573055_5CBFF70E X-CRM114-Status: GOOD ( 20.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dong Aisheng , devicetree@vger.kernel.org, Peng Fan , Philipp Zabel , Anson Huang , Sascha Hauer , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , Shengjiu Wang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Sun, Jan 10, 2021 at 08:46:29PM +0800, Shawn Guo wrote: > On Fri, Dec 18, 2020 at 06:50:05PM +0100, Guido G=FCnther wrote: > > This makes sure the clock tree setup for the dphy is not dependent on > > other components. > > = > > Without this change bringing up the display can fail like > > = > > kernel: phy phy-30a00300.dphy.2: Invalid CM/CN/CO values: 165/217/1 > > kernel: phy phy-30a00300.dphy.2: for hs_clk/ref_clk=3D451656000/59399= 9998 ~ 165/217 > > = > > if LCDIF doesn't set up that part of the clock tree first. This was > > noticed when testing the Librem 5 devkit with defconfig. It doesn't > > happen when modules are built in. > > = > > Signed-off-by: Guido G=FCnther > > --- > > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 11 ++++++++--- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > = > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boo= t/dts/freescale/imx8mq.dtsi > > index a841a023e8e0..ca0847e8f13c 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > @@ -1016,9 +1016,14 @@ dphy: dphy@30a00300 { > > reg =3D <0x30a00300 0x100>; > > clocks =3D <&clk IMX8MQ_CLK_DSI_PHY_REF>; > > clock-names =3D "phy_ref"; > > - assigned-clocks =3D <&clk IMX8MQ_CLK_DSI_PHY_REF>; > > - assigned-clock-parents =3D <&clk IMX8MQ_VIDEO_PLL1_OUT>; > > - assigned-clock-rates =3D <24000000>; > > + assigned-clocks =3D <&clk IMX8MQ_VIDEO_PLL1_REF_SEL>, > > + <&clk IMX8MQ_VIDEO_PLL1_BYPASS>, > > + <&clk IMX8MQ_CLK_DSI_PHY_REF>, > > + <&clk IMX8MQ_VIDEO_PLL1>; > = > You do not seem to set parent or rate on IMX8MQ_VIDEO_PLL1. Why do you > have it here? Good point. I've added a clock rate for IMX8MQ_VIDEO_PLL1 since then the clock tree reproduces exactly with and with the DSI host controller disabled in DT (otherwise we end up with a rate of 22MHz instead of 24Mhz). Cheers, -- Guido > = > Shawn > = > > + assigned-clock-parents =3D <&clk IMX8MQ_CLK_25M>, > > + <&clk IMX8MQ_VIDEO_PLL1>, > > + <&clk IMX8MQ_VIDEO_PLL1_OUT>; > > + assigned-clock-rates =3D <0>, <0>, <24000000>; > > #phy-cells =3D <0>; > > power-domains =3D <&pgc_mipi>; > > status =3D "disabled"; > > -- = > > 2.29.2 > > = > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel