From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: peng.fan@nxp.com
Cc: ohad@wizery.com, patrice.chotard@st.com, festevam@gmail.com,
s.hauer@pengutronix.de, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org,
paul@crapouillou.net, o.rempel@pengutronix.de, agross@kernel.org,
linux-imx@nxp.com, kernel@pengutronix.de, matthias.bgg@gmail.com,
shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V5 3/8] remoteproc: imx_rproc: correct err message
Date: Mon, 11 Jan 2021 13:35:25 -0700 [thread overview]
Message-ID: <20210111203525.GF144935@xps15> (raw)
In-Reply-To: <20201229033019.25899-4-peng.fan@nxp.com>
On Tue, Dec 29, 2020 at 11:30:14AM +0800, peng.fan@nxp.com wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> It is using devm_ioremap, so not devm_ioremap_resource. Correct
> the error message and print out sa/size.
>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> drivers/remoteproc/imx_rproc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index 6603e00bb6f4..2a093cea4997 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -268,7 +268,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
> priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev,
> att->sa, att->size);
> if (!priv->mem[b].cpu_addr) {
> - dev_err(dev, "devm_ioremap_resource failed\n");
> + dev_err(dev, "failed to remap %#x bytes from %#x\n", att->size, att->sa);
> return -ENOMEM;
> }
> priv->mem[b].sys_addr = att->sa;
> @@ -298,7 +298,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
>
> priv->mem[b].cpu_addr = devm_ioremap_resource(&pdev->dev, &res);
> if (IS_ERR(priv->mem[b].cpu_addr)) {
> - dev_err(dev, "devm_ioremap_resource failed\n");
> + dev_err(dev, "failed to remap %pr\n", &res);
> err = PTR_ERR(priv->mem[b].cpu_addr);
> return err;
> }
> --
> 2.28.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-11 20:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 3:30 [PATCH V5 0/8] remoteproc: imx_rproc: support iMX8MQ/M peng.fan
2020-12-29 3:30 ` [PATCH V5 1/8] remoteproc: introduce is_iomem to rproc_mem_entry peng.fan
2021-01-11 18:53 ` Mathieu Poirier
2020-12-29 3:30 ` [PATCH V5 2/8] remoteproc: add is_iomem to da_to_va peng.fan
2021-01-11 20:25 ` Mathieu Poirier
2020-12-29 3:30 ` [PATCH V5 3/8] remoteproc: imx_rproc: correct err message peng.fan
2021-01-11 20:35 ` Mathieu Poirier [this message]
2021-01-11 20:44 ` Mathieu Poirier
2020-12-29 3:30 ` [PATCH V5 4/8] remoteproc: imx_rproc: use devm_ioremap peng.fan
2021-01-11 20:46 ` Mathieu Poirier
2020-12-29 3:30 ` [PATCH V5 5/8] remoteproc: imx_rproc: add i.MX specific parse fw hook peng.fan
2020-12-29 3:30 ` [PATCH V5 6/8] remoteproc: imx_rproc: support i.MX8MQ/M peng.fan
2021-01-11 21:40 ` Mathieu Poirier
2020-12-29 3:30 ` [PATCH V5 7/8] remoteproc: imx_rproc: ignore mapping vdev regions peng.fan
2021-01-11 21:50 ` Mathieu Poirier
2021-01-12 9:41 ` Peng Fan
2021-01-12 18:46 ` Mathieu Poirier
2021-01-13 2:19 ` Peng Fan
2021-01-13 16:17 ` Mathieu Poirier
2021-01-14 9:52 ` Peng Fan
2021-01-14 17:10 ` Mathieu Poirier
2021-01-15 3:29 ` Peng Fan
2020-12-29 3:30 ` [PATCH V5 8/8] remoteproc: imx_proc: enable virtio/mailbox peng.fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210111203525.GF144935@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=o.rempel@pengutronix.de \
--cc=ohad@wizery.com \
--cc=patrice.chotard@st.com \
--cc=paul@crapouillou.net \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).