From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A860C433E0 for ; Mon, 11 Jan 2021 20:37:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95C6822CE3 for ; Mon, 11 Jan 2021 20:37:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95C6822CE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rL2wSii67/2sp8Ow4fPRW3wneXAMSimhl8Yq7JWHWW4=; b=fCSLwo9p5bVJ4/HCd3WXJ7K7K JYcBRd3aN3MrRpB0kZDq/Vi1JdGKW1+euEarmiGoSnV4hMPPq89vzt6KguuWVponM43wCSEz1vSTr eDnJ+r+4VvQD3naCEIvj29P+sTjQsD/eS0rewfMLC6WG+R0OE2+5FQsIS3S8EGW6eB1uYXNIXeRLn qrNqNU9DMioCkoK/jMK8ElJR9uSs72wSyXlH4blJFoDic/4ho5/1aprpyrIQyV+Osu4E17DyhcURx XkQA6k/Xky6xO+57CCC3dfzrWaYtSRzATtEbew9J5htWgSpj2tCFw0IHdIfFR72UaeOOPbOX1zvaB nVDsOb7mQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kz3uZ-0006b3-KX; Mon, 11 Jan 2021 20:35:35 +0000 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kz3uU-0006ZK-K8 for linux-arm-kernel@lists.infradead.org; Mon, 11 Jan 2021 20:35:31 +0000 Received: by mail-pg1-x536.google.com with SMTP id n25so441029pgb.0 for ; Mon, 11 Jan 2021 12:35:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=htaXQZSG0QXBfUKmA/4BqSl5HPobFjCxlJW4yk2E5ns=; b=yVqF7D9PXxJAUy23VKH2SpkjDpvitkAQ1NY3aYG76avArTGssg+rOGCA4fXn6QHxm0 1DvfF8tEu1vx7/KPfPvmcId0e5K2doyNffVelPnul5R8nIacp6+/JXhhSDFDz2w7uhDa mekTvarZZW9rLcOsiwEZY6Ec92/scs2ym/GaUG7LZDsM3klU6ip/+fsZ81mURynYbnfm 23WTHIQ3tEy7pRMiTGck3Iim+i1zRncYgtWcFlQ0u6m0/4NBffSa1ZKAeXKVsXiguDrm d5qG+oqQCiJNuLa58kKocYk2Ewo4zCMCfhXmnQTS5FIyVsD6fqy0VdrIm/FjYmyWEb6D Q5Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=htaXQZSG0QXBfUKmA/4BqSl5HPobFjCxlJW4yk2E5ns=; b=civ49frriSyiCYf0U87jr2JUe/MaRzro7sc1zrdvh7Rfs7u4tt+Or8uBaydUrFcLh1 Zx8P9JwDWad8yf0Ydaf4xqpskNBTSiBlAyqFl3YJK/aW0SHw7ZdY89JTMoMQZJYgPoS1 c+Dwqae6e4UG5ML81zoc/ZW/zZFgTIAH5CPQpW9g91kR8X6PtIRTEzrowzbmteITOkFc LSyQR6UzMLbLII6OmCvcn/PQaVb75R1jODAMib9P4ynumqjtqWC65tVGSlzocnHWyhCo kpX5RYwV4hqDIluHKWpU4qyTNPbPmJu6viUNPK0yTis2Bhsd70YoGAnBHqSLTYlh0y+l AgvQ== X-Gm-Message-State: AOAM530a4vdwghvwgTuA3JN4+EIxjijPm0LB7ja1iMCnsNd+4UxcU69M +8FkkGYDyEPtSfnlenkr5/WksA== X-Google-Smtp-Source: ABdhPJyDzUPDWrOXZop7ttJxWaDIJwqu/yOCE8pdt99yLt+u0R1+06rNosUhfC7KvCFTWf1cDG7Dcw== X-Received: by 2002:a63:4746:: with SMTP id w6mr1201346pgk.377.1610397328503; Mon, 11 Jan 2021 12:35:28 -0800 (PST) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id b10sm611038pgh.15.2021.01.11.12.35.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 12:35:27 -0800 (PST) Date: Mon, 11 Jan 2021 13:35:25 -0700 From: Mathieu Poirier To: peng.fan@nxp.com Subject: Re: [PATCH V5 3/8] remoteproc: imx_rproc: correct err message Message-ID: <20210111203525.GF144935@xps15> References: <20201229033019.25899-1-peng.fan@nxp.com> <20201229033019.25899-4-peng.fan@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201229033019.25899-4-peng.fan@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210111_153530_841407_AFA5A416 X-CRM114-Status: GOOD ( 17.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ohad@wizery.com, patrice.chotard@st.com, festevam@gmail.com, s.hauer@pengutronix.de, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, paul@crapouillou.net, o.rempel@pengutronix.de, agross@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, matthias.bgg@gmail.com, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 29, 2020 at 11:30:14AM +0800, peng.fan@nxp.com wrote: > From: Peng Fan > > It is using devm_ioremap, so not devm_ioremap_resource. Correct > the error message and print out sa/size. > > Reviewed-by: Bjorn Andersson > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Mathieu Poirier > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 6603e00bb6f4..2a093cea4997 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -268,7 +268,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, > att->sa, att->size); > if (!priv->mem[b].cpu_addr) { > - dev_err(dev, "devm_ioremap_resource failed\n"); > + dev_err(dev, "failed to remap %#x bytes from %#x\n", att->size, att->sa); > return -ENOMEM; > } > priv->mem[b].sys_addr = att->sa; > @@ -298,7 +298,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > > priv->mem[b].cpu_addr = devm_ioremap_resource(&pdev->dev, &res); > if (IS_ERR(priv->mem[b].cpu_addr)) { > - dev_err(dev, "devm_ioremap_resource failed\n"); > + dev_err(dev, "failed to remap %pr\n", &res); > err = PTR_ERR(priv->mem[b].cpu_addr); > return err; > } > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel