From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 875CEC433E0 for ; Mon, 11 Jan 2021 20:46:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19598222B6 for ; Mon, 11 Jan 2021 20:46:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19598222B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rL2wSii67/2sp8Ow4fPRW3wneXAMSimhl8Yq7JWHWW4=; b=vyFGw5evO8lKiy3fiVnlMsmLs lPgmjRbaE0Mzdg1E3J7w8TcqANfgx9hdmNZ85JZOntJDTMe+rTY4u4QZ3PtQVqM6rMzN4RoMQ/ts2 rSVFPnAsyELrTlbUWQ1RFhFQm6+q69036gLXr++B8TPDIYC5TpEWar3pAEGZJOIqTSPa1Qso1wQvv VrxOuoPBZgmnaowWdg25jVOXt/Fb/Tfm3MDcNX/vwwK7JseXwMx2N5kn6LhxiwtM72W0NNt1vKIut ShfdcnibyFlJg93oN0MOAYF/+AtsyT2gv7ORa0E/RH7mQSEz/8HXnp27tBBrGCJYbGv8/QQ5nA2YR LBlicBlOA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kz43Z-0000pe-IF; Mon, 11 Jan 2021 20:44:53 +0000 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kz43V-0000oM-BU for linux-arm-kernel@lists.infradead.org; Mon, 11 Jan 2021 20:44:50 +0000 Received: by mail-pg1-x535.google.com with SMTP id n25so456374pgb.0 for ; Mon, 11 Jan 2021 12:44:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=htaXQZSG0QXBfUKmA/4BqSl5HPobFjCxlJW4yk2E5ns=; b=O3N5mg9bdze7Ib2ynKPcRncsWq4DeRqKXai+5tqZT6vC3AXXoCwYrSPHkNTvmet9Iq 1WFZ43d9O+L1KRgshF4eGm2hf5cpBZgHk7qGEIfG/CXt6BCo+vY6EwTxjCAN+FvqYfuM Sxp4IgTW+sJ7kjHDfPTk1AJ8WAg8K1bh0WZkmIHkjYnaWIx6i0aSbmEvZlupHGjFkpJm RftTtJJYX1EA4PPw4yim0yhw/Wo4oNe/NSLtFNGDz+g/MGPLPdKfNObrl0XGK1AqP0TS ZqKkdtAbmfw58yoMaAVNb0e2H3/eMRig8foXXdm4A1TSiwbm5Q+ZY7DYBu0rGAdVzXUN zNAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=htaXQZSG0QXBfUKmA/4BqSl5HPobFjCxlJW4yk2E5ns=; b=EFcN/RQU5+ymRqhKmx153+N8lEh7RZKoLV6nD0TeI8QAABxLPNIjV+AX+evI/aOx7A d1wROmKO+lROYcOFRcWKGLY7wri8n1eubXCrMpEG/8te1R8yTEFRfETApqnmwR+xx7/c wSJQgFhEfV76JJK1qV7NMzc8oSjvQUMAvLHueIPJbj67MAVF/LGtt5CmRczEW9ifO3fk SfTw8S0FUO5E5jc0vLfhCHYuQ3Si/I8GQCZiSsnsZ8KYof8iH6AXJ8N5o0aK1TqEVJ4Y TxtJQS4dm3kYxCYXO6VN14mnVbqpOhbXvc/lpzb+2l6ThNEl81g5pMEsbJ6exgfhuYb5 YsLw== X-Gm-Message-State: AOAM532ZbWLfLUEmX6hNx13Bv2AqDWaSfX1G1gn13zf1gyAhEJegWYYw Vx3n+jlzKT56DWyj8hHjUjhc2A== X-Google-Smtp-Source: ABdhPJzKPAhhrZdX5YzDSRv6fxW723f9nT86WDJoB9QWXDuU2iIS1gUxmnqTlT9GlzyBHBi4S76Dtg== X-Received: by 2002:a62:c312:0:b029:1a9:19c7:a8e with SMTP id v18-20020a62c3120000b02901a919c70a8emr1143762pfg.74.1610397886774; Mon, 11 Jan 2021 12:44:46 -0800 (PST) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id b13sm499319pfi.162.2021.01.11.12.44.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 12:44:46 -0800 (PST) Date: Mon, 11 Jan 2021 13:44:44 -0700 From: Mathieu Poirier To: peng.fan@nxp.com Subject: Re: [PATCH V5 3/8] remoteproc: imx_rproc: correct err message Message-ID: <20210111204444.GG144935@xps15> References: <20201229033019.25899-1-peng.fan@nxp.com> <20201229033019.25899-4-peng.fan@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201229033019.25899-4-peng.fan@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210111_154449_606702_517E60E7 X-CRM114-Status: GOOD ( 17.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ohad@wizery.com, patrice.chotard@st.com, festevam@gmail.com, s.hauer@pengutronix.de, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, paul@crapouillou.net, o.rempel@pengutronix.de, agross@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, matthias.bgg@gmail.com, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 29, 2020 at 11:30:14AM +0800, peng.fan@nxp.com wrote: > From: Peng Fan > > It is using devm_ioremap, so not devm_ioremap_resource. Correct > the error message and print out sa/size. > > Reviewed-by: Bjorn Andersson > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Mathieu Poirier > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 6603e00bb6f4..2a093cea4997 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -268,7 +268,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, > att->sa, att->size); > if (!priv->mem[b].cpu_addr) { > - dev_err(dev, "devm_ioremap_resource failed\n"); > + dev_err(dev, "failed to remap %#x bytes from %#x\n", att->size, att->sa); > return -ENOMEM; > } > priv->mem[b].sys_addr = att->sa; > @@ -298,7 +298,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > > priv->mem[b].cpu_addr = devm_ioremap_resource(&pdev->dev, &res); > if (IS_ERR(priv->mem[b].cpu_addr)) { > - dev_err(dev, "devm_ioremap_resource failed\n"); > + dev_err(dev, "failed to remap %pr\n", &res); > err = PTR_ERR(priv->mem[b].cpu_addr); > return err; > } > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel