From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9721CC433DB for ; Mon, 11 Jan 2021 20:48:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 333E122A83 for ; Mon, 11 Jan 2021 20:48:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 333E122A83 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6j2BrrV6tarqb7c9Z8/cFMJXzAwG7AG3QxnPmHwexqc=; b=d6KRNQJS215gAz8jRPJStxTCK sXNzqukua4WRnppRSaVdh8eSs+X9hu7CAxjCyNlKIl16Tpiwnk2+zE42lqZFRlbT4ga8UB8kGAqq+ 7BlrZYjzp+MJt6s4LlU+VOAYooyyVp/sbPLAyte1/+vykq7lqg+btWOayykHH9Q+kEr8XapNbZOWf Jy4NSf3WRgkQtnqP38MR2TJ6aXCPBpx9bQvoaxMd7S6uP7uO8Br4brBS7fG+hDx6hQYW2RhiLxYBx F50v/fQm/YFTRO0sE38DSd0P9QBxrMSpiA8w9LMMi9OgJV8ej4Axl5XgrMCzlK57VKkgddEUbPAfF cnmNfV9uw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kz45j-0001YZ-Nd; Mon, 11 Jan 2021 20:47:07 +0000 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kz45g-0001XC-O5 for linux-arm-kernel@lists.infradead.org; Mon, 11 Jan 2021 20:47:05 +0000 Received: by mail-pf1-x42e.google.com with SMTP id w2so645490pfc.13 for ; Mon, 11 Jan 2021 12:47:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0850ujLUfr+Sd4YSpOl+ae9e9f2P4z33sSNVJYhmzJ4=; b=VPDJpyC63ZR2U+NpeH3KcOwIOYJ2F1z9dCldBbuMpQqwMqrwLpmInTFrlmFR/qfKIX bLx6JtkmwibrAJbjDHssAuKqjihgT3I/GsuoRhQ4L5RcP5lw7LyXi+svMTHJYjaJIPLh AAx+c2X5JjcUAc0T2U5H7N9qcb6v6foWerrgnQytDaBpWLo7guAPm/l0dk0YJxGHjrek YzCs01T6eDZ7Hrs+yyvin+j14rLd7vTU24o0IjueKeigmfSL9jrLD0jRuTn/G7QbRf78 niRYqXmDAHyxes61Y0QY26rz2b9TDuknHXYzvORNzfkpGXYnTGqLueu5Pq8Xai7ODrTF e+9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0850ujLUfr+Sd4YSpOl+ae9e9f2P4z33sSNVJYhmzJ4=; b=DV7aApAmF0dAYWkDipGnYLOI0Brz7j2+D3f69SSbJhNURNTtfrgaK6v8rinem4PsBY 40Yd9cnMTNFnNwYx4DqcqO7aRdPsmbDDY5Lx/4HTwXnhwxcbAP8VAe0/s93GHHUfueci fIJUFmfyP+LLoK2e/xapyABH2cvJbH8YTFyKYznBBv5Akjy8J8Kv/AF4Uq8qzN45ANCI PenZBbVb6N2wOi8QK5EZtCgT3TOiqe1JrffGFMO55ekMN+IWfsw5WXyxbjAlJ6cbEpjQ hZZ08tlsmJ2rF4BY2zhLD/WL4lPPhrPfq6QQgno6F65BN2xlifatXiYpDJW51znqkAZt 8n6A== X-Gm-Message-State: AOAM530dGockltrSRkjUUl8a8uKohAzTbfH+DX6tIdHXpJTKI8YSKzB+ 4EBF83CjvkipbwtZb1Al6/SLOA== X-Google-Smtp-Source: ABdhPJzuh+bFsDFldPJKqcfzJx+5Ttv5Iz7raUusESoXKN0qXz4dFPkLC91Sn+XQ7UTdODzVkn0p9Q== X-Received: by 2002:a65:4983:: with SMTP id r3mr1326949pgs.288.1610398022258; Mon, 11 Jan 2021 12:47:02 -0800 (PST) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id mw15sm259868pjb.34.2021.01.11.12.47.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 12:47:01 -0800 (PST) Date: Mon, 11 Jan 2021 13:46:59 -0700 From: Mathieu Poirier To: peng.fan@nxp.com Subject: Re: [PATCH V5 4/8] remoteproc: imx_rproc: use devm_ioremap Message-ID: <20210111204659.GH144935@xps15> References: <20201229033019.25899-1-peng.fan@nxp.com> <20201229033019.25899-5-peng.fan@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201229033019.25899-5-peng.fan@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210111_154704_799036_607E0D1C X-CRM114-Status: GOOD ( 17.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ohad@wizery.com, Richard Zhu , patrice.chotard@st.com, festevam@gmail.com, s.hauer@pengutronix.de, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, paul@crapouillou.net, o.rempel@pengutronix.de, agross@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, matthias.bgg@gmail.com, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 29, 2020 at 11:30:15AM +0800, peng.fan@nxp.com wrote: > From: Peng Fan > > We might need to map an region multiple times, becaue the region might > be shared between remote processors, such i.MX8QM with dual M4 cores. > So use devm_ioremap, not devm_ioremap_resource. > > Reviewed-by: Oleksij Rempel > Reviewed-by: Richard Zhu > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Mathieu Poirier > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 2a093cea4997..47fc1d06be6a 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -296,7 +296,8 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > if (b >= IMX7D_RPROC_MEM_MAX) > break; > > - priv->mem[b].cpu_addr = devm_ioremap_resource(&pdev->dev, &res); > + /* Not use resource version, because we might share region */ > + priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, res.start, resource_size(&res)); > if (IS_ERR(priv->mem[b].cpu_addr)) { > dev_err(dev, "failed to remap %pr\n", &res); > err = PTR_ERR(priv->mem[b].cpu_addr); > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel