From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F0B6C433DB for ; Mon, 11 Jan 2021 21:42:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B6D622AED for ; Mon, 11 Jan 2021 21:42:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B6D622AED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XXdjXbSmauYzF64lw8G/CZaJdF76zKpapgMR/ALbI50=; b=uZIeMfdZN2qO3cn/ObdBA/PCv rfCS5cPkw0w02W1q2tNrRz7ZQW6guPfwv0kPSFKwktEB3Yl9WCc5i1e2h4TtdINo8Ubz4W47VQCLg VINSBTWr474yL2Lwz/j8ePOEDqnzvJpI9F5rUx4ZPJ5RpBcj2/ksBjiqPCELIG+FJ1spkeJ0cplbq eJqwH87Nykbg0ejoDOidOneNNvtF/f4ahYbgPUrVvsy6m/8VY67Z0R1R+bqm6m/NEEi9C2A+szvj9 wo1O1eJU9VLqovLwNN3zs7N99ZM2uJtG4MrBU536xHBBaXvEM6Pt2Tj2yCtY4aOWGOe0rnrrftfSB FmzDgUmew==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kz4vM-0008Ui-IB; Mon, 11 Jan 2021 21:40:28 +0000 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kz4vG-0008SU-W8 for linux-arm-kernel@lists.infradead.org; Mon, 11 Jan 2021 21:40:25 +0000 Received: by mail-pf1-x435.google.com with SMTP id d2so79534pfq.5 for ; Mon, 11 Jan 2021 13:40:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YAZpy6BnklcTFR4y2uqR/HOMIneLtln1qkeJb17jmmI=; b=Sktn3WigfNxAfBk5bHXDlcDF/Q3JQf3REoXsi5zkmHrLxgBCkxkvFekowTmcZf20xA ZjpP9QSCJdn8xdfiiV6lNL2iFf/rQEXXRzcrS+AUV4NNvE/OMpwA/y3jo930vK3ehrpo Any5usxFUGmR35kGgsD2VVE8b8LE/TSNM8BZnMNgJPJr0NuDJ3nfOBZALah/ecvPvTey dSrxNZKQPjt0F+cyL9MlIO84Iqt7x813X6NcEoxjHRJqeTbluiCJechAKCuff0Fi4taR bBIVegJuvS2eZlBitYJGWJhe6z/nX4TTAKHq6vvKztvXUHtXcW+Bpi5XyVybBn9T2SlQ 3MRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YAZpy6BnklcTFR4y2uqR/HOMIneLtln1qkeJb17jmmI=; b=DddjI8uetFhj2TkdaoOUUiEglHzJGiTK1S3+47rkba4FbRRSNsFyCH9ya9uO9qs6kj L2mDDf2OozfFRYyMZ7rraBPqEk633+ZbRpGhJjI6C4lSlhHfke01V+jOnbD09Lwn6+Db 0yl2KmgPmXx+iL3oPuVcDg4xaBj2ErhWKmddxu6B0JONel+X8AVe4Ce6c8QiZ5S/DzDl UlxQLzvASGFykI3EI+c4P87/5Rc8uG2fvU9aRdXn3Wz6mv0HbekId4lAo2cgWi2jXwbl hWgcriNybEwZAdhuq8og6M6nE8Sa9GpusKlXez4zRw28eLqR8Ufev0BDGrwfhAalWjV6 qIhQ== X-Gm-Message-State: AOAM5306KBVcsN6Ny+RWWKLuMUQ2q+8Y57vxAaKc3bX/i1pgArVM6ElE kEc8wFvRMsrC82orJuNNNvfrWg== X-Google-Smtp-Source: ABdhPJxUmdX9ILSl+pQlfGD6TgGmxFtU5TAEjlgyDaHxYjNhn5lWIdtwZnfLRlEnWWaHluaMywZ2ag== X-Received: by 2002:a63:5d7:: with SMTP id 206mr1481880pgf.384.1610401219258; Mon, 11 Jan 2021 13:40:19 -0800 (PST) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id 36sm669534pgr.56.2021.01.11.13.40.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 13:40:18 -0800 (PST) Date: Mon, 11 Jan 2021 14:40:16 -0700 From: Mathieu Poirier To: peng.fan@nxp.com Subject: Re: [PATCH V5 6/8] remoteproc: imx_rproc: support i.MX8MQ/M Message-ID: <20210111214016.GI144935@xps15> References: <20201229033019.25899-1-peng.fan@nxp.com> <20201229033019.25899-7-peng.fan@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201229033019.25899-7-peng.fan@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210111_164024_815611_3CE605C1 X-CRM114-Status: GOOD ( 20.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ohad@wizery.com, Richard Zhu , patrice.chotard@st.com, festevam@gmail.com, s.hauer@pengutronix.de, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, paul@crapouillou.net, o.rempel@pengutronix.de, agross@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, matthias.bgg@gmail.com, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 29, 2020 at 11:30:17AM +0800, peng.fan@nxp.com wrote: > From: Peng Fan > > Add i.MX8MQ dev/sys addr map and configuration data structure > i.MX8MM share i.MX8MQ settings. > > Reviewed-by: Richard Zhu > Signed-off-by: Peng Fan > Reviewed-by: Mathieu Poirier > --- > drivers/remoteproc/imx_rproc.c | 39 ++++++++++++++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 3c0075dc1787..f80428afb8a7 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -88,6 +88,34 @@ struct imx_rproc { > struct clk *clk; > }; > > +static const struct imx_rproc_att imx_rproc_att_imx8mq[] = { > + /* dev addr , sys addr , size , flags */ > + /* TCML - alias */ > + { 0x00000000, 0x007e0000, 0x00020000, 0 }, > + /* OCRAM_S */ > + { 0x00180000, 0x00180000, 0x00008000, 0 }, > + /* OCRAM */ > + { 0x00900000, 0x00900000, 0x00020000, 0 }, > + /* OCRAM */ > + { 0x00920000, 0x00920000, 0x00020000, 0 }, > + /* QSPI Code - alias */ > + { 0x08000000, 0x08000000, 0x08000000, 0 }, > + /* DDR (Code) - alias */ > + { 0x10000000, 0x80000000, 0x0FFE0000, 0 }, > + /* TCML */ > + { 0x1FFE0000, 0x007E0000, 0x00020000, ATT_OWN }, > + /* TCMU */ > + { 0x20000000, 0x00800000, 0x00020000, ATT_OWN }, > + /* OCRAM_S */ > + { 0x20180000, 0x00180000, 0x00008000, ATT_OWN }, > + /* OCRAM */ > + { 0x20200000, 0x00900000, 0x00020000, ATT_OWN }, > + /* OCRAM */ > + { 0x20220000, 0x00920000, 0x00020000, ATT_OWN }, > + /* DDR (Data) */ > + { 0x40000000, 0x40000000, 0x80000000, 0 }, > +}; > + > static const struct imx_rproc_att imx_rproc_att_imx7d[] = { > /* dev addr , sys addr , size , flags */ > /* OCRAM_S (M4 Boot code) - alias */ > @@ -138,6 +166,15 @@ static const struct imx_rproc_att imx_rproc_att_imx6sx[] = { > { 0x80000000, 0x80000000, 0x60000000, 0 }, > }; > > +static const struct imx_rproc_dcfg imx_rproc_cfg_imx8mq = { > + .src_reg = IMX7D_SRC_SCR, > + .src_mask = IMX7D_M4_RST_MASK, > + .src_start = IMX7D_M4_START, > + .src_stop = IMX7D_M4_STOP, > + .att = imx_rproc_att_imx8mq, > + .att_size = ARRAY_SIZE(imx_rproc_att_imx8mq), > +}; > + > static const struct imx_rproc_dcfg imx_rproc_cfg_imx7d = { > .src_reg = IMX7D_SRC_SCR, > .src_mask = IMX7D_M4_RST_MASK, > @@ -496,6 +533,8 @@ static int imx_rproc_remove(struct platform_device *pdev) > static const struct of_device_id imx_rproc_of_match[] = { > { .compatible = "fsl,imx7d-cm4", .data = &imx_rproc_cfg_imx7d }, > { .compatible = "fsl,imx6sx-cm4", .data = &imx_rproc_cfg_imx6sx }, > + { .compatible = "fsl,imx8mq-cm4", .data = &imx_rproc_cfg_imx8mq }, > + { .compatible = "fsl,imx8mm-cm4", .data = &imx_rproc_cfg_imx8mq }, I don't see a patch that adds those to the imx-rproc.txt bindings document. As far as I can tell the patch that does that was part of your first patchset [1] but was not resubmitted after that. It would be very nice to have an example of how the DT is laid out for those 2 platform, otherwise I have to guess based on the code I am reviewing. [1]. https://patchwork.kernel.org/project/linux-remoteproc/patch/20200724080813.24884-2-peng.fan@nxp.com/ > {}, > }; > MODULE_DEVICE_TABLE(of, imx_rproc_of_match); > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel