From: Rob Herring <robh@kernel.org>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: devicetree@vger.kernel.org, Nadeem Athani <nadeem@cadence.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Tom Joseph <tjoseph@cadence.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/4] dt-bindings: pci: ti,j721e: Add host mode dt-bindings for TI's AM64 SoC
Date: Mon, 11 Jan 2021 16:37:50 -0600 [thread overview]
Message-ID: <20210111223750.GA3177728@robh.at.kernel.org> (raw)
In-Reply-To: <20210104124103.30930-3-kishon@ti.com>
On Mon, Jan 04, 2021 at 06:11:01PM +0530, Kishon Vijay Abraham I wrote:
> Add host mode dt-bindings for TI's AM64 SoC. This is the same IP used in
> J7200, however AM64 is a non-coherent architecture.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> .../devicetree/bindings/pci/ti,j721e-pci-host.yaml | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> index 7607018a115b..77118dba415e 100644
> --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> @@ -16,12 +16,17 @@ allOf:
> properties:
> compatible:
> oneOf:
> - - description: PCIe controller in J7200
> + - const: ti,am64-pcie-host
No, either you have fallback or you don't.
> + - const: ti,j7200-pcie-host
> + - const: ti,j721e-pcie-host
> + - description: PCIe controller in AM64
> items:
> + - const: ti,am64-pcie-host
> - const: ti,j7200-pcie-host
> - const: ti,j721e-pcie-host
2 fallbacks is probably not too useful. Do those really enable
anything?
> - - description: PCIe controller in J721E
> + - description: PCIe controller in J7200
> items:
> + - const: ti,j7200-pcie-host
> - const: ti,j721e-pcie-host
>
> reg:
> @@ -87,7 +92,6 @@ required:
> - vendor-id
> - device-id
> - msi-map
> - - dma-coherent
> - dma-ranges
> - ranges
> - reset-gpios
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-11 22:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 12:40 [PATCH v2 0/4] AM64: Add PCIe bindings and driver support Kishon Vijay Abraham I
2021-01-04 12:41 ` [PATCH v2 1/4] dt-bindings: PCI: ti, j721e: Add binding to represent refclk to the connector Kishon Vijay Abraham I
2021-01-11 22:31 ` [PATCH v2 1/4] dt-bindings: PCI: ti,j721e: " Rob Herring
2021-01-04 12:41 ` [PATCH v2 2/4] dt-bindings: pci: ti, j721e: Add host mode dt-bindings for TI's AM64 SoC Kishon Vijay Abraham I
2021-01-11 22:37 ` Rob Herring [this message]
2021-01-04 12:41 ` [PATCH v2 3/4] dt-bindings: pci: ti, j721e: Add endpoint " Kishon Vijay Abraham I
2021-01-04 12:41 ` [PATCH v2 4/4] PCI: j721e: Add support to provide refclk to PCIe connector Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210111223750.GA3177728@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=nadeem@cadence.com \
--cc=tjoseph@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).