From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F23DC433E6 for ; Tue, 12 Jan 2021 10:25:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD3E023109 for ; Tue, 12 Jan 2021 10:25:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD3E023109 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xLqaBaEgFdOCLBunAxoBOOyUGhaPA6BGYkKzIRs1lCY=; b=le8DEECWlUp1L5NDueiEz1lKD Fi1UE9eE/U2Hjr13C3ob/DZweDXdIdN/PDqJjjtE6FnzoLdGRu2nWrMwmJiZ9XXOpHkq72H3zq2xb kMltZZoTZyYzEF3UYu2e3lbelMuC0kVmGoMIc+C7hjuDnAp3JqhFDOSuS016bUTQCY3MbAxJ/MNDx wpIhg4AqKc8g2be/fsT6KdFQfIxniR/7CSfOKCmP4jwohfDCmuErNbWh5kNd9ulb8ihoE3NCGxSda Wldj8LBk7hDvKfYH2ANp+poksbzSVxV8BQMxM4EdtLd1e66vtgJGDIF8vto9NTgFXZWnR8s+gw5Rh lJIdqgL3A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzGpi-0002dH-N1; Tue, 12 Jan 2021 10:23:26 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzGpc-0002bJ-7B for linux-arm-kernel@lists.infradead.org; Tue, 12 Jan 2021 10:23:21 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 28AF231B; Tue, 12 Jan 2021 02:23:18 -0800 (PST) Received: from C02TD0UTHF1T.local (unknown [10.57.57.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EFF373F719; Tue, 12 Jan 2021 02:23:14 -0800 (PST) Date: Tue, 12 Jan 2021 10:23:12 +0000 From: Mark Rutland To: Peter Zijlstra Subject: Re: [PATCH] arm64: make atomic helpers __always_inline Message-ID: <20210112102312.GC34326@C02TD0UTHF1T.local> References: <20210108092024.4034860-1-arnd@kernel.org> <20210108093258.GB4031@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210112_052320_397331_A58D9FE8 X-CRM114-Status: GOOD ( 22.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Arnd Bergmann , Herbert Xu , Arnd Bergmann , Catalin Marinas , Boqun Feng , Nick Desaulniers , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Nathan Chancellor , Will Deacon , Thomas Gleixner , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 08, 2021 at 09:39:53PM +0100, Peter Zijlstra wrote: > On Fri, Jan 08, 2021 at 09:32:58AM +0000, Will Deacon wrote: > > Hi Arnd, > > > > On Fri, Jan 08, 2021 at 10:19:56AM +0100, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > With UBSAN enabled and building with clang, there are occasionally > > > warnings like > > > > > > WARNING: modpost: vmlinux.o(.text+0xc533ec): Section mismatch in reference from the function arch_atomic64_or() to the variable .init.data:numa_nodes_parsed > > > The function arch_atomic64_or() references > > > the variable __initdata numa_nodes_parsed. > > > This is often because arch_atomic64_or lacks a __initdata > > > annotation or the annotation of numa_nodes_parsed is wrong. > > > > > > for functions that end up not being inlined as intended but operating > > > on __initdata variables. Mark these as __always_inline, along with > > > the corresponding asm-generic wrappers. > > > > Hmm, I don't fully grok this. Why does it matter if a non '__init' function > > is called with a pointer to some '__initdata'? Or is the reference coming > > from somewhere else? (where?). > > FWIW the x86 atomics are __always_inline in part due to the noinstr > crud, which I imagine resulted in much the same 'fun'. FWIW, I was planning on doing the same here as part of making arm64 noinstr safe, so I reckon we should probably do this regardless of whether it's a complete fix for the section mismatch issue. Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel