From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C2CBC433E0 for ; Tue, 12 Jan 2021 12:33:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1605B22BE9 for ; Tue, 12 Jan 2021 12:33:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1605B22BE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=q22PbyPvy1ICr+LN8CW1KxeM6DsARJ3hlTWsTbHQ14A=; b=yIYLMrLPvBsidTR9aFmduSp6M ZRnRWtWU5R7mNXny4d4BSKrjvI7ChPS4bP22BnEBc2HrHuzSwp5lCUrSUWwJ6Vijtm/qy8BxqYoQE 9Eo20MsKgPHqFdj9oYgZS67NmalmnwOErJLr2sbr1ilUHaKplPARAyNknGTAKkFENdCxaeKhVK79u quEdXjcExljiV8rB4Hl9bd3NjkFx7Lj+nQ0yqB7QfLtww4sA77W1wgIPFLcar5v2UZZGREFvcky2k rKUzu62R0ywPDOG+J8CxiHHsY5Ao4ebhkX0XX90Z7cfDhI/DcL3D4GoV5PoP7wRJOHiIrJ6wckwpl z/n8zSOPA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzIpk-0001NP-EJ; Tue, 12 Jan 2021 12:31:36 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzIph-0001M5-8y for linux-arm-kernel@lists.infradead.org; Tue, 12 Jan 2021 12:31:34 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id CCD3F23109; Tue, 12 Jan 2021 12:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610454692; bh=BtD61F+RAP3Yv3WfEUjwIDVe48zMPhJpisO2OtiId90=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YuPDxeFiitS2kKFvGgE7iRl8XKs6QeHdTqOebZfJb3wfW499VmSKT6o9Dj7IBeqar WlQEUHtRvVEneCm9zePEkO68iG1Af0Usb6+Rur53obIYiKSjQSzZCiyShkEVceJsOT kKTkqN1OQOP4HOpWdb8UUbKWrxU3czq7+ELhQKEHPfAupzrxNjZOrOPcCewGJIGRjP 6vv6THKmCTCribmRuxfig4kmtbCEetXeHP7LYGSwdTH3BiqbIQ/SD5O++GEfMasbfz iAvU5K738yBEu/LH6ehrjG4QyuMxaB1iCDoeY/jLlewp2Cr34NBbf4aDnWwePzoN/0 s08pGBtLQGBXw== Date: Tue, 12 Jan 2021 18:01:27 +0530 From: Vinod Koul To: Christophe JAILLET Subject: Re: [PATCH] dmaengine: owl-dma: Fix a resource leak in the remove function Message-ID: <20210112123127.GT2771@vkoul-mobl> References: <20201212162535.95727-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201212162535.95727-1-christophe.jaillet@wanadoo.fr> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210112_073133_912281_223C3DFC X-CRM114-Status: UNSURE ( 9.01 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, manivannan.sadhasivam@linaro.org, dmaengine@vger.kernel.org, dan.j.williams@intel.com, afaerber@suse.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12-12-20, 17:25, Christophe JAILLET wrote: > A 'dma_pool_destroy()' call is missing in the remove function. > Add it. > > This call is already made in the error handling path of the probe function. Applied, thanks -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel