* [PATCH 0/2] arm64: small updates to rebooting
@ 2020-12-19 14:36 Wolfram Sang
2020-12-19 14:36 ` [PATCH 1/2] arm64: add grace period when rebooting Wolfram Sang
2020-12-19 14:36 ` [PATCH 2/2] arm64: proper comment formatting in reboot handler Wolfram Sang
0 siblings, 2 replies; 6+ messages in thread
From: Wolfram Sang @ 2020-12-19 14:36 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: linux-renesas-soc, linux-kernel
Found these while working with a new prototype board.
Wolfram Sang (2):
arm64: add grace period when rebooting
arm64: proper comment formatting in reboot handler
arch/arm64/kernel/process.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
--
2.29.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] arm64: add grace period when rebooting
2020-12-19 14:36 [PATCH 0/2] arm64: small updates to rebooting Wolfram Sang
@ 2020-12-19 14:36 ` Wolfram Sang
2021-01-12 13:55 ` Will Deacon
2020-12-19 14:36 ` [PATCH 2/2] arm64: proper comment formatting in reboot handler Wolfram Sang
1 sibling, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2020-12-19 14:36 UTC (permalink / raw)
To: linux-arm-kernel
Cc: linux-renesas-soc, Wolfram Sang, Will Deacon, linux-kernel,
Catalin Marinas
I work on a system where I currently need to reboot via watchdog.
Because the watchdog needs a bit of time to fire, add a grace period
like on arm32 to avoid the false positive warning message.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
arch/arm64/kernel/process.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c
index 6616486a58fe..3c770329364f 100644
--- a/arch/arm64/kernel/process.c
+++ b/arch/arm64/kernel/process.c
@@ -204,6 +204,9 @@ void machine_restart(char *cmd)
else
do_kernel_restart(cmd);
+ /* Give a grace period for failure to restart of 1s */
+ mdelay(1000);
+
/*
* Whoops - the architecture was unable to reboot.
*/
--
2.29.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] arm64: add grace period when rebooting
2020-12-19 14:36 ` [PATCH 1/2] arm64: add grace period when rebooting Wolfram Sang
@ 2021-01-12 13:55 ` Will Deacon
2021-01-12 14:28 ` Wolfram Sang
0 siblings, 1 reply; 6+ messages in thread
From: Will Deacon @ 2021-01-12 13:55 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-renesas-soc, Catalin Marinas, linux-kernel,
linux-arm-kernel
On Sat, Dec 19, 2020 at 03:36:46PM +0100, Wolfram Sang wrote:
> I work on a system where I currently need to reboot via watchdog.
> Because the watchdog needs a bit of time to fire, add a grace period
> like on arm32 to avoid the false positive warning message.
Please can you elaborate a bit on the control flow here, specifically
from the part which arms the watchdog to how we end up in at the mdelay()?
Ideally, the mdelay() would live in some code that knows about the watchdog,
and therefore can choose the appropriate delay.
Thanks,
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] arm64: add grace period when rebooting
2021-01-12 13:55 ` Will Deacon
@ 2021-01-12 14:28 ` Wolfram Sang
0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2021-01-12 14:28 UTC (permalink / raw)
To: Will Deacon
Cc: linux-renesas-soc, Catalin Marinas, linux-kernel,
linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 215 bytes --]
Hi Will,
> Ideally, the mdelay() would live in some code that knows about the watchdog,
> and therefore can choose the appropriate delay.
Agreed. I'll put the delay into the watchdog driver.
Thanks,
Wolfram
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] arm64: proper comment formatting in reboot handler
2020-12-19 14:36 [PATCH 0/2] arm64: small updates to rebooting Wolfram Sang
2020-12-19 14:36 ` [PATCH 1/2] arm64: add grace period when rebooting Wolfram Sang
@ 2020-12-19 14:36 ` Wolfram Sang
2020-12-22 8:56 ` Geert Uytterhoeven
1 sibling, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2020-12-19 14:36 UTC (permalink / raw)
To: linux-arm-kernel
Cc: linux-renesas-soc, Wolfram Sang, Will Deacon, linux-kernel,
Catalin Marinas
This comment was probably copied from arm32 and then shortened. It fits
to single line now.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
arch/arm64/kernel/process.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c
index 3c770329364f..e68dacbc6204 100644
--- a/arch/arm64/kernel/process.c
+++ b/arch/arm64/kernel/process.c
@@ -207,9 +207,7 @@ void machine_restart(char *cmd)
/* Give a grace period for failure to restart of 1s */
mdelay(1000);
- /*
- * Whoops - the architecture was unable to reboot.
- */
+ /* Whoops - the architecture was unable to reboot */
printk("Reboot failed -- System halted\n");
while (1);
}
--
2.29.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] arm64: proper comment formatting in reboot handler
2020-12-19 14:36 ` [PATCH 2/2] arm64: proper comment formatting in reboot handler Wolfram Sang
@ 2020-12-22 8:56 ` Geert Uytterhoeven
0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2020-12-22 8:56 UTC (permalink / raw)
To: Wolfram Sang
Cc: Linux-Renesas, Catalin Marinas, Will Deacon,
Linux Kernel Mailing List, Linux ARM
On Sat, Dec 19, 2020 at 3:38 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> This comment was probably copied from arm32 and then shortened. It fits
> to single line now.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-12 14:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-19 14:36 [PATCH 0/2] arm64: small updates to rebooting Wolfram Sang
2020-12-19 14:36 ` [PATCH 1/2] arm64: add grace period when rebooting Wolfram Sang
2021-01-12 13:55 ` Will Deacon
2021-01-12 14:28 ` Wolfram Sang
2020-12-19 14:36 ` [PATCH 2/2] arm64: proper comment formatting in reboot handler Wolfram Sang
2020-12-22 8:56 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).