From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A67E1C433DB for ; Tue, 12 Jan 2021 18:48:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41AC722B4B for ; Tue, 12 Jan 2021 18:48:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41AC722B4B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dFqD6jf5Km/gFkc3TQdKfNbGZBZOUuDTzCLMc74CwIA=; b=CTgmnHYVgI1rpLZ+bSn4Dk012 HjIBiv7yKn7yqtOrwb8hNDZPDYOp0BF8beseHrUcPycqduOQoW03UJfUxMzOWKl0LFMRkRZ8NKhQA D200HX6V98rWsI+UUWKok+evdOUuP78aLZiACBVJjAVfP3eKyBdkonjH/zMJun1fJrVEJR8YQpgtc tKwtZ7XJ9HgTCFJF+0Av514XhTN5qLWFrwlT1hlbbFXX81Hh4u7bIATWstNNpEn7RURfs5yUcyEnv ucpmvRa0XHjI9qkJknK7JBjU3avyJYOdpaPireAVKfu2bqGkKCAH5omF3cuNRMYyAvX0xtC4vFc/m WJLcBjBVw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzOgj-0005wt-Rh; Tue, 12 Jan 2021 18:46:42 +0000 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzOge-0005u8-98 for linux-arm-kernel@lists.infradead.org; Tue, 12 Jan 2021 18:46:38 +0000 Received: by mail-pg1-x529.google.com with SMTP id n25so2032583pgb.0 for ; Tue, 12 Jan 2021 10:46:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Mo28dVJ2HUEV0IicF3MnVVdQ/UP47bf6/LOz74G0NV4=; b=n0Rv5jgnsLM1fdHpmyREatiuc98/6FgLXI2u3Dfjn6JkFVDSt5K/DJYSW3AOA3dpNd TaVTPEG8+PSg7Y/loQ41zxKMEkN3JDsv8Rv7UKVx9Ww9e7FVJjezzvUqgap6inF1VAlG ESQlzGvRc2WwnmtIcSDBznngMx4NTnPy5a638LkfJxGH7BKjiuIgG8gDiWM29Z4fY1yM K3kcR6buEPDVC/r+XbO9Uvc2IlNX8eX7633wJBJRrJ+W0jWAmEw9hiBh/A6NOjU5udMK W4XSe0j58MNwisiRQuMWSpk0I9LGrahN17GBJ3Kh1PqFbCq1L0ymPWlyDHcHXfXrBClR 9Lwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Mo28dVJ2HUEV0IicF3MnVVdQ/UP47bf6/LOz74G0NV4=; b=Z173knCO20PpS5EwevbeIJRnuF3BGWbNB3j0vE8kb5eoSOU0gsSJWj0AMWvyIzdaFJ zYfPv2lQQfUw5uMena2l77dCIxaCmZQgXAq2SnIFY2Z+LLRyXaCXu8DivTZm4dLCWuzg ko+SLcublwTIE7wuxBsrCsKNhmFwGeYriXeG9Px5LEwqo9XYCTxGTtLsTi/FzCrEVbc6 yePXH+pNI3Nrx//ogPYjUvyo95i+eWtwwzxWf93ZXVhJ+v+ZDKtX/VlK3EgRbCxcyzG2 c1KJjVxgI3o7oUgaL994wmFiStIidgbHKHy7iTTNJk7+tQt1IvIoQkCNx3pK82uNU4uN vcTw== X-Gm-Message-State: AOAM5336ipPFZFaIUcngCMnrBjC7D6He8l8DBcVD7pUuUv01G2QicM/6 9O912kgx5r+99CVFz/L95A2D9g== X-Google-Smtp-Source: ABdhPJz8XWM22lS5/WksANilqkHFtMYS6BIYme4NOzR0qdTnrXuJ5cjK3YDb9upeK00P9L+S++dfJQ== X-Received: by 2002:a62:7711:0:b029:1aa:3203:73c9 with SMTP id s17-20020a6277110000b02901aa320373c9mr454876pfc.65.1610477192542; Tue, 12 Jan 2021 10:46:32 -0800 (PST) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id h3sm4362007pgm.67.2021.01.12.10.46.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 10:46:31 -0800 (PST) Date: Tue, 12 Jan 2021 11:46:29 -0700 From: Mathieu Poirier To: Peng Fan Subject: Re: [PATCH V5 7/8] remoteproc: imx_rproc: ignore mapping vdev regions Message-ID: <20210112184629.GA186830@xps15> References: <20201229033019.25899-1-peng.fan@nxp.com> <20201229033019.25899-8-peng.fan@nxp.com> <20210111215023.GJ144935@xps15> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210112_134636_656696_79680BE0 X-CRM114-Status: GOOD ( 28.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "ohad@wizery.com" , "patrice.chotard@st.com" , "festevam@gmail.com" , "s.hauer@pengutronix.de" , "linux-remoteproc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "bjorn.andersson@linaro.org" , "paul@crapouillou.net" , "o.rempel@pengutronix.de" , "agross@kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , "matthias.bgg@gmail.com" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 12, 2021 at 09:41:12AM +0000, Peng Fan wrote: > > Subject: Re: [PATCH V5 7/8] remoteproc: imx_rproc: ignore mapping vdev > > regions > > > > On Tue, Dec 29, 2020 at 11:30:18AM +0800, peng.fan@nxp.com wrote: > > > From: Peng Fan > > > > > > vdev regions are vdev0vring0, vdev0vring1, vdevbuffer and similar. > > > They are handled by remoteproc common code, no need to map in imx > > > rproc driver. > > > > > > Signed-off-by: Peng Fan > > > --- > > > drivers/remoteproc/imx_rproc.c | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/drivers/remoteproc/imx_rproc.c > > > b/drivers/remoteproc/imx_rproc.c index f80428afb8a7..e62a53ee128e > > > 100644 > > > --- a/drivers/remoteproc/imx_rproc.c > > > +++ b/drivers/remoteproc/imx_rproc.c > > > @@ -417,6 +417,9 @@ static int imx_rproc_addr_init(struct imx_rproc > > *priv, > > > struct resource res; > > > > > > node = of_parse_phandle(np, "memory-region", a); > > > + /* Not map vdev region */ > > > + if (!strcmp(node->name, "vdev")) > > > + continue; > > > > I am very confused and because I don't see an example for the DT in the > > bindings document I have to guess what is going on. > > V6 will include the DT yaml. > > > > > So I am guessing that you have laid out the memory regions for the vrings and > > the vdev0buffer in the DT "memory-region". > > The dts part will be similar as following: > > + #include > + rsc_table: rsc_table@550ff000 { > + no-map; > + reg = <0x550ff000 0x1000>; > + }; > + > + vdev0vring0: vdev0vring0@55000000 { > + no-map; > + reg = <0x55000000 0x8000>; > + }; > + > + vdev0vring1: vdev0vring1@55008000 { > + reg = <0x55008000 0x8000>; > + no-map; > + }; > + > + vdevbuffer: vdevbuffer@55400000 { > + compatible = "shared-dma-pool"; > + reg = <0x55400000 0x100000>; > + no-map; > + }; > + > + imx8mm-cm4 { > + compatible = "fsl,imx8mm-cm4"; > + clocks = <&clk IMX8MM_CLK_M4_DIV>; > + mbox-names = "tx", "rx", "rxdb"; > + mboxes = <&mu 0 1 > + &mu 1 1 > + &mu 3 1>; > + memory-region = <&vdevbuffer>, <&vdev0vring0>, <&vdev0vring1>, <&rsc_table>; > + syscon = <&src>; > + }; > > > > > For the vrings I don't see the allocation of a carveout, which means that you > > will take the memory out of the DMA pool and the reserve memory will be > > wasted. > > imx_rproc_parse_memory_regions will alloc carveout. They _will_ but for now they don't and as such there a discrepancy between the bindings and the code that was published in V6. At this point you can either drop the vrings in the DT or send another revision with the carveouts allocated. I would definitely prefer the latter because it wouldn't involve yet another modification of the bindings. > > > > > For the vdev0buffer, what you have will work *only* if that entry is the first > > one in the list of memory regions, as we agreed here [2]. > > Yes. I agree and follow this rule from then. > > Thanks, > Peng. > > > > > [1]. > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Felixir.b > > ootlin.com%2Flinux%2Fv5.11-rc3%2Fsource%2Fdrivers%2Fremoteproc%2Fre > > moteproc_core.c%23L321&data=04%7C01%7Cpeng.fan%40nxp.com%7 > > C581784529b1646b9d34b08d8b67ae8c7%7C686ea1d3bc2b4c6fa92cd99c5c > > 301635%7C0%7C0%7C637459986311799770%7CUnknown%7CTWFpbGZsb3 > > d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0 > > %3D%7C1000&sdata=Qur6YiTWlak0ZRnrUZRzawfoO38EBrAItqZm66b4 > > m20%3D&reserved=0 > > [2]. > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch > > work.kernel.org%2Fproject%2Flinux-remoteproc%2Fpatch%2F202007221315 > > 43.7024-1-peng.fan%40nxp.com%2F&data=04%7C01%7Cpeng.fan%40n > > xp.com%7C581784529b1646b9d34b08d8b67ae8c7%7C686ea1d3bc2b4c6fa9 > > 2cd99c5c301635%7C0%7C0%7C637459986311799770%7CUnknown%7CTW > > FpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJX > > VCI6Mn0%3D%7C1000&sdata=b%2F8muWtb3yxKIsnXmKmRGYYV33%2 > > FHjwA6a8x58geY7eE%3D&reserved=0 > > > > > err = of_address_to_resource(node, 0, &res); > > > if (err) { > > > dev_err(dev, "unable to resolve memory region\n"); > > > -- > > > 2.28.0 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel