From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 327BCC433E0 for ; Wed, 13 Jan 2021 11:44:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C939A233ED for ; Wed, 13 Jan 2021 11:44:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C939A233ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jcQr5zRqnAdAhfjSpMjxV6gVBctFEpsO6P+ENH6thm0=; b=uz5xoH8XPiGCBPQt3K956JPZG 26XtRJ/aq7aX7Seyianimi+bp8vs+xXkP6X0ArjOn30sHPlWU271TZqWprELGc00gFWOviSoXvZPm aOqcw/r4jgKmEC3ltBsNJzoTEBl3UvaGFPFzpn2xLJq5DAq4l4I9c4PiWUZ1XBO4JskSEGIcq9ofD 0oIDuQd2D8bZs7gcMJvX9M9UjwjovkGWVSg1On8Avwl0pvTJcumKyAoug7WBYb/XxvAOD2G4ErSAY TWK1R4z+w7Wyabv90ncnM+tjVNNXm323X9ExYasPuvdZdtNxHxRPxoowj4JiGIc2/ju8WnzbgSReA m3ulJ+WkQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzeYg-0004R2-IV; Wed, 13 Jan 2021 11:43:26 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzeYd-0004QJ-RH; Wed, 13 Jan 2021 11:43:24 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 99CCB233ED; Wed, 13 Jan 2021 11:43:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610538203; bh=4lfAzIIXpvDgPBgljbfYqu50jIJ3GftaisI4cpyB6LA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cH7Q1Mmh8k1Tg7X9NkHaLthBt+Zsk3e8LKYGc7NO2spDW/jO6zbg69p7npgbzjtbK m1ChektHDSte7Leb7PcEMROVmrXrjXJmnw4cdq63xG41juyHKrAZBpJV3cBhOwqSDC UkhB0gRBLxj0Hqu50/HJrmY6KNlJMGMgp8Q46Kzu6F0EHamlGpzUvSy0PmQKxSvhAL tIcYQ237PyW27M8pBu+4hB6EI1N+5xgmoc2Uedzv4FL4i23qViJ2AdRaJCfh6qZCic wbCdjLmTt8D/dSD7kFZdSxKigg91d8aB5No+xvOwhz3PlMJIr+pkHmefWXH8CCOSG7 Dps2UJ/dvL2FQ== Date: Wed, 13 Jan 2021 17:13:15 +0530 From: Vinod Koul To: Chris Ruehl Subject: Re: [PATCH v3] phy: rockchip-emmc: emmc_phy_init() always return 0 Message-ID: <20210113114315.GB2771@vkoul-mobl> References: <20201210080454.17379-1-chris.ruehl@gtsys.com.hk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201210080454.17379-1-chris.ruehl@gtsys.com.hk> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210113_064323_991880_DBA914A5 X-CRM114-Status: GOOD ( 10.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Heiko Stuebner , Douglas Anderson , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Kishon Vijay Abraham I , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10-12-20, 16:04, Chris Ruehl wrote: > rockchip_emmc_phy_init() return variable is not set with the error value > if clk_get() failed. 'emmcclk' is optional, thus use clk_get_optional() > and if the return value != NULL make error processing and set the > return code accordingly. Applied, thanks > > Fixes: 52c0624a10cce phy: rockchip-emmc: Set phyctrl_frqsel based on card clock > No empty lines after fixes line pls -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel