From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AABEC433DB for ; Wed, 13 Jan 2021 13:45:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9AB8823339 for ; Wed, 13 Jan 2021 13:45:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9AB8823339 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XXQeL2AE7ASvFwZOqz+yql12OqIlFEwWslWxJvNTd7g=; b=okTRuqtkCkaXLjQKj4xhZOwna lbFWgU8wtQUToAzxOivOOuu4jtjb8Jznqrj7jjHvPOjtoqaGfk9pqvvYcX9GYn45zs0LyPyArX77i 8S+yqDjWVZUYrrAKnCknm5a/VjUEYvqKsEd0s9UxHuqcd2s+n5I/xDYIxk4xS756dANq6fW3COwFM ulhe7ewjg/vFuxEFOx0hvV6oXI8rFszW8DWiLUe7U7Jv9zbsi+ml2i6ljLN13xG51jPJYHUkidT4j xK8lOcUUJoTg9LjDQLq8LMwjSpsB7UYeiWq+ml58Oofcyk/Zn+vzKjNlWoAeblJkkKdTthOR9FYNw D/hIkQvrQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzgRk-0000fN-6b; Wed, 13 Jan 2021 13:44:24 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzgRg-0000e7-P2 for linux-arm-kernel@lists.infradead.org; Wed, 13 Jan 2021 13:44:21 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4D31823339; Wed, 13 Jan 2021 13:44:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610545458; bh=yxQwj7GErWFKst6hClfszM91CiSR/sjTPkADcoTkPH0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YcB7crq3hn52aPbNe0/Ti6ExxAYovh1rGMfLJgiY80ZiCBwTAdK01k7DjSMHeTTTh 063QZiOJyfrrssG3CeaAqvSqH8DBGF4OJ0i5aTHZcgcenfO44Auq8lu4oKYwaHI3IB 9eB7hMuzH/hkWi8YU/n90wQrXeB+Wk7baC1Hx6Lw3xk/NEB/5hgWs7pIBCx2OVjIYl Owxa4Vacll3dWTFxSazNhWMnqdujGsipk+JBvQFnyjNcdnGv1LxIgTN9FXfMyz0znr oqp651nCUQBI6ebnKxP1+Pc+9ATW113fjboBTwjMTGJonczcNcyUzJWo6BE3l5PqG/ 49B2XXQtW6LGg== Date: Wed, 13 Jan 2021 13:44:12 +0000 From: Will Deacon To: Mark Rutland Subject: Re: [PATCH] arm64: make atomic helpers __always_inline Message-ID: <20210113134412.GA11757@willie-the-truck> References: <20210108092024.4034860-1-arnd@kernel.org> <20210108093258.GB4031@willie-the-truck> <20210112102312.GC34326@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210112102312.GC34326@C02TD0UTHF1T.local> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210113_084420_934046_9AD888FC X-CRM114-Status: GOOD ( 23.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Arnd Bergmann , Herbert Xu , Arnd Bergmann , Peter Zijlstra , Catalin Marinas , Boqun Feng , Nick Desaulniers , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Nathan Chancellor , Thomas Gleixner , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 12, 2021 at 10:23:12AM +0000, Mark Rutland wrote: > On Fri, Jan 08, 2021 at 09:39:53PM +0100, Peter Zijlstra wrote: > > On Fri, Jan 08, 2021 at 09:32:58AM +0000, Will Deacon wrote: > > > Hi Arnd, > > > > > > On Fri, Jan 08, 2021 at 10:19:56AM +0100, Arnd Bergmann wrote: > > > > From: Arnd Bergmann > > > > > > > > With UBSAN enabled and building with clang, there are occasionally > > > > warnings like > > > > > > > > WARNING: modpost: vmlinux.o(.text+0xc533ec): Section mismatch in reference from the function arch_atomic64_or() to the variable .init.data:numa_nodes_parsed > > > > The function arch_atomic64_or() references > > > > the variable __initdata numa_nodes_parsed. > > > > This is often because arch_atomic64_or lacks a __initdata > > > > annotation or the annotation of numa_nodes_parsed is wrong. > > > > > > > > for functions that end up not being inlined as intended but operating > > > > on __initdata variables. Mark these as __always_inline, along with > > > > the corresponding asm-generic wrappers. > > > > > > Hmm, I don't fully grok this. Why does it matter if a non '__init' function > > > is called with a pointer to some '__initdata'? Or is the reference coming > > > from somewhere else? (where?). > > > > FWIW the x86 atomics are __always_inline in part due to the noinstr > > crud, which I imagine resulted in much the same 'fun'. > > FWIW, I was planning on doing the same here as part of making arm64 > noinstr safe, so I reckon we should probably do this regardless of > whether it's a complete fix for the section mismatch issue. Fair enough: Acked-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel