From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FDC5C433E0 for ; Wed, 13 Jan 2021 15:04:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED5BD23339 for ; Wed, 13 Jan 2021 15:04:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED5BD23339 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=z72450GvVhj6eJxtQaUAoJIfbupphkDHRiPGmxfwI5o=; b=u3f1KoqViNhA6+9QJ3IN0Yuv8 2jddAFGSSvCyxKepidqyvz6R8Q6kgQvhxre+E05t0McLkVNEcPKIkTwHILBf+k+yerOggZnUFGjQE JtfJk4USMgq2wS/6bIjWdrQ8lKb8IOFEe9UKeE+TeLsrVWlx8yZ8Kwj9L4lqvjdOX1QK5uB4mQZyo s/TVuSp4lexoVJ0x4wmc3mjEL2vzTmrYXXpCPJVSYTmkymQeUh9N4L8NemEUceemkcCVBeILU0gc7 c2adTOz6d8Nbf41mkb9enS1ngiRw/XWxrCc7nCLx80Tf7cBY3CVLzqV3ZGxlo09W4XC/gljSfXX0X 7ym1Xv3uA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzhfU-0006E3-LB; Wed, 13 Jan 2021 15:02:40 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzhfS-0006DV-GW for linux-arm-kernel@lists.infradead.org; Wed, 13 Jan 2021 15:02:39 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 65E2623600; Wed, 13 Jan 2021 15:02:35 +0000 (UTC) Date: Wed, 13 Jan 2021 15:02:32 +0000 From: Catalin Marinas To: Linus Torvalds Subject: Re: [PATCH] compiler.h: Raise minimum version of GCC to 5.1 for arm64 Message-ID: <20210113150232.GA27045@gaia> References: <20210112224832.10980-1-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210113_100238_694253_213A01D9 X-CRM114-Status: GOOD ( 18.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Weimer , Arnd Bergmann , Theodore Ts'o , Peter Zijlstra , Will Deacon , Masahiro Yamada , Nick Desaulniers , Linux Kernel Mailing List , Russell King , Android Kernel Team , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 12, 2021 at 06:35:50PM -0800, Linus Torvalds wrote: > On Tue, Jan 12, 2021 at 6:14 PM Linus Torvalds > wrote: > > > > Ack. I'll assume I get this the usual ways from the arm64 tree.. > > Oh.. Actually, while you can use my ack if you decide to go this way, > I do wonder if it might not be better to introduce a notion of an > error at Kconfig time, and then we could make this whole GCC_VERSION > check be something that gets covered much earlier - when configuring > the kernel, rather than randomly (ok, very early) when building it. > > We already have the CONFIG_GCC_VERSION config variable, after all. > > And Kconfig already has an error functionality, which it uses for > things like compilers not found etc. > > So something like > > $(error-if,CC_IS_GCC && GCC_VERSION < 90100,"Gcc version too old") > > in the arm64 Kconfig file should do it. $(error-if) seems to expect a y/n as a condition. We do have $(failure) and $(success) but they translate a (shell) command's return code to y/n. Even with something like: config GCC_IS_OLD def_bool CC_IS_GCC && GCC_VERSION < ... I can't get $(error-if,GCC_IS_OLD) to expand the config value, no matter what other. GCC_VERSION is also a config option in your example. I'll queue Will's patch in the meantime. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel