From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27A38C433DB for ; Wed, 13 Jan 2021 16:48:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBA3223441 for ; Wed, 13 Jan 2021 16:48:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBA3223441 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=e7QwKufSZGRRvEHefy+SuES5B/CpTafxRFzXfpFqALk=; b=DExwcA7VAWlGWfFpBEQgYKbaX xBv8vE2VBLR607M/fs9Wx/vm5AVnNssE0AQJmYCTfcg6uSJX4EsxswUh77t/zJp3aJW8BnFhYl/by JjzrFB3XqwooamYPJGM6Cqg8jIyYgpXAwO6xdzeDTk+h1l+3NQHVBhCBwa6XX5+h9h0nBXYATBv7O vB901DJsZV22APMx5/aasSnBAXAuNvQLnARiOm6BfYGrLUuNcMyoQNOn1DWO73pzIj5raP8BTmi+M FAh1nJTz/UIEtUGA1iiEb3niGlBoRcsVr+m2TG6drzpklYzAp/kgonHGgfCkpSVnby2b9l/HmABd5 xpQxUPQRQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzjHu-0005gT-EZ; Wed, 13 Jan 2021 16:46:26 +0000 Received: from mail-wr1-f41.google.com ([209.85.221.41]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzjHr-0005fs-E4 for linux-arm-kernel@lists.infradead.org; Wed, 13 Jan 2021 16:46:24 +0000 Received: by mail-wr1-f41.google.com with SMTP id r3so2851137wrt.2 for ; Wed, 13 Jan 2021 08:46:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=L2q23JMI3ucNuJLrUHDTAlQX1rRDKarrrUWr9cUB7so=; b=KF1rshyWgx5NjIosYy42fgKyssF4+nXdJH2GY1rkfxROrY5hhdFW1w4IgnT+dERZuG IRAj7IDRXb4MvrWCD2rTfcKyp/ertNQgNGtjkaRob1I3z1WhyudEO2hq4Wqw8yDhZpM0 ePspUR0H0i5Dxt5w7y9X7s852BjKYOp16ZdXqSzSy0LqWpNASloQqkigp/BFmFRnnARs yrsC6Qz7Okfd5HENXrKOT2u2TWUwewPWsBcppJMT8CNBLTFMdAaVvCNgTBgMOlebh0Y5 wwl0KKF2eoEviOrfgWh9Mh+61n9/rvMRallbjT2YFD9lz9i1zlA7d+KaNFqMX+G2P0JD bVuw== X-Gm-Message-State: AOAM5332zLZ+pDZeInbGU8Lc1xzp4GgQbwHOfz1GBMffjr9c2l5NnvKP Bvd9LT88qWBhvtnO0VlpSWs= X-Google-Smtp-Source: ABdhPJxc7oIqPqigRdH3NLgi0T8fDfL1gY0TNXCbN4K98dABPZsfbCXHUO7bCzZsCZ8KEZ1fUxvcFg== X-Received: by 2002:adf:a495:: with SMTP id g21mr3705125wrb.198.1610556381808; Wed, 13 Jan 2021 08:46:21 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id r1sm4274016wrl.95.2021.01.13.08.46.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 08:46:20 -0800 (PST) Date: Wed, 13 Jan 2021 17:46:19 +0100 From: Krzysztof Kozlowski To: Adrien Grassein Subject: Re: [PATCH v2 2/3] arm64: dts: imx: Add i.mx8mm nitrogen8mm basic dts support Message-ID: <20210113164619.GA5874@kozik-lap> References: <20210113143443.1148506-1-adrien.grassein@gmail.com> <20210113143443.1148506-3-adrien.grassein@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210113143443.1148506-3-adrien.grassein@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210113_114623_501083_9FDB7CE1 X-CRM114-Status: GOOD ( 19.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 13, 2021 at 03:34:42PM +0100, Adrien Grassein wrote: > Tested with a basic Build Root configuration booting from sdcard. > > Signed-off-by: Adrien Grassein > --- > arch/arm64/boot/dts/freescale/Makefile | 1 + > .../dts/freescale/imx8mm-nitrogen8mm_rev2.dts | 364 ++++++++++++++++++ > 2 files changed, 365 insertions(+) > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > index 901d80086b47..b2eb7a5e4db3 100644 > --- a/arch/arm64/boot/dts/freescale/Makefile > +++ b/arch/arm64/boot/dts/freescale/Makefile > @@ -45,6 +45,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-devkit.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r2.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r3.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mq-nitrogen.dtb > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-nitrogen8mm_rev2.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mq-phanbell.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mq-pico-pi.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mq-thor96.dtb > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts > new file mode 100644 > index 000000000000..506e467ebf16 > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts > @@ -0,0 +1,364 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Device Tree file for Boundary Devices i.MX8MMini Nitrogen8MM Rev2 board. > + * Adrien Grassein > + */ > +/dts-v1/; > +#include "imx8mm.dtsi" > + > +/ { > + model = "Boundary Devices i.MX8MMini Nitrogen8MM Rev2"; > + compatible = "boundary,imx8mm-nitrogen8mm", "fsl,imx8mm"; > + > + reg_vref_1v8: regulator-vref-1v8 { > + compatible = "regulator-fixed"; > + regulator-name = "vref-1v8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + reg_vref_3v3: regulator-vref-3v3 { > + compatible = "regulator-fixed"; > + regulator-name = "vref-3v3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + }; Why do you need these two regulators? They don't do anything, there is no control over them. > +}; > + > +&A53_0 { > + cpu-supply = <®_sw3>; > +}; > + > +&A53_1 { > + cpu-supply = <®_sw3>; > +}; > + > +&A53_2 { > + cpu-supply = <®_sw3>; > +}; > + > +&A53_3 { > + cpu-supply = <®_sw3>; > +}; > + > +&i2c1 { > + clock-frequency = <400000>; > + pinctrl-names = "default", "gpio"; > + pinctrl-0 = <&pinctrl_i2c1>; > + pinctrl-1 = <&pinctrl_i2c1_1>; > + scl-gpios = <&gpio5 14 GPIO_OPEN_DRAIN>; > + sda-gpios = <&gpio5 15 GPIO_OPEN_DRAIN>; > + status = "okay"; > + > + pmic@8 { > + compatible = "nxp,pf8121a"; > + reg = <0x8>; > + status = "okay"; > + > + regulators { > + reg_ldo2: ldo2 { The PMIC regulators should be described fully, so bring them back from the v1. > + regulator-always-on; > + regulator-boot-on; > + regulator-max-microvolt = <5000000>; > + regulator-min-microvolt = <1500000>; > + }; > + > + reg_sw3: buck3 { > + regulator-always-on; > + regulator-boot-on; > + regulator-max-microvolt = <1800000>; > + regulator-min-microvolt = <400000>; > + }; > + }; > + }; > +}; > + > +&fec1 { Please order the overridden nodes alphabetically, with iomux exception which goes to the end (by convention in NXP). You define i2c1, then fec1 and then i2c3. Should be fec1, i2c1 and then i2c3. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel