From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 537F0C433DB for ; Wed, 13 Jan 2021 21:27:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 05BAD2225E for ; Wed, 13 Jan 2021 21:27:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 05BAD2225E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID:Subject:To:From: Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=pV5GYZ2aHjO0F1lPLkG9DRtmW0LsEuvDEuPpKyewD+Y=; b=ePyFxdFioRiU3yci6obSBgl/E bl9nZd9IzVpjm1GWLvdHspg8SCW1NOWxu5oOJzLMGJbAJ28tLVr4N4WDxl/kGP69FFm2SJ3Ggw/r9 RchGWC+AQNp/bmg6321IUjNnWYTXwQzc+RDtf7Q+Fr9ZrMDnC01swJHHPCiG5fbk88xyO7NFYSHON FWAmQxJ+G4mf77d8n26p9gpjFeSBsIDb6aAyBeTtUWalN4rUNpPncyPs4LUiMg2QTe9nUjOkQtQUz yX0v1jLQJPQ++OquG3GTfCBlsAvJBKzllKQqDjV8pDd8mYYhtI3tWP9hcGtfuHodxgoumTWTgJqKW JtQ33QRTQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzndy-0002Nz-Vd; Wed, 13 Jan 2021 21:25:31 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzndv-0002Na-PK for linux-arm-kernel@lists.infradead.org; Wed, 13 Jan 2021 21:25:28 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 08C8720DD4; Wed, 13 Jan 2021 21:25:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610573125; bh=CnNxb+8yGGrLBAdxm2EQDAH/OEkEdMsqk9sG6FYEJhM=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=eLUDRnQEWM7PadLAq9Mxy0LQgQSTTIRG2PFDBR1vmeo59UTtBYUPPzA+x5daVASKK QebCIIOTKjo3xCN5j3hjYDqlvtT4JCvJ6U8deVhBK+/F/AlZZR4tLIWraC0ALEDx19 o1Xw6SVLODjDiefwPnbD9yKWmpoF5jyQfSDOnIeTJX16brh7nZjzZ0KtagDMMvf+ru IpOLmHL2eOVgqvIKpWF4tiJzuHCKNK4LnD7vVpd5aLHaWyfnrhHQw35WjqW648Pw4C 8fMjICRch3UpWJzLjx4eWAZKjF/oQYLZg490gUlbHgioBxaabEzeLCWjii3rsLlAbb k8DS5SP1imY7g== Date: Wed, 13 Jan 2021 15:25:23 -0600 From: Bjorn Helgaas To: Heiner Kallweit Subject: Re: [PATCH v3 1/3] PCI: Disable parity checking if broken_parity is set Message-ID: <20210113212523.GA1933362@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8e9c5b3a-f239-8d8d-08e5-015ec38dd3a0@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210113_162528_018342_A06A69B8 X-CRM114-Status: GOOD ( 29.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Realtek linux nic maintainers , "linux-pci@vger.kernel.org" , Russell King - ARM Linux , Lennert Buytenhek , "netdev@vger.kernel.org" , Bjorn Helgaas , Jakub Kicinski , David Miller , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 13, 2021 at 09:52:23PM +0100, Heiner Kallweit wrote: > On 06.01.2021 20:34, Heiner Kallweit wrote: > > On 06.01.2021 20:22, Bjorn Helgaas wrote: > >> On Wed, Jan 06, 2021 at 06:50:22PM +0100, Heiner Kallweit wrote: > >>> If we know that a device has broken parity checking, then disable it. > >>> This avoids quirks like in r8169 where on the first parity error > >>> interrupt parity checking will be disabled if broken_parity_status > >>> is set. Make pci_quirk_broken_parity() public so that it can be used > >>> by platform code, e.g. for Thecus N2100. > >>> > >>> Signed-off-by: Heiner Kallweit > >>> Reviewed-by: Leon Romanovsky > >> > >> Acked-by: Bjorn Helgaas > >> > >> This series should all go together. Let me know if you want me to do > >> anything more (would require acks for arm and r8169, of course). > >> > > Right. For r8169 I'm the maintainer myself and agreed with Jakub that > > the r8169 patch will go through the PCI tree. > > > > Regarding the arm/iop32x part: > > MAINTAINERS file lists Lennert as maintainer, let me add him. > > Strange thing is that the MAINTAINERS entry for arm/iop32x has no > > F entry, therefore the get_maintainers scripts will never list him > > as addressee. The script lists Russell as "odd fixer". > > @Lennert: Please provide a patch to add the missing F entry. > > > > ARM/INTEL IOP32X ARM ARCHITECTURE > > M: Lennert Buytenhek > > L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > > S: Maintained > > Bjorn, I saw that you set the series to "not applicable". Is this because > of the missing ack for the arm part? No, it's because I screwed up. I use "not applicable" when I expect patches to go via another tree. I just missed your note about merging via the PCI tree. I'll take a look soon. > I checked and Lennert's last kernel contribution is from 2015. Having said > that the maintainer's entry may be outdated. Not sure who else would be > entitled to ack this patch. The change is simple enough, could you take > it w/o an ack? > Alternatively, IIRC Russell has got such a device. Russell, would it > be possible that you test that there's still no false-positive parity > errors with this series? > > > > > >>> --- > >>> drivers/pci/quirks.c | 17 +++++++++++------ > >>> include/linux/pci.h | 2 ++ > >>> 2 files changed, 13 insertions(+), 6 deletions(-) > >>> > >>> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > >>> index 653660e3b..ab54e26b8 100644 > >>> --- a/drivers/pci/quirks.c > >>> +++ b/drivers/pci/quirks.c > >>> @@ -205,17 +205,22 @@ static void quirk_mmio_always_on(struct pci_dev *dev) > >>> DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_ANY_ID, PCI_ANY_ID, > >>> PCI_CLASS_BRIDGE_HOST, 8, quirk_mmio_always_on); > >>> > >>> +void pci_quirk_broken_parity(struct pci_dev *dev) > >>> +{ > >>> + u16 cmd; > >>> + > >>> + dev->broken_parity_status = 1; /* This device gives false positives */ > >>> + pci_read_config_word(dev, PCI_COMMAND, &cmd); > >>> + pci_write_config_word(dev, PCI_COMMAND, cmd & ~PCI_COMMAND_PARITY); > >>> +} > >>> + > >>> /* > >>> * The Mellanox Tavor device gives false positive parity errors. Mark this > >>> * device with a broken_parity_status to allow PCI scanning code to "skip" > >>> * this now blacklisted device. > >>> */ > >>> -static void quirk_mellanox_tavor(struct pci_dev *dev) > >>> -{ > >>> - dev->broken_parity_status = 1; /* This device gives false positives */ > >>> -} > >>> -DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_MELLANOX, PCI_DEVICE_ID_MELLANOX_TAVOR, quirk_mellanox_tavor); > >>> -DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_MELLANOX, PCI_DEVICE_ID_MELLANOX_TAVOR_BRIDGE, quirk_mellanox_tavor); > >>> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_MELLANOX, PCI_DEVICE_ID_MELLANOX_TAVOR, pci_quirk_broken_parity); > >>> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_MELLANOX, PCI_DEVICE_ID_MELLANOX_TAVOR_BRIDGE, pci_quirk_broken_parity); > >>> > >>> /* > >>> * Deal with broken BIOSes that neglect to enable passive release, > >>> diff --git a/include/linux/pci.h b/include/linux/pci.h > >>> index b32126d26..161dcc474 100644 > >>> --- a/include/linux/pci.h > >>> +++ b/include/linux/pci.h > >>> @@ -1916,6 +1916,8 @@ enum pci_fixup_pass { > >>> pci_fixup_suspend_late, /* pci_device_suspend_late() */ > >>> }; > >>> > >>> +void pci_quirk_broken_parity(struct pci_dev *dev); > >>> + > >>> #ifdef CONFIG_HAVE_ARCH_PREL32_RELOCATIONS > >>> #define __DECLARE_PCI_FIXUP_SECTION(sec, name, vendor, device, class, \ > >>> class_shift, hook) \ > >>> -- > >>> 2.30.0 > >>> > >>> > >>> > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel