From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B3A5C433DB for ; Wed, 13 Jan 2021 21:46:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1261F22B2B for ; Wed, 13 Jan 2021 21:46:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1261F22B2B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VmQrfFl6N2GH/ve7a/u9p6s/zx41XXv95diZZNzqcIY=; b=H192ij1V6cg1RpgA0s7D28DQ6 rqfoiYNoFQsDDBWeh+fhI6hYaZLPjB/F82hhKM05NHt1eXAKzWBNzRWwD2K7JESaD+yji2o3wpw6K T7WeftlAP9hbc0C2Vmr8ypAiKGomSxCHfIijqRXSqM040wXFpVkOLPTQbw1NtrkOvrdJjeArY/ErQ N+1bMcsVNXEqleMOeugkic92N8wtzmLy20zPHYRWrnMMGsRms29EwcGjU3O549LCvkm+Gn7B0F6ty CrOAhOP7rd+evE7DLaVMvFfXncVNmXplWmaPS45iugeHcia2FvCrh5STttT/raHUgY3ia3bdhAZaO wJ60y6k3g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kznwb-0004C7-0x; Wed, 13 Jan 2021 21:44:45 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kznwY-0004Bi-KI for linux-arm-kernel@lists.infradead.org; Wed, 13 Jan 2021 21:44:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=jQMfbayy2yzW173Q/GJuPVzTG6Wm2caGZkDvDFIYEBo=; b=fnpZm0oIPbAh1CMnqRdAP3Umv 44UShPSsUDqhPjL0bM8IpKs8YOESerkfnuIBTOEF9whdTw1zuyIZYR+6JrGxDsGvvXPAiZLFYQfgD 3xhpt2JhlUFYv4V7ogQxVpaynC2ZJZHcs+MU6iC6ggARG/9gTxegVqt5atJtSKFBNi25roi82pejH CEzsy5Ou/S6+4MOKgfXnu14NHQE4VsWVV6Sk7COKsnfbtL3XZn/oH98yLJIG26ddU4226RCzJwfYf mPvK7iP3Sh2J7RRhl9zZEIsB4VKDe4QTSSqUpXoGiuC46XfJrFoWdq4TeqxaUqYYBrw3t241zts+Q Otay66j9Q==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:47598) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kznwV-0001ho-Go; Wed, 13 Jan 2021 21:44:39 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kznwT-0007f3-1M; Wed, 13 Jan 2021 21:44:37 +0000 Date: Wed, 13 Jan 2021 21:44:37 +0000 From: Russell King - ARM Linux admin To: Linus Torvalds Subject: Re: [PATCH] compiler.h: Raise minimum version of GCC to 5.1 for arm64 Message-ID: <20210113214436.GL1551@shell.armlinux.org.uk> References: <20210112224832.10980-1-will@kernel.org> <161055398865.21762.12236232732054213928.b4-ty@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210113_164442_691313_4469A303 X-CRM114-Status: GOOD ( 21.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Weimer , Arnd Bergmann , "Cc: Android Kernel" , Theodore Ts'o , Peter Zijlstra , Catalin Marinas , Masahiro Yamada , Nick Desaulniers , Linux Kernel Mailing List , Will Deacon , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 13, 2021 at 11:15:09AM -0800, Linus Torvalds wrote: > On Wed, Jan 13, 2021 at 9:58 AM Masahiro Yamada wrote: > > > > Maybe, we can raise the minimal version to gcc 5.1 > > for all architectures. > > It was discussed, but the immediate reason for this thing really does > seem to be specific to just arm64 (ie this is not some generic gcc > stack access bug that just happens to rear its head on arm64 - the > patch to fix this in the gcc bugzilla is very much arm64-only). I seem to remember during the discussion of the arm64 problem, that there was a similar bug on e.g. sparc, but they patched the kernel. *digs through irc logs...* https://patchwork.kernel.org/project/linux-crypto/patch/20170602.112854.571030442583332811.davem@davemloft.net/ https://marc.info/?l=linux-sparc&m=149636946609980&w=2 (and they even reference the arm64 bug). If you move on two messages, then the disassembly clearly shows that it is the same bug on Sparc. DaveM came up with the following to fix it: commit d41519a69b35b10af7fda867fb9100df24fdf403 Author: David Miller Date: Fri Jun 2 11:28:54 2017 -0400 crypto: Work around deallocated stack frame reference gcc bug on sparc. which added a bunch of barriers across the kernel to cater for this, but for them, ext4 was not impacted at that time. Apparently, davem's justification for not changing ext4 was: "Actually, ext4 doesn't trigger the problem because the on-stack object used in ext4 is a fixed size at compile time" So, maybe the Sparc issue was just a similar but different bug in gcc 4.9.x. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel