From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88F20C433E0 for ; Thu, 14 Jan 2021 14:15:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4907B23A69 for ; Thu, 14 Jan 2021 14:15:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4907B23A69 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=La6QvbFRJRtPx39X/f1J9+Ce12PSbgiBih+6uJjdXDs=; b=Uj8EsBjtmjbDxVsl+IWPaO5fD JoW6YHS1AzLNLaRsuRiS3eg+cpcs7t7mLsE2NRtENkPE69A07xO+d+PoWw2/MjtLHSPfhDzHicq98 Xq+CyjYEpoM30W4kAA1UcqblRpvy8l9bWdQgLHttNGew43g0Sjl3nDlwFWdLtr1jcyY0IBZgTwArf K9KOX2r6jUeeDBzGmYCY4Sx0TrzugyZw9Z9Slu5IDuXpj4R3n5q1lNOWt7NMl78N5oHFkWYnA6jWn bLRgNmcQecan6z6WXG+CCzbEc4EoiLh5J7YzpG+RSOhORYkkm6szGc7kgBqIIC8vQjrSyyOlC03fo WR14/VU4A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l03NU-0005Ny-MH; Thu, 14 Jan 2021 14:13:32 +0000 Received: from mail-oi1-f181.google.com ([209.85.167.181]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l03NS-0005Mf-KH for linux-arm-kernel@lists.infradead.org; Thu, 14 Jan 2021 14:13:31 +0000 Received: by mail-oi1-f181.google.com with SMTP id 9so6030148oiq.3 for ; Thu, 14 Jan 2021 06:13:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6h5oUPZ53wfO7f92HycjGe1n6yQ3GPM+QRp+J+bOXQU=; b=Gm6a/c337CGlXLGX5SMXv2IHygPerTNWqgqx+qRyIeYZl4tk0DpqnwRfdEq0Ein0tW CUOswj2Fk/8JSxAicN3Z3bOKWTnmSBPOYHqADiPqIq28Hs6C8/N2K2ygCIuDclbs0mcn MsWjVAggN2xcdpwxcuj75HAwF2ASwnwaXrthTtmNBNiBjOB/TpPP7Cv2BMatP1LVfSck 8es0xgdUArfJcjX0XcQYHhfgcUdUynHJkAhPC2gg+AcHjHhcReVKLMKgEOYf4qhiKP5B +UOGie3k7vk2GE+nqn7cwyILp6N8EqzZVpDQ9zA7wjacRAP2h23tTqZ9gr1io1VylPag ReCQ== X-Gm-Message-State: AOAM531Solj0CL1MbJyAxXaiXFN2IgzKIXoqUuZgSm7+8LDmg+0w1iFk vAFCyqU+h+F/TQN+x1mnbs+cQaWufg== X-Google-Smtp-Source: ABdhPJxRzKOok/V/nC7yvIoQFv1kr5D7gm8HVf45a+LU/nY5SxSFQOxwkwYlL+jMqNwCCy9n20BtQw== X-Received: by 2002:aca:c592:: with SMTP id v140mr2687412oif.10.1610633599393; Thu, 14 Jan 2021 06:13:19 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id n13sm1064351otk.58.2021.01.14.06.13.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jan 2021 06:13:18 -0800 (PST) Received: (nullmailer pid 2833114 invoked by uid 1000); Thu, 14 Jan 2021 14:13:17 -0000 Date: Thu, 14 Jan 2021 08:13:17 -0600 From: Rob Herring To: Troy Lee Subject: Re: [PATCH v2 1/4] dt-bindings: hwmon: Add Aspeed AST2600 PWM/Fan Message-ID: <20210114141317.GA2823834@robh.at.kernel.org> References: <20210113070850.1184506-1-troy_lee@aspeedtech.com> <20210113070850.1184506-2-troy_lee@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210113070850.1184506-2-troy_lee@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210114_091330_707807_E01A531B X-CRM114-Status: GOOD ( 25.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:HARDWARE MONITORING" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Jean Delvare , Ryan Chen , "moderated list:ARM/ASPEED MACHINE SUPPORT" , Jonathan Corbet , Andrew Jeffery , openbmc@lists.ozlabs.org, "open list:DOCUMENTATION" , open list , leetroy@gmail.com, Joel Stanley , Philipp Zabel , chiawei_wang@aspeedtech.com, Guenter Roeck , "moderated list:ARM/ASPEED MACHINE SUPPORT" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 13, 2021 at 07:08:45AM +0000, Troy Lee wrote: > We add binding for supporting a new AST2600 PWM/Fan hwmon driver. > > Changes since v1: > - dt binding with DT schema format > > Signed-off-by: Troy Lee > --- > .../hwmon/aspeed,ast2600-pwm-tachometer.yaml | 137 ++++++++++++++++++ > 1 file changed, 137 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/aspeed,ast2600-pwm-tachometer.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/aspeed,ast2600-pwm-tachometer.yaml b/Documentation/devicetree/bindings/hwmon/aspeed,ast2600-pwm-tachometer.yaml > new file mode 100644 > index 000000000000..b84076a4a338 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/aspeed,ast2600-pwm-tachometer.yaml > @@ -0,0 +1,137 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > + > +$id: http://devicetree.org/schemas/hwmon/aspeed,ast2600-pwm-tachometer.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ASPEED AST2600 PWM and Fan Tacho controller device driver > + > +maintainers: > + - Ryan Chen > + > +description: | > + The ASPEED PWM controller can support upto 16 PWM outputs. The ASPEED Fan Tacho > + controller can support upto 16 Fan tachometer inputs. > + There can be upto 16 fans supported. Each fan can have one PWM output and > + one Fan tach inputs. > + > +properties: > + compatible: > + const: aspeed,ast2600-pwm-tachometer > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + "#cooling-cells": > + const: 2 > + > + reg: > + description: > + Address and length of the register set for the device. No need for generic descriptions. That's every 'reg'. What you need is how many entries and what each one is if more than 1. If only 1, then just 'maxItems: 1' > + > + clocks: > + description: > + phandle to clock provider with the clock number in the second cell Same here. > + > + resets: > + description: > + phandle to reset controller with the reset number in the second cell And here. > + > +patternProperties: > + "@[0-9]+$": If every node is a fan and there are up to 16: ^fan@[0-9a-f]$ > + type: object > + description: > + Under fan subnode there can upto 16 child nodes, with each child node > + representing a fan. There are 16 fans each fan can have one PWM port and one > + Fan tach inputs. > + For PWM port can be configured cooling-levels to create cooling device. > + Cooling device could be bound to a thermal zone for the thermal control. > + > + properties: > + reg: > + minimum: 0 > + maximum: 15 > + description: > + This property identify the PWM control channel of this fan. > + > + fan-tach-ch: > + $ref: /schemas/types.yaml#/definitions/uint8 > + minimum: 0 > + maximum: 15 > + description: > + This property identify the fan tach input channel. > + > + pulses-per-revolution: > + $ref: /schemas/types.yaml#/definitions/uint32 > + default: 2 > + minimum: 1 > + description: > + Specify tacho pulse per revolution of the fan. > + > + cooling-levels: > + description: > + PWM duty cycle values in a range from 0 to 255 > + which correspond to thermal cooling states. > + > + aspeed,pwm-freq: > + $ref: /schemas/types.yaml#/definitions/uint32 > + default: 25000 > + minimum: 24 > + maximum: 780000 > + description: > + Specify the frequency of PWM. Units? Use a unit suffix and then drop the $ref. > + > + aspeed,inverse-pin: > + type: boolean > + description: > + Inverse PWM output signal. > + > + aspeed,falling-point: > + $ref: /schemas/types.yaml#/definitions/uint8 > + default: 10 > + minimum: 0 > + maximum: 255 0-255 is already the range of uint8, so drop. > + description: > + Initialize the pulse width. > + > + required: > + - fan-tach-ch > + - reg > + > + additionalProperties: true > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + pwm_tacho: pwm-tacho-controller@1e610000 { > + compatible = "aspeed,ast2600-pwm-tachometer"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x1e610000 0x100>; > + > + fan@1 { > + reg = <0x00>; > + aspeed,pwm-freq = <25000>; > + cooling-levels = /bits/ 8 <125 151 177 203 229 255>; > + fan-tach-ch = /bits/ 8 <0x00>; > + pulses-per-revolution = <2>; > + }; > + > + fan@2 { > + reg = <0x01>; > + aspeed,pwm-freq = <25000>; > + cooling-levels = /bits/ 8 <125 151 177 203 229 255>; > + fan-tach-ch = /bits/ 8 <0x01>; > + pulses-per-revolution = <2>; > + }; > + }; > +... > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel