From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC0D9C433E0 for ; Fri, 15 Jan 2021 01:38:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70D8023A5A for ; Fri, 15 Jan 2021 01:38:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70D8023A5A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cTsNnR0kjN42UF3kDZutC/nFnqNO6JJ/4CaM9NZ1ipQ=; b=e6TnSQ+BGAAZUTEvjbp9PoDqY jFYtGqc2PC/DawdmGv6XGJWKMjNlJtWaKiCPr/hHGrre9wlsjdZTEd5WMOgfbhVAYDk1i0tkRhPDp nzbguszURzLO1bJdcyp7QtHRts+vSz9XwyQp5CEe7KYPKv/MoL3TNIZy6EmKfb/Y+k4hOCBvPJ9ff gHr5+fB7ySHcH0dYPaI1a0321p9hcENcv4u1Rh/KVpHoFIBFuZkhobDCq3CYGIZYU82ZyhtzwDEI8 p3KQtfwwq42J6/bs1uOURcFDmsREq9yPkW26BnYwObRIzzoHZsDgMVLOwmij7WJShX6/8siP3fx+b fwva7llXg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l0E3F-0004Nm-20; Fri, 15 Jan 2021 01:37:21 +0000 Received: from mail-oo1-f44.google.com ([209.85.161.44]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l0E3B-0004NR-N9 for linux-arm-kernel@lists.infradead.org; Fri, 15 Jan 2021 01:37:18 +0000 Received: by mail-oo1-f44.google.com with SMTP id x23so1850465oop.1 for ; Thu, 14 Jan 2021 17:37:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=B1Ff7qOZtqWbaa6dcje7anpfbO79/6GxsJBsubA8V5I=; b=XwLTX1etNHB6Kn87Wm3XmshCCpfSR1T/wRgpy0eKn/aMLxm3vd65/XmZLH52RViAfV 6xrqcuEZH1vJmEtbIF/JDl3YhGN37BnzNHSc0MaFkc+7d8EH2LHUt1sYXeQkt5cD/YT4 yWKzladWMPwYnxMu2/tCo3LQnoOCUgGIhGfHGHThkE2giwXMQV3/LQyMA/eXVOUNKekT DEd4dEMg7sLhSvFfZ9NQcDZOYvegfs+x24I7KhmWMVVef47+4M8uqinHCb0Qq3lMzp3G LtCa4y/jN9eA184CkKY1L/ocgw0dj7aTObJaxxe5E57PDKGdSznNhAFHh/W9aQjDcfDu cXCQ== X-Gm-Message-State: AOAM531hMdoFy9ui+kKt3fzDM3WP2O2mQp7hADAdNP+IeGkUzVMiV5A6 Uyo+QI4vjlM6wpExdbKJzA== X-Google-Smtp-Source: ABdhPJyFyDaKkERDpwPSUR6Vf+aiqUbqUP/NduqcejiSp69R8O67GudiyrmAmf8aNGzobnyk3efNjg== X-Received: by 2002:a4a:b244:: with SMTP id i4mr6606670ooo.5.1610674636623; Thu, 14 Jan 2021 17:37:16 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id s204sm1405643oib.42.2021.01.14.17.37.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jan 2021 17:37:15 -0800 (PST) Received: (nullmailer pid 4067861 invoked by uid 1000); Fri, 15 Jan 2021 01:37:14 -0000 Date: Thu, 14 Jan 2021 19:37:14 -0600 From: Rob Herring To: Maxime Ripard Subject: Re: [PATCH 05/19] dt-bindings: bluetooth: realtek: Switch to unevaluatedProperties Message-ID: <20210115013714.GA3798333@robh.at.kernel.org> References: <20210114113538.1233933-1-maxime@cerno.tech> <20210114113538.1233933-5-maxime@cerno.tech> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210114113538.1233933-5-maxime@cerno.tech> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210114_203717_773265_8F1491E9 X-CRM114-Status: GOOD ( 18.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jernej Skrabec , Alistair Francis , Vasily Khoruzhick , Chen-Yu Tsai , Frank Rowand , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 14, 2021 at 12:35:24PM +0100, Maxime Ripard wrote: > additionalProperties prevent any property not explicitly defined in the > binding to be used. Yet, some serial properties like max-speed are valid > and validated through the serial/serial.yaml binding. > > Let's change additionalProperties to unevaluatedProperties to avoid > spurious warnings. > > Cc: Alistair Francis > Cc: Vasily Khoruzhick > Signed-off-by: Maxime Ripard > --- > Documentation/devicetree/bindings/net/realtek-bluetooth.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml > index 4f485df69ac3..f4d4969d87f4 100644 > --- a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml > +++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml > @@ -37,7 +37,7 @@ properties: > required: > - compatible > > -additionalProperties: false > +unevaluatedProperties: false This would still fail because the serial schema is applied to the parent and this schema is applied to the child node. It's a common problem for how we've done bus schemas. We'd need to split them into 2 schemas and reference the child schema here. I'd rather not do that here because then we'd apply the schema twice assuming we keep bus schemas also applying the child schemas (which is good at least until we have schemas for *all* possible child devices). We've handled this in other cases by just doing 'max-speed: true' here. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel