From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD67EC433E0 for ; Fri, 15 Jan 2021 10:25:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BF5F224F9 for ; Fri, 15 Jan 2021 10:25:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BF5F224F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vtiLPvg3VV9o8Hu2Ph+tAj5jU8dgSTAVn0/l25/ZHXo=; b=RIzG2wNY/qCkune5+Ve/23+C/ NYGUPQ6ofivN7OfP84reKU66v5pWTYKr5yjp7Uits0ExCfqnSKK8aEdmJihzmWQFJf4R6x/TODMhM Bu95M5Kap+hDDU8IQX53kG61jPdqpvZqq8yImLiv9MrMsynoVqLbjEvH9BAJMBLgXgRpacxAuvNDT uK+Yes/jpaOTW6YAT6yTS6nLYdFhYu2PO0tBQW2+CsvSbL2lCEs6w/lCqOhwHCvdchlOmwlI8Fx2P 20dnngovAPh6i3C79g7JqCXdUtjJiboEZbTmT/zZw9FQu1YdRNlZ9yb72Y/RorMJsZMIpaR8fL07p rkdDpWF3A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l0MGf-0002VL-0a; Fri, 15 Jan 2021 10:23:45 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l0MGc-0002Uy-Ez for linux-arm-kernel@lists.infradead.org; Fri, 15 Jan 2021 10:23:43 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 621BE235F9; Fri, 15 Jan 2021 10:23:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610706221; bh=c/+XqWLmQTEyndmY4XhHmEat6eBL2W+LzNHlJg1xGlc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GQwIacPmjs/aOm4bQ1rFpzSRDHy739OTYVDLZinf3vIbt7XaORjK14OSbDSdGh6Ij 7DOaM4QxtaG0JZsU18PjC4KvQa6bGICy8UpXQw29+cxhdYimqTY9stfbshm+JhT/cf O821VSuzWQTvjgPq0kr+fXNYeQ1z207Ns8XMzOb7LQpsEu+vFr1+8V8TLI0u9i7PFs Z5bY3BeoxFG57wfFcqto6uPrpKzc3NlFGlVWKMEO+wX9/J5iLo2exKI16IJ1DGDZdB 3c4P0oFfKYtWfyHSPqCxayXwV4nWDUlKHeBadwhZArU4E9Q7ZPhnmoyQNBaIjUW+aX q5yeMNOO4fmBw== Date: Fri, 15 Jan 2021 10:23:35 +0000 From: Will Deacon To: Keqian Zhu Subject: Re: [PATCH] kvm: arm64: Properly align the end address of table walk Message-ID: <20210115102334.GA14167@willie-the-truck> References: <20210115095307.12912-1-zhukeqian1@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210115095307.12912-1-zhukeqian1@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210115_052342_878494_DEDE72C7 X-CRM114-Status: GOOD ( 16.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , jiangkunkun@huawei.com, Andrew Morton , kvm@vger.kernel.org, Suzuki K Poulose , Catalin Marinas , Joerg Roedel , Daniel Lezcano , linux-kernel@vger.kernel.org, Alexios Zavras , James Morse , Julien Thierry , Marc Zyngier , wanghaibin.wang@huawei.com, Thomas Gleixner , Robin Murphy , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 15, 2021 at 05:53:07PM +0800, Keqian Zhu wrote: > When align the end address, ought to use its original value. > > Fixes: b1e57de62cfb ("KVM: arm64: Add stand-alone page-table walker infrastructure") > Signed-off-by: Keqian Zhu > --- > arch/arm64/kvm/hyp/pgtable.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c > index bdf8e55ed308..670b0ef12440 100644 > --- a/arch/arm64/kvm/hyp/pgtable.c > +++ b/arch/arm64/kvm/hyp/pgtable.c > @@ -296,7 +296,7 @@ int kvm_pgtable_walk(struct kvm_pgtable *pgt, u64 addr, u64 size, > struct kvm_pgtable_walk_data walk_data = { > .pgt = pgt, > .addr = ALIGN_DOWN(addr, PAGE_SIZE), > - .end = PAGE_ALIGN(walk_data.addr + size), > + .end = PAGE_ALIGN(addr + size), > .walker = walker, Hmm, this is a change in behaviour, no (consider the case where both 'addr' and 'size' are misaligned)? The current code is consistent with the kerneldoc in asm/kvm_pgtable.h, so I don't see the motivation to change it. Did you hit a bug somewhere? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel