From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A28AC433DB for ; Fri, 15 Jan 2021 11:20:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E9EF2371F for ; Fri, 15 Jan 2021 11:20:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E9EF2371F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P0z11bq2RRg0DDQpj0gFUCiy6rrNkSGbIbK4nvXaxhU=; b=Gx+KOS5iT1tZoOH3WJXAJ8tdP j8JVvF90Zp+NQfHgbiQTSHFFVazMmhZANza7TVJdHUFOoY2Mx7+bln37HJBTb9ynSa+1ohlmDt5SH T6I3k1gbFSRVJ2SAE3J4WiqBWOXbuCbQRE2aW5PKAfOplrfMsfhl8uZi/b3e7qCM0zg7qPsecK11H DmHRzJuuglXraKTUGLVSUk6N2KgkskDzLPdt3nMHCTzRKzj+e46hcMdM6IekznPsc/zxZAcgI+Okx UszzDYD/sD3fKMo50FU2W+krBcZeCpKNq03gXTdRoz/5LTfdwKADjosYoLS4zrV9vdY1ZZF6nqZLD 7lpVQpOmQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l0N7s-00087v-GI; Fri, 15 Jan 2021 11:18:44 +0000 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l0N7p-00087H-Sc for linux-arm-kernel@lists.infradead.org; Fri, 15 Jan 2021 11:18:43 +0000 Received: by mail-lf1-x131.google.com with SMTP id x20so12563740lfe.12 for ; Fri, 15 Jan 2021 03:18:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=8lRJYc4BKAdg1abXpS4nArMEOY798PG8SuBDu3ZJSlk=; b=Z5AjfT+9sIEoizTRGkvN4w7h+aIbEWUFfVlvbDDmlnjohr4b0yWluxpJGKYyhP8D/V I1i0WOneHrJlvabZSEV484vqeRo06wzgYuy4/74GQxjPiexyiI2Fkm1ofKktZpg7HkEF r4ZvbU4mI0geYG/QB4JeSCJf9N8xgug1O0oF5ndx9wZAMViLLczKz9zrs25GRrbzUDEv BJMyglfRGKtxkz4nP7IGeIWrG8nPeHLzf8SGJ9CXAJE6BD9YW/chFgczD1Sznmje0srx hhkjxqAvvBo8ZwYRisJz7S9OxGneqG3bM72c4IQ6Shyld3PwIXKv9EAlWxxvF/sX+Hcn DGOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8lRJYc4BKAdg1abXpS4nArMEOY798PG8SuBDu3ZJSlk=; b=mg0o3HCjARfy4snDdiakkD+ZYo7s7gt2rvSI4LKyvBE0PUXKOZURr7MLR1bAkM6vn8 48UHoUEMUVYoMiUeRhGXb3ssqvNzKiAX+qUPhTTq5WOhDc6PBD1vBBE2La8ObISQLqR8 TWQwUHRn+g2BAm1E6X2HqFpAI3LJrKfuhptdefKELECddJvD8tWkxWWNcxlT/fYA3ACD w+2FEWUZmADfLavkF9b6MgcNKMc33iXVm1uOnJRrcrCKznvOz40vACXpj9+J9gMiJZ+n HLsz5mB/OWq9IBj3bJy55+ZLF23VfGRMvP5Dk1exGTxYHf9FAh88Vnw2STJA4T3AyCj1 fTSw== X-Gm-Message-State: AOAM5323f1rp1A6EBMLZTNDbD5i2mK5xt57sI//1yheVugl30kIckyiY cSfyw2heyn7N29DINuyj95Q= X-Google-Smtp-Source: ABdhPJzgPbg0C6JprZSQzMH73kmf9AQHoEvG+h92c+jF6B1XAfqd45EqfR1dJgICUMDoG+cffcK6Cw== X-Received: by 2002:a05:6512:3157:: with SMTP id s23mr5355726lfi.275.1610709520473; Fri, 15 Jan 2021 03:18:40 -0800 (PST) Received: from home.paul.comp (paulfertser.info. [2001:470:26:54b:226:9eff:fe70:80c2]) by smtp.gmail.com with ESMTPSA id x125sm864994lff.58.2021.01.15.03.18.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 03:18:39 -0800 (PST) Received: from home.paul.comp (home.paul.comp [IPv6:0:0:0:0:0:0:0:1]) by home.paul.comp (8.15.2/8.15.2/Debian-14~deb10u1) with ESMTP id 10FBIaNw004539; Fri, 15 Jan 2021 14:18:37 +0300 Received: (from paul@localhost) by home.paul.comp (8.15.2/8.15.2/Submit) id 10FBITBj004538; Fri, 15 Jan 2021 14:18:29 +0300 Date: Fri, 15 Jan 2021 14:18:29 +0300 From: Paul Fertser To: Ernesto Corona Subject: Re: [PATCH v29 1/6] drivers: jtag: Add JTAG core driver Message-ID: <20210115111829.GB2971@home.paul.comp> References: <20200413222920.4722-1-ernesto.corona@intel.com> <20200413222920.4722-2-ernesto.corona@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200413222920.4722-2-ernesto.corona@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210115_061842_076160_E1B2DB2A X-CRM114-Status: GOOD ( 17.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed@lists.ozlabs.org, linux-doc@vger.kernel.org, Viresh Kumar , Linus Walleij , Palmer Dabbelt , Amithash Prasad , Rgrs , Christian Gromm , Yiwei Zhang , Joel Stanley , Steven Filary , Alessandro Rubini , Kees Cook , Arnd Bergmann , William Breathitt Gray , Johan Hovold , Jiri Pirko , Jonathan Cameron , Mika Westerberg , linux-arm-kernel@lists.infradead.org, Jens Axboe , Tony Luck , Boris Brezillon , Greg Kroah-Hartman , Randy Dunlap , linux-kernel@vger.kernel.org, Patrick Williams , Federico Vaga , Oleksandr Shamray , Vadim Pasternak Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 13, 2020 at 03:29:15PM -0700, Ernesto Corona wrote: > --- /dev/null > +++ b/drivers/jtag/jtag.c > + case JTAG_SIOCFREQ: > + if (!jtag->ops->freq_set) > + return -EOPNOTSUPP; > + > + if (get_user(value, (__u32 __user *)arg)) > + return -EFAULT; Does this need to be a pointer to a variable even if it's just a number? > + case JTAG_IOCXFER: > + if (copy_from_user(&xfer, (const void __user *)arg, > + sizeof(struct jtag_xfer))) > + return -EFAULT; > + > + if (xfer.length >= JTAG_MAX_XFER_DATA_LEN) > + return -EINVAL; > + > + if (xfer.type > JTAG_SDR_XFER) > + return -EINVAL; > + > + if (xfer.direction > JTAG_READ_WRITE_XFER) > + return -EINVAL; > + > + if (xfer.endstate > JTAG_STATE_UPDATEIR) > + return -EINVAL; > + > + data_size = DIV_ROUND_UP(xfer.length, BITS_PER_BYTE); > + xfer_data = memdup_user(u64_to_user_ptr(xfer.tdio), data_size); So this might copy more bits than the user specified, but that's probably OK. > + if (IS_ERR(xfer_data)) > + return -EFAULT; > + > + err = jtag->ops->xfer(jtag, &xfer, xfer_data); > + if (err) { > + kfree(xfer_data); > + return err; > + } > + > + err = copy_to_user(u64_to_user_ptr(xfer.tdio), > + (void *)xfer_data, data_size); And this might overwrite some bits and it's not OK, at least not without a warning in the documentation. > --- /dev/null > +++ b/include/uapi/linux/jtag.h > @@ -0,0 +1,194 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +// include/uapi/linux/jtag.h - JTAG class driver uapi > +// > +// Copyright (c) 2018 Mellanox Technologies. All rights reserved. > +// Copyright (c) 2018 Oleksandr Shamray > + > +#ifndef __UAPI_LINUX_JTAG_H > +#define __UAPI_LINUX_JTAG_H > + Missing Other API comments will be sent as a reply to the "Documentation: jtag: Add ABI documentation" patch as they are not implementation-specific. -- Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software! mailto:fercerpav@gmail.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel