From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E140AC433E0 for ; Sat, 16 Jan 2021 00:53:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8EFC720776 for ; Sat, 16 Jan 2021 00:53:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8EFC720776 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uyU9eOUo6Jhy3GPm+6WEqDScnPnO4Q9k45x0tgf4dGE=; b=tYVvhmByKjPjOobEsSeFqi53O 4CxEAoeGPLlu1Fzf23BQLl24R/LwH1Z1mlwbmBVN+kbKw/VS0x+GkRpdiB8Aeb6XIPsdyoAFONQyd DZdGbf1HdzWQKFQzcUNZohPN+zrUSizCSoI/IwfnSd/i1OaXvQ7cKvUNzP5100z2CLF7Xj8y9uFsR if4qrSNsM4bos85EDEvyOSSoJBmmWqy/Cf2JXCUTfj0EuqM2cFFnF50G7SqEpv9LZSEOAsafTUlLc Ce87KSTSuAViTJrdBkXMRekz3kVQd2Jx5geH3mJqOmaXUD2TFUG1qBmYvqW/kl9eFmuapYZzdHCWW 7NYojzNOg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l0Zo9-00018K-M2; Sat, 16 Jan 2021 00:51:13 +0000 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l0Zo7-00017i-BG for linux-arm-kernel@lists.infradead.org; Sat, 16 Jan 2021 00:51:12 +0000 Received: by mail-pg1-x531.google.com with SMTP id i5so7106900pgo.1 for ; Fri, 15 Jan 2021 16:51:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ewFYxtYqPNzg40mZBd2AGRSAZFUjPc2qJGU6EIbYFbk=; b=Rog7Hfpy0pXP7D9eH7CFOkTZWlpSYobXdMpzim/AvTmeEAK644nGkmDhjBpwJ6VijO Rk9UDldD1GDcD/pMbMF/oBKpcBlQg5513muIYpyEfrjEQ56ojwX2VaoTdfNpYPT4/ljZ TbX5PCxlY23BsnE25htdmmfpHsthaSWsRQmsedoHMpUTAPnAgkACx6yEC4ILdWZF7v5L 5U5O8UXtn2dglxyeK5kBG/4cb/9YRY1uKnnOIiUFQhaum2Ziv0VtqreQE/AUfKynwegd P7N8FdaNmjmhpwPtHrGjJn2MDE2JMaFt80nqoFx4J0ZO/vytGr3Ze8wC2kxZWXESO/hG +1nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ewFYxtYqPNzg40mZBd2AGRSAZFUjPc2qJGU6EIbYFbk=; b=l1JNffnW4RcIyQ+ook+vAGU4iQWLMFA5TPstVuL+zNpP7FjNbIdx1MdLg+LlpExrUK MWfqUCUBlAX73sZuoTIEgVUsKZLsXxeTroqYt+uLrw7Svd0hvA0st4P+h2cS0/gyqNv4 CWrMv/4Gu8Bp9EaJ+kOAWDOCFg+9oAcu/EhvnuOLH+dZUanhk6PJDOboRfPgyIS5zD66 0oLfeRXoufoDHLRgomeQuFKOxdI6DVQxRviq+C4Bqy0/75zemNWsdU5ey53cGsfUaUO3 W9XBwpVOVGfH7YgrMMW2pDtLH/IGGK18P2Y5EnSZiIRUP0CHgFLyx7YiZjOstXVjzsUa V5Qw== X-Gm-Message-State: AOAM531tSSwmnTfyF5ijQZO99Dqqj40kW2S/1NVh+bxIwFSrvqYbuGXm ubTsKUPL/90PjoSPPakitG6/ew== X-Google-Smtp-Source: ABdhPJw3wAHlVjBdHOhDOvq8ZnBqcG/OrKvEEmnyJueNo8Dju6G+4cLk1irhR3gxapaiPg2Hogsdeg== X-Received: by 2002:a63:1c13:: with SMTP id c19mr15034301pgc.359.1610758269076; Fri, 15 Jan 2021 16:51:09 -0800 (PST) Received: from leoy-ThinkPad-X240s ([45.137.216.7]) by smtp.gmail.com with ESMTPSA id c24sm9097502pgi.71.2021.01.15.16.50.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 16:51:08 -0800 (PST) Date: Sat, 16 Jan 2021 08:50:46 +0800 From: Leo Yan To: Mathieu Poirier Subject: Re: [PATCH v1 3/7] perf cs-etm: Calculate per CPU metadata array size Message-ID: <20210116005046.GB5418@leoy-ThinkPad-X240s> References: <20210109074435.626855-1-leo.yan@linaro.org> <20210109074435.626855-4-leo.yan@linaro.org> <96ec434e-4103-02ac-a05a-761a9ca8cb0d@arm.com> <20210115224658.GC375055@xps15> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210115224658.GC375055@xps15> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210115_195111_544953_D3766A1C X-CRM114-Status: GOOD ( 15.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Denis Nikitin , Suzuki K Poulose , Alexander Shishkin , Jiri Olsa , Coresight ML , John Garry , Linux Kernel Mailing List , Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Namhyung Kim , Daniel Kiss , Will Deacon , linux-arm-kernel , Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mathieu, On Fri, Jan 15, 2021 at 03:46:58PM -0700, Mathieu Poirier wrote: > On Mon, Jan 11, 2021 at 12:09:12PM +0000, Mike Leach wrote: > > Hi Leo, > > > > I think there is an issue here in that your modification assumes that > > all cpus in the system are of the same ETM type. The original routine > > allowed for differing ETM types, thus differing cpu ETM field lengths > > between ETMv4 / ETMv3, the field size was used after the relevant > > magic number for the cpu ETM was read. > > > > You have replaced two different sizes - with a single calculated size. > > I usually go through an entire patchset before looking at the comments people > have made. In this case Mike and I are coming to the exact same conclusion. Agreed, now this work depends on Mike's patch for extending metadata version; otherwise if without Mike's patch, it will cause compability issue. > I will look at Mike's patch on Monday. Cool! Thanks for review, Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel