From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01689C433DB for ; Sun, 17 Jan 2021 12:33:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A48322071C for ; Sun, 17 Jan 2021 12:33:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A48322071C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ziS7PHsdJqxfOcQ3W5t45jInszomi/y+MGWyi2k+o7Y=; b=2wngYZvKZnbZLNjb3OGVGAqib AFcifdz41NK2yJsXNRV/U2BbBF01/BTOD76wPzJn3O/rATHG/Lj1pBYmkhoA1uFFQsg/0eVUd3e+L 2QbM5HaysZiSLwbSM7FLMseYo+mgP6bJOfsHSiT2Qkq0gkoWtTg5vO7wBH9jG7JP6x6vihfA2u9nI FdDbjjfpOL2+3JoDAKeS+hQ7H7LJrWPf+I9pcPVH4t9LZO+nBdQMi2/Pw/N8ZczMPOEF1DIsqiq2w eiA4zskvSSwOpWmQQHaJrPsXfCKef6iCjwBvXoRnTw3bOqJ5sBl6yU6C4+FG4YjFHaTLoNtOOu/mf //queoaYA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l17E5-0005ah-K9; Sun, 17 Jan 2021 12:32:13 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l17Dy-0005aM-Oc for linux-arm-kernel@lists.infradead.org; Sun, 17 Jan 2021 12:32:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=8e6P4e4r6+AKhJrE2VvxLl9qFnamXpQq5A5kpWB46vA=; b=kXTujY6TE57BFnQKOeXPuKunr E0hiAoVYxFCl55F+2Vcq6NxaN2zr2bRfdQu+qBWuugsgqGHpkh6dw5I68U7soOngQxR7Q+1wMVBwF /EaKmR0nboaIK3etb5RQ9uJnVnBR5EHPa6RVHbvuQLjpEDX0Y7I0nWIJnvVXmby24b3ioKAO6ggjQ KsTBq5cRPZ3ozE5bY6AyBON9U0Q8kWoaSOEG9yfVxj9J1CMitjCz0e0p1WYFyG3eOG3wz4QI/cewF gm74P+QBdqg6/ctFsl3CT5i7Mvc4u6J5kXOFaiYfWajCiAiQRsSuG3H3+T+pwUG3j7uVqWepapgr9 RWV32clTg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:49124) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l17Dt-0005TK-1e; Sun, 17 Jan 2021 12:32:01 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1l17Dr-0002yC-Ll; Sun, 17 Jan 2021 12:31:59 +0000 Date: Sun, 17 Jan 2021 12:31:59 +0000 From: Russell King - ARM Linux admin To: Shawn Guo Subject: Re: [PATCH V2] ARM: imx: add smp support for imx7d Message-ID: <20210117123159.GC1551@shell.armlinux.org.uk> References: <20210107123157.121282-1-marex@denx.de> <20210117114617.GT28365@dragon> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210117114617.GT28365@dragon> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210117_073206_824790_7CE33141 X-CRM114-Status: GOOD ( 22.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Arulpandiyan Vadivel , Anson Huang , Leonard Crestez , Fabio Estevam , linux-arm-kernel@lists.infradead.org, NXP Linux Team Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jan 17, 2021 at 07:46:20PM +0800, Shawn Guo wrote: > On Thu, Jan 07, 2021 at 01:31:57PM +0100, Marek Vasut wrote: > > From: Anson Huang > > > > Add SMP support for i.MX7D, including CPU hotplug support, for > > systems where TFA is not present. > > > > The arm,cpu-registers-not-fw-configured is required, otherwise the > > timer does not work correctly. > > As DT change becomes another patch, this should be dropped. > > > > > Signed-off-by: Anson Huang > > Signed-off-by: Arulpandiyan Vadivel # Fix merge conflicts > > Signed-off-by: Leonard Crestez > > Signed-off-by: Marek Vasut # heavy cleanup > > Checkpatch warnings: > > WARNING: usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc > #151: FILE: arch/arm/mach-imx/platsmp.c:108: > + for (i = ncores; i < NR_CPUS; i++) False. This is initialising the cpu possible map, so can't use cpu_possible(). > > +void imx_gpcv2_set_m_core_pgc(bool enable, u32 offset) > > static inline? Only "static" not "static inline" in a .c file. > > +void __init imx7_src_init(void) > > +{ > > + struct device_node *np; > > + gpr_v2 = true; > > + > > + np = of_find_compatible_node(NULL, NULL, "fsl,imx7d-src"); > > + if (!np) > > + return; > > + src_base = of_iomap(np, 0); > > + WARN_ON(!src_base); > > Don't we need of_node_put()? I always worry about this. The resources of the node remains in use after the initialisation function has completed, so why _shouldn't_ the node also have a reference to it - in the same way that any bound driver effectively maintains a reference on its DT node for its lifetime. The only difference is that system devices such as this have a lifetime of the system. It's not like you could drop the "fsl,imx7d-src" node at runtime and the system will do the right thing. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel