From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0698C433E0 for ; Sun, 17 Jan 2021 12:36:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A369D206F4 for ; Sun, 17 Jan 2021 12:36:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A369D206F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qic5M7ugM7cqTQQxp72kMJQhzc1IgA/G9Adw0EhKKYE=; b=QJln+LZhlXMM95PVe4PovCLbC 5q4Cj6EMj+Dn9BsluXbS5I75j8AoGs3ws44gnfDNuznRcmNYz4oHp5AAlpccEJw0kkcVsxUU+mBum gQjhhPNj4U2pJHJkxCfa0qGeG5ZN+1firn8+1+HxnIWyOOoLEi6ny0YLmGDKLEg7k2TzC/55frRca BgO4U8l4hs833V/NtKtVOpZVlM4GNro9d0PExWHKjve4G2XnRaJY9EujFHJ1ya3mPcwAsGdrh0xbV 7t8Gf1trdBDopZo9/aBcY89h3u/L3O2WdiJSzM7tRxyW3EA/rvGX7VnG3nQx/cRAGH4Va72V0J8Ad PonQIZnxw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l17Gh-0005js-1L; Sun, 17 Jan 2021 12:34:55 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l17Ge-0005jN-2m for linux-arm-kernel@lists.infradead.org; Sun, 17 Jan 2021 12:34:52 +0000 Received: from archlinux (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 448A0206F4; Sun, 17 Jan 2021 12:34:49 +0000 (UTC) Date: Sun, 17 Jan 2021 12:34:42 +0000 From: Jonathan Cameron To: Xu Wang Subject: Re: [PATCH] iio: adc: stm32-dfsdm: Remove redundant null check before clk_disable_unprepare Message-ID: <20210117123442.5156a509@archlinux> In-Reply-To: <20201231085322.24398-1-vulab@iscas.ac.cn> References: <20201231085322.24398-1-vulab@iscas.ac.cn> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210117_073452_219208_0BD75834 X-CRM114-Status: GOOD ( 17.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, krzk@kernel.org, bobo.shaobowang@huawei.com, andy.shevchenko@gmail.com, mcoquelin.stm32@gmail.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, alexandre.torgue@st.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 31 Dec 2020 08:53:22 +0000 Xu Wang wrote: > ecause clk_disable_unprepare() already checked NULL clock parameter, > so the additional check is unnecessary, just remove it. > > Signed-off-by: Xu Wang Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to see if we missed anything. thanks, Jonathan > --- > drivers/iio/adc/stm32-dfsdm-core.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c > index 42a7377704a4..bb925a11c8ae 100644 > --- a/drivers/iio/adc/stm32-dfsdm-core.c > +++ b/drivers/iio/adc/stm32-dfsdm-core.c > @@ -117,8 +117,7 @@ static void stm32_dfsdm_clk_disable_unprepare(struct stm32_dfsdm *dfsdm) > { > struct dfsdm_priv *priv = to_stm32_dfsdm_priv(dfsdm); > > - if (priv->aclk) > - clk_disable_unprepare(priv->aclk); > + clk_disable_unprepare(priv->aclk); > clk_disable_unprepare(priv->clk); > } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel