linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, andrew@lunn.ch,
	linux-imx@nxp.com, kernel@pengutronix.de
Subject: Re: [PATCH 4/4] ARM: dts: imx6ul-14x14-evk: Add camera support
Date: Mon, 18 Jan 2021 08:11:19 +0800	[thread overview]
Message-ID: <20210118001118.GY28365@dragon> (raw)
In-Reply-To: <20210107235044.7897-4-festevam@gmail.com>

On Thu, Jan 07, 2021 at 08:50:44PM -0300, Fabio Estevam wrote:
> Add support for the OV5640 parallel camera module.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 43 ++++++++++++++++++++++++-
>  1 file changed, 42 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
> index ac2ec96f54e7..ad039821a767 100644
> --- a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
> +++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
> @@ -146,6 +146,41 @@
>  		reg = <0x1a>;
>  		wlf,shared-lrclk;
>  	};
> +
> +	camera@3c {
> +		compatible = "ovti,ov5640";
> +		reg = <0x3c>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_camera_clock>;
> +		clocks = <&clks IMX6UL_CLK_CSI>;
> +		clock-names = "xclk";
> +		powerdown-gpios = <&gpio_spi 6 GPIO_ACTIVE_HIGH>;
> +		reset-gpios = <&gpio_spi 5 GPIO_ACTIVE_LOW>;
> +
> +		port {
> +			ov5640_to_parallel: endpoint {
> +				remote-endpoint = <&parallel_from_ov5640>;
> +				bus-width = <8>;
> +				data-shift = <2>; /* lines 9:2 are used */
> +				hsync-active = <0>;
> +				vsync-active = <0>;
> +				pclk-sample = <1>;
> +			};
> +		};
> +	};
> +};
> +
> +&csi {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_csi1>;
> +	status = "okay";
> +
> +	port {
> +		parallel_from_ov5640: endpoint {
> +			remote-endpoint = <&ov5640_to_parallel>;
> +			bus-type = <5>; /* Parallel bus */
> +		};
> +	};
>  };
>  
>  &fec1 {
> @@ -353,9 +388,15 @@
>  &iomuxc {
>  	pinctrl-names = "default";
>  
> -	pinctrl_csi1: csi1grp {
> +	pinctrl_camera_clock: cameraclockgrp {
>  		fsl,pins = <
>  			MX6UL_PAD_CSI_MCLK__CSI_MCLK		0x1b088
> +		>;
> +	};
> +
> +	pinctrl_csi1: csi1grp {
> +		fsl,pins = <
> +

Unneeded newline.

Fixed it up and applied.

Shawn

>  			MX6UL_PAD_CSI_PIXCLK__CSI_PIXCLK	0x1b088
>  			MX6UL_PAD_CSI_VSYNC__CSI_VSYNC		0x1b088
>  			MX6UL_PAD_CSI_HSYNC__CSI_HSYNC		0x1b088
> -- 
> 2.17.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-01-18  0:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-07 23:50 [PATCH 1/4] ARM: dts: imx6ul-14x14-evk: Fix SPI chipselect polarity Fabio Estevam
2021-01-07 23:50 ` [PATCH 2/4] ARM: dts: imx6ul-14x14-evk: Enable the GPIO expander Fabio Estevam
2021-01-08  1:02   ` Andrew Lunn
2021-01-18  0:10   ` Shawn Guo
2021-01-07 23:50 ` [PATCH 3/4] ARM: dts: imx6ul-14x14-evk: Describe the KSZ8081 reset Fabio Estevam
2021-01-08  1:03   ` Andrew Lunn
2021-01-18  0:10   ` Shawn Guo
2021-03-10 11:04   ` Joakim Zhang
2021-03-11 11:33     ` Joakim Zhang
2021-03-11 14:17       ` Andrew Lunn
2021-03-12  2:02         ` Joakim Zhang
2021-03-12 11:34       ` Fabio Estevam
2021-01-07 23:50 ` [PATCH 4/4] ARM: dts: imx6ul-14x14-evk: Add camera support Fabio Estevam
2021-01-18  0:11   ` Shawn Guo [this message]
2021-01-18  0:09 ` [PATCH 1/4] ARM: dts: imx6ul-14x14-evk: Fix SPI chipselect polarity Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210118001118.GY28365@dragon \
    --to=shawnguo@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).