From: Shawn Guo <shawnguo@kernel.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: kernel@puri.sm, devicetree@vger.kernel.org, festevam@gmail.com,
linux-kernel@vger.kernel.org, krzk@kernel.org, linux-imx@nxp.com,
kernel@pengutronix.de, catalin.marinas@arm.com, will@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/9] arm64: dts: imx8mq-librem5: enable the LCD panel
Date: Mon, 18 Jan 2021 15:02:42 +0800 [thread overview]
Message-ID: <20210118070241.GL28365@dragon> (raw)
In-Reply-To: <20210112095151.4995-7-martin.kepplinger@puri.sm>
On Tue, Jan 12, 2021 at 10:51:48AM +0100, Martin Kepplinger wrote:
> This enables the Librem5's ft8006p based LCD panel driven by the
> imx8mq's Northwest Logic DSI IP core and mxsfb display controller.
>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
> .../boot/dts/freescale/imx8mq-librem5.dtsi | 51 ++++++++++++++++++-
> 1 file changed, 49 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> index f77b51d3c132..440931f81c12 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -310,6 +310,17 @@
> >;
> };
>
> + pinctrl_dsirst: dsirstgrp {
> + fsl,pins = <
> + /* DSI_RST */
> + MX8MQ_IOMUXC_ENET_RD3_GPIO1_IO29 0x83
> + /* DSI_TE */
> + MX8MQ_IOMUXC_ENET_RD2_GPIO1_IO28 0x83
> + /* TP_RST */
> + MX8MQ_IOMUXC_ENET_RX_CTL_GPIO1_IO24 0x83
> + >;
> + };
> +
> pinctrl_ecspi1: ecspigrp {
> fsl,pins = <
> MX8MQ_IOMUXC_ECSPI1_MOSI_ECSPI1_MOSI 0x83
> @@ -817,12 +828,12 @@
> compatible = "tps65132";
> reg = <0x3e>;
>
> - outp {
> + reg_lcd_avdd: outp {
> regulator-name = "LCD_AVDD";
> vin-supply = <®_lcd_3v4>;
> };
>
> - outn {
> + reg_lcd_avee: outn {
> regulator-name = "LCD_AVEE";
> vin-supply = <®_lcd_3v4>;
> };
> @@ -947,6 +958,42 @@
> };
> };
>
> +&lcdif {
> + status = "okay";
> +};
> +
> +&mipi_dsi {
> + status = "okay";
> + #address-cells = <1>;
> + #size-cells = <0>;
Please end property list with `status`.
> +
> + lcd_panel: panel@0 {
> + compatible = "mantix,mlaf057we51-x";
> + reg = <0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_dsirst>;
> + avdd-supply = <®_lcd_avdd>;
> + avee-supply = <®_lcd_avee>;
> + vddi-supply = <®_lcd_1v8>;
> + backlight = <&backlight_dsi>;
> + reset-gpios = <&gpio1 29 GPIO_ACTIVE_LOW>;
Have a newline between properties and child node.
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&mipi_dsi_out>;
> + };
> + };
> + };
> +
> + ports {
> + port@1 {
> + reg = <1>;
Ditto
Shawn
> + mipi_dsi_out: endpoint {
> + remote-endpoint = <&panel_in>;
> + };
> + };
> + };
> +};
> +
> &pgc_gpu {
> power-supply = <&buck3_reg>;
> };
> --
> 2.20.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-18 7:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 9:51 [PATCH 0/9] Config and devicetree updates for the Librem 5 phone Martin Kepplinger
2021-01-12 9:51 ` [PATCH 1/9] arm64: defconfig: Enable vibra-pwm Martin Kepplinger
2021-01-13 4:15 ` Krzysztof Kozlowski
2021-01-12 9:51 ` [PATCH 2/9] arm64: dts: imx8mq-librem5: Mark charger IRQ as High-Z Martin Kepplinger
2021-01-13 4:16 ` Krzysztof Kozlowski
2021-01-12 9:51 ` [PATCH 3/9] arm64: dts: imx8mq-librem5: Don't mark buck3 as always on Martin Kepplinger
2021-01-12 9:51 ` [PATCH 4/9] arm64: dts: imx8mq-librem5: Add usb-c chip as supplier for the charger Martin Kepplinger
2021-01-12 9:51 ` [PATCH 5/9] arm64: dts: imx8mq-librem5: Add LCD_1V8 regulator Martin Kepplinger
2021-01-12 9:51 ` [PATCH 6/9] arm64: dts: imx8mq-librem5: enable the LCD panel Martin Kepplinger
2021-01-18 7:02 ` Shawn Guo [this message]
2021-01-12 9:51 ` [PATCH 7/9] arm64: dts: imx8mq-librem5: set regulators boot-on Martin Kepplinger
2021-01-12 9:51 ` [PATCH 8/9] arm64: dts: Add Librem5 Evergreen Martin Kepplinger
2021-01-13 4:21 ` Krzysztof Kozlowski
2021-01-12 9:51 ` [PATCH 9/9] dt-bindings: arm: fsl: Add the librem 5 Evergreen revision Martin Kepplinger
2021-01-13 4:22 ` Krzysztof Kozlowski
2021-01-14 20:15 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210118070241.GL28365@dragon \
--to=shawnguo@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.kepplinger@puri.sm \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).