From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48A44C433E0 for ; Mon, 18 Jan 2021 11:15:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADDE822B48 for ; Mon, 18 Jan 2021 11:15:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADDE822B48 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CHYrlfh25P2cNjK9zWvQWf2g031ezABp6a3duujkqD8=; b=K3vF8iECdzd67zuJ3HxWF0imv Pjo1tCmzpjTvVSw+KgcS1taqeJPu57W8O/QzOnKJI4wUMp9vFQ5BQLnHJ0h/U/76yTVDsmzfPLpY8 XMNAFnX6Jp07lYXbND8eJSoAfv7RS14pkb+GvHtWY2w1qWbXle5E/xu8cYNSKiti5dQwkzokE59AR N9AfoopG2OIFfgdjJ0Qys5iMwVwM3xeEcJ6WxXDm166Vc5H6YtrxshylNSj+3VXZJyncVapvy+nS8 OFphFyI1TPIgMwH5Mbggd6olN0KpyMRybUyHkuAcg86iXasDAZ44oNO46SQsDXT0P8it1WezwjvGp NHk7poq2w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1STi-00040j-VE; Mon, 18 Jan 2021 11:13:47 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1STh-00040H-1Q for linux-arm-kernel@lists.infradead.org; Mon, 18 Jan 2021 11:13:45 +0000 Received: by mail-wm1-x32b.google.com with SMTP id v184so9200839wma.1 for ; Mon, 18 Jan 2021 03:13:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fLMG4vsTzbqzDa7NYZTtEssmDNdJhpiTjSVtjAKlEtA=; b=bYq5xCIxzjmV299kxFOaCiB/AS3jxa624Jqc6YIZmywPF0VJLTMwG3jbAp3Rl307/k hbfiB4H9mXbxETPI4v+GT1gwFHDX70mGRsQar2IpJ2FKIAKHJvFWzRMFchybki6gBfPB 6p7Z5e/42vPSZqedt7jpJtu9+gZwqSj8cfxt/JH2KRt19eCGYArh3kvHtA9a7qRIRLL8 b+nazIab6dctS0iZyKhVbpkE8mb0EMfLHaKpgyBxCulmhIYnf5VVvq5LCDBvM/gkb6AL 2M3nAOmJjcBr9iah49+H/XndkzN8NpGh9ij+ij8wEH6swOnsfecHixfdPAc94g17XTIC z6bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fLMG4vsTzbqzDa7NYZTtEssmDNdJhpiTjSVtjAKlEtA=; b=R1jh5JquYDoNgR04LauMcbptK562MdsoAMXRRdPxY6170l5ViX3LJNrt87CBENyuzS Ma5GtwwV5blezcEV/+2eHSZ0UCPRtia1oHS8w2aGXCJKL6alqk5idUqQU8KOZAtaW35D QA9MRvKaJ2sIugOPvOHx3oR/+GRFOJjGXv34iOa6b8blC9I5hJaK0JcF1CFL1avs1YeR QTE4bk2qGKGE2DlI3Ipvyoo3cDNHQzFFAAq/sveCmJ9MjHjGvq8GRQtiO6T5CKSxk1dG Y3eGd7O1FdoVsT4+OdO32TO6UUYGcIbX+bBLDc5RsvOT9EA9j0ylCkeZe2hXxpjqM/iv poxw== X-Gm-Message-State: AOAM5310rXbTG/oxKTtlQwbJ0TBjaCfLppY2r9dAwe5kCcetpD5OzYer J1ayWsxXHtF/cwP4xfmmq/L2Jml+wsqR8g== X-Google-Smtp-Source: ABdhPJzf9c0SbOFn9Oq6MnmHnjRdRnsDCTN+qFk/yY+z+IA/dnEfzlcf743XMJ3WHiVu6gPS86334Q== X-Received: by 2002:a1c:e055:: with SMTP id x82mr19724434wmg.185.1610968423194; Mon, 18 Jan 2021 03:13:43 -0800 (PST) Received: from google.com ([2a01:4b00:8523:2d03:3d4d:985d:87b7:4d55]) by smtp.gmail.com with ESMTPSA id b7sm28398175wrv.47.2021.01.18.03.13.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jan 2021 03:13:42 -0800 (PST) Date: Mon, 18 Jan 2021 11:13:41 +0000 From: David Brazdil To: Marc Zyngier Subject: Re: [PATCH v4 01/21] arm64: Fix labels in el2_setup macros Message-ID: <20210118111341.porgvi56bzqlt36v@google.com> References: <20210118094533.2874082-1-maz@kernel.org> <20210118094533.2874082-2-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210118094533.2874082-2-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210118_061345_178372_36608967 X-CRM114-Status: GOOD ( 14.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Jing Zhang , kernel-team@android.com, Srinivas Ramana , Suzuki K Poulose , Catalin Marinas , Alexandru Elisei , linux-kernel@vger.kernel.org, Ard Biesheuvel , James Morse , Julien Thierry , Ajay Patil , Prasad Sodagudi , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 18, 2021 at 09:45:13AM +0000, Marc Zyngier wrote: > If someone happens to write the following code: > > b 1f > init_el2_state vhe > 1: > [...] > > they will be in for a long debugging session, as the label "1f" > will be resolved *inside* the init_el2_state macro instead of > after it. Not really what one expects. > > Instead, rewite the EL2 setup macros to use unambiguous labels, > thanks to the usual macro counter trick. > > Acked-by: Catalin Marinas > Signed-off-by: Marc Zyngier > --- > arch/arm64/include/asm/el2_setup.h | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) Acked-by: David Brazdil _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel