From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CCD8C433E6 for ; Mon, 18 Jan 2021 15:33:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1748022285 for ; Mon, 18 Jan 2021 15:33:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1748022285 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=p/B1pIg8/GL1dMrtbwtLcf5PiZizFOLBx6syrp5IAu8=; b=ixsRjfajuuIytA0PWemjEprK5 7N4oerNRSfFfQlAiWVMu+yk4xLKrJEJyeQmxDnCzIV3eZW2zUm2Xhje3k9hh1m0qUVQuLuK+fjXIz 823UnM8oGl3WhIsafAQdJ0og85OF3LCcNZjUHoyB8x23Vtpn5EUARZu7XkbfFnWolt8nFIgvzz9uS iuqDQ9/nUIxF2JJJl9Ptw5We5KKfiWfv6iJjhDSWtW4K9yBx0JR0sjYD0YGppPMXwu4aWDZeNnrLt BMK2JgHv+iYmEOdP6wcGqgbWhi+pZWJP1+E4oEcm5uvOWcwu9c8+iyR97K76HsABrNDM/YfkqJqYs KIT9Y3wYA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1WW7-0005NL-Bv; Mon, 18 Jan 2021 15:32:31 +0000 Received: from new1-smtp.messagingengine.com ([66.111.4.221]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1WW5-0005Mg-Ik for linux-arm-kernel@lists.infradead.org; Mon, 18 Jan 2021 15:32:30 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 3DD6A5806D8; Mon, 18 Jan 2021 10:32:29 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 18 Jan 2021 10:32:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=Xzr7TivAzMC37jEbdiY5yCBTlnd X/w6i4c7bmvz68ew=; b=N8JL4nEVZlGYfJc8Ut+oe8MAM0Ws2eCWVuqJ1N2uRlz W4UrF9nOFhPI2eghR7pU4VXaNExy9mFfbs+GP44QnmMvOzPJNT0Tm1XF2F1q26sg hh1g2qnEBmY5t95iW5d5ZZkwvGl/I73v/zBqtngCj0H9cS04VXErvCRBX6WFm0iM DfVT+71OBAtS5YtzftoN53pqs9THXwIKXu0ga9vV7Qza4fdWIuG4YR8OOLHCKOFO 5e4HKpkkhCLabbSxv8+TrMbgkrc3YaIU2tRFXNZYRfTVXcYtP8IxgymT/UZSr6cn cvOrjsuKJP/nJYmV5EiJG7gukEswc55dq1BS5fjYrPQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Xzr7Ti vAzMC37jEbdiY5yCBTlndX/w6i4c7bmvz68ew=; b=BbXgA9KJ08hHHNvUq1bdHD l+5htAg9ZdNM/CmG14HdBRgCROauL43aYSvzekaiFr9A2XKxN4fYiferqBSlMHYM VJYAw8MK6F85ta4fxJ0YSfRYjSthDDm1van9BuMtf2qLccdFrd1qlXLujEWC4arJ KNVBj//L9YEQUvvMhHZdFa1JOhSF+gwrkRgg7uqa6O2xJfTt06nb2Y6Zfc2lcZzJ lfx/VrtESf/TR5AspcrhcpCliDTlR3mh7GcqkhK8P7SMl3ptebLnTc3l4UYxrY4T Co95LjJkJwYHLIvZtdHzhIMHxxC2kwBFsXeaIYcGR8lwNrFs0c6dyPlh2lIkLQyQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrtdekgdejkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 8707B240064; Mon, 18 Jan 2021 10:32:27 -0500 (EST) Date: Mon, 18 Jan 2021 16:32:26 +0100 From: Maxime Ripard To: Andre Przywara Subject: Re: [PATCH v3 13/21] phy: sun4i-usb: Rework HCI PHY (aka. "pmu_unk1") handling Message-ID: <20210118153226.3qthltiknhjggdlq@gilmour> References: <20210118020848.11721-1-andre.przywara@arm.com> <20210118020848.11721-14-andre.przywara@arm.com> MIME-Version: 1.0 In-Reply-To: <20210118020848.11721-14-andre.przywara@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210118_103229_697655_D329B01E X-CRM114-Status: GOOD ( 10.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Vinod Koul , Samuel Holland , Yangtao Li , Linus Walleij , linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Chen-Yu Tsai , =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Shuosheng Huang , linux-arm-kernel@lists.infradead.org, Icenowy Zheng Content-Type: multipart/mixed; boundary="===============6866021858863887997==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6866021858863887997== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pqgdlaxdbu6tssef" Content-Disposition: inline --pqgdlaxdbu6tssef Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 18, 2021 at 02:08:40AM +0000, Andre Przywara wrote: > As Icenowy pointed out, newer manuals (starting with H6) actually > document the register block at offset 0x800 as "HCI controller and PHY > interface", also describe the bits in our "PMU_UNK1" register. > Let's put proper names to those "unknown" variables and symbols. >=20 > While we are at it, generalise the existing code by allowing a bitmap > of bits to clear, to cover newer SoCs: The A100 and H616 use a different > bit for the SIDDQ control. >=20 > Signed-off-by: Andre Przywara Acked-by: Maxime Ripard maxime --pqgdlaxdbu6tssef Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYAWqCgAKCRDj7w1vZxhR xcbsAP9TwrjweNf+Pb49jnnhspbSAKEDPVbjl51uEuE/KYOpuAEAgi9QIlVrNs71 7VP8kIixtlUEeJFvDXJ74Aq643qmiAM= =hfin -----END PGP SIGNATURE----- --pqgdlaxdbu6tssef-- --===============6866021858863887997== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6866021858863887997==--