From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA352C433DB for ; Mon, 18 Jan 2021 15:34:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85A6D2231F for ; Mon, 18 Jan 2021 15:34:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85A6D2231F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IVnT1EFX6jUgHEXCZzw+Qe+9Pnj7SPnQT4S7m3a0lI0=; b=a78L5eA0AQckX0HytvKqpFYCL x+SD6zvazJWR2tSJG7vTeHl7pMQxaWI3B4o+DCO3y72Xq/OtP4KHybOr7nx7qfWumtqhHkCOh4tZN 6eWW3yxrw5NWCE1IKawWXKJQp6i0Me4BNlnLDDJqP93NTSnTvNAci1imTCCTzlUqDsoUzKkYZ03JN YzhkVPr+2PPbWPGe7Hf9/7VyVmsh/Jr/cYOS1vfsFiDklv+HXHjKa2IhdBDJhKyPid0ylJNZ6HXcE xjM23SgsQzZtV3uOxaXf2CfZlfDiNcdaicLkESI3oNslqxwfjpZwOAP9XXJh/XTJ++EiFzqhOSLhd /JX2y6GUg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1WX6-0005ao-7z; Mon, 18 Jan 2021 15:33:32 +0000 Received: from new1-smtp.messagingengine.com ([66.111.4.221]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1WX3-0005a5-7X for linux-arm-kernel@lists.infradead.org; Mon, 18 Jan 2021 15:33:30 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id B9B2E580779; Mon, 18 Jan 2021 10:33:28 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 18 Jan 2021 10:33:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=pJ156Jbce4QNGr49mKfGsQNR4eC aEDZTREQ5pf0KrJk=; b=bkKjlbaj57bQBuRtXm6cS0L6vrNZIFWJ4VJDo3RSf2C yXkD4ocU7/u55uOvIgyHCEwIrDULJKoK8IrfZj3qIf8KwcGjMHFgae3oToI6jLes +Euuet4BB43pvUHxMlJghS4w23QEwCnj8B9Xq+Caow3rX/0jw0vbUeYQ6h3DdHLc KO+r6s2W+He6RKJPXObMt7TLDKbg9M+gs76NWRV+U3qvFzSSjHJbqU6qzYrHIskv JDnLZq2BN8XHIfOk0SbFX6/p4M75vlje936HQ1PRzdbHvd9iMQy22f2K88zs+gYE oWf6L066K4QOoSGaDRgysrYJXBRO/3+kC/jCkF98yzQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=pJ156J bce4QNGr49mKfGsQNR4eCaEDZTREQ5pf0KrJk=; b=BOncumW2Eg5zr/G3oV2hk9 BO2oQevqVYqS8nuUEwX8z30E6QcSR1iVhaYK1iLc4yDMFMGfrNtLow4B2n6zJkni cb8B9K7u+oQihmQ07/e2Wfyr5XhZ/3JA1KsvjgPjP9BWLz9erTZ+UJNoqKmbasZj w5b8JspKiCxUzIGsWmQLooFpA7YPAnKVULRbSTwRfEwL78lRin+gXhGh9f0lPK+3 /NDibBLbkkGn2EjwgLhpTS8vbEBn/DZaeWNEWByDXr8PR01b/XFRT4wYAOxV7a0C Bub2qFg0VzGNIlaPHvnYC8+Ngtzb/q1XAUHQ3Awj1dpYpjK99+uCWy0id0CCevqQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrtdekgdejkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id BF35824005C; Mon, 18 Jan 2021 10:33:26 -0500 (EST) Date: Mon, 18 Jan 2021 16:33:25 +0100 From: Maxime Ripard To: Andre Przywara Subject: Re: [PATCH v3 14/21] dt-bindings: usb: Add H616 compatible string Message-ID: <20210118153325.pilglx5m767qronv@gilmour> References: <20210118020848.11721-1-andre.przywara@arm.com> <20210118020848.11721-15-andre.przywara@arm.com> MIME-Version: 1.0 In-Reply-To: <20210118020848.11721-15-andre.przywara@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210118_103329_304366_178E40FF X-CRM114-Status: GOOD ( 15.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Vinod Koul , Samuel Holland , Yangtao Li , Linus Walleij , linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Chen-Yu Tsai , =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Shuosheng Huang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Icenowy Zheng Content-Type: multipart/mixed; boundary="===============6847473967473078076==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6847473967473078076== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="m4roapjkb5si7l5o" Content-Disposition: inline --m4roapjkb5si7l5o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 18, 2021 at 02:08:41AM +0000, Andre Przywara wrote: > The H616 has four PHYs as the H3, along with their respective clock > gates and resets, so the property description is identical. >=20 > However the PHYs itself need some special bits, so we need a new > compatible string for it. >=20 > Signed-off-by: Andre Przywara > --- > .../devicetree/bindings/phy/allwinner,sun8i-h3-usb-phy.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/Documentation/devicetree/bindings/phy/allwinner,sun8i-h3-usb= -phy.yaml b/Documentation/devicetree/bindings/phy/allwinner,sun8i-h3-usb-ph= y.yaml > index 60c344585276..f6f2dcb6dc1e 100644 > --- a/Documentation/devicetree/bindings/phy/allwinner,sun8i-h3-usb-phy.ya= ml > +++ b/Documentation/devicetree/bindings/phy/allwinner,sun8i-h3-usb-phy.ya= ml > @@ -15,7 +15,9 @@ properties: > const: 1 > =20 > compatible: > - const: allwinner,sun8i-h3-usb-phy > + oneOf: > + - const: allwinner,sun8i-h3-usb-phy > + - const: allwinner,sun50i-h616-usb-phy While equivalent, enums produce errors that are easier to read. It would be better to switch to one here Maxime --m4roapjkb5si7l5o Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYAWqRQAKCRDj7w1vZxhR xQzuAP96uuX7O5e8UAyOprEQwE8N+AHt7Fy2Ol4huAfv13hCOAD7B1dPFoZzwgfA /AbqKUGTwNkqAU7KF1jVSkTkKSU0rAs= =x9D0 -----END PGP SIGNATURE----- --m4roapjkb5si7l5o-- --===============6847473967473078076== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6847473967473078076==--