From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: linux-arm-msm@vger.kernel.org, will@kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, bjorn.andersson@linaro.org
Subject: Re: [PATCH] ARM: kernel: Fix interrupted SMC calls
Date: Mon, 18 Jan 2021 23:20:42 +0530 [thread overview]
Message-ID: <20210118175042.GA20457@thinkpad> (raw)
In-Reply-To: <20210118160807.GF1551@shell.armlinux.org.uk>
Hi Russel,
On Mon, Jan 18, 2021 at 04:08:07PM +0000, Russell King - ARM Linux admin wrote:
> On Mon, Jan 18, 2021 at 09:21:53PM +0530, Manivannan Sadhasivam wrote:
> > @@ -27,10 +29,18 @@ UNWIND( .fnstart)
> > UNWIND( .save {r4-r7})
> > ldm r12, {r4-r7}
> > \instr
> > + mov r9, r6 // Copy r6 before popping from stack
> > pop {r4-r7}
> > ldr r12, [sp, #(4 * 4)]
> > stm r12, {r0-r3}
> > - bx lr
> > + ldr r10, [sp, #20]
> > + cmp r10, #0
> > + beq 1f // No quirk structure
> > + ldr r11, [r10, #ARM_SMCCC_QUIRK_ID_OFFS]
> > + cmp r11, #ARM_SMCCC_QUIRK_QCOM_A6
> > + bne 1f // No quirk present
> > + str r9, [r10, #ARM_SMCCC_QUIRK_STATE_OFFS]
> > +1: bx lr
>
> NAK. This patch shows little regard for the C ABI. You are corrupting
> registers that must be preserved. Please find out about the C ABIs
> that are used on ARM.
>
Sorry, my asm foo is not that great. Should've checked AAPCS. Will fix it in
next revision.
Thanks,
Mani
> Thanks.
>
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-01-18 17:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 15:51 [PATCH] ARM: kernel: Fix interrupted SMC calls Manivannan Sadhasivam
2021-01-18 16:08 ` Russell King - ARM Linux admin
2021-01-18 17:50 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210118175042.GA20457@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).