From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0318EC433E0 for ; Mon, 18 Jan 2021 17:52:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B635920829 for ; Mon, 18 Jan 2021 17:52:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B635920829 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AOU/7Em98youaEijyHHXqkQBaZ8CJLAKVXxBUrrKprg=; b=BZqAw6xVKh4seeL3sRp+qV4Mb Hv2mD9s6C5lE1E3/PVWXEBwBDA+Qm3elUrz9asI9EDpNYVyOLHfhKi/vsnB42bWedgUUMQq1IaqyK hJlFYfTUIPTZkuBP1KQv+9kmwJ6IGf9PU9ZbSBkU84O7lM0UuSGNQJ5KEH2i/EWS3HkqoZrIhpZrU QZh7M8EBxvESDs3daNKf03yR0WUqbq8STJZdcL8o5/cTaagdJI+I0aQa5K/OfaTs7RTf2uPj408MG kHh1OBfi27HnSNURMUVBz0bdFVIbA5Lo+vx0WX94FzO08uTEyMcnxMRIPpIGFZc/vknt99JKLjJ4v xMCPYgq3g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1Yg2-0003y6-5j; Mon, 18 Jan 2021 17:50:54 +0000 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1Yfz-0003xc-JD for linux-arm-kernel@lists.infradead.org; Mon, 18 Jan 2021 17:50:52 +0000 Received: by mail-pj1-x102f.google.com with SMTP id my11so217523pjb.1 for ; Mon, 18 Jan 2021 09:50:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IzwteHICGjyIn2Du51loln2nvbA/Mz4gv3XLd8Owd0o=; b=RF+/H0S5srOYwTCAPyPjQ9WJnYvmYcdWWpuAIWTn4j3umRdE0IyUZx3oJ80Ys1Pl56 PKzanZeA65LPLvufXcHXTh31+zGk7Ciqb26N7Kz0ZoC+Q/cuFiISnq0/sNWfJpPDMXBq hfg2ruwO7S9yPI6a0gTO8sjITckyh1RrXbTTeYNtWiiQjFt30c6nDIf3lXVAya4bTecq 4FMDwjgnpz2MNdM2yV9Ot9rstTVcWudFc4NjRrwDBIecW3iAgne90hmf3BKJBOsuBk1n ggI0/2x7w8ZNHjq11+nXDHUX/eIZwIHZPzVc+5IiCquMdpuV3DKNeP5GSIwgz2Div62R p9uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IzwteHICGjyIn2Du51loln2nvbA/Mz4gv3XLd8Owd0o=; b=keiqqmj38c2BPTtpcpdKLvij0wwCkJoNgTU1LmlhfWwPWeate2MGc2xd0XLBkoMZZ3 BggQA8U9xW2TQ1LUFH1fuNw/6j+e9xH6iqetysXhOhntviKxlA5uW1wxPdu9mdchue96 WBHa5L+DliriQJzKKhU3gA5tW6rAN4jHyG8TmJNAlWlsx9ETlVfKTWggYooLzjeY9q/v ZUuX++kBKD50I4w2yKO4Y0YlPbmyeOaOpBbqgwzbme0aKelAct9i8Ag9TTXYzFfrLpoc OT7+Spxr2cRh/P8jeZ+AS+X/XBA65FNLBGCqNkFp9Dniim+2UupNt839u89EfyjE9zvv zV3A== X-Gm-Message-State: AOAM533skWd0h8Lq54xNs6WMy0675ELuJsmtnlQlSkoFDOEdVbBI2gaI +f6j2eAN0hOZPn5tt+UtI2Az X-Google-Smtp-Source: ABdhPJz5lWcdNE4Iks4juiqsCIlseOjSQmLbvfji7NgfxrV/b3KhSBUK5XqMt3NJcTBfRHGgoPAMoQ== X-Received: by 2002:a17:90a:4582:: with SMTP id v2mr456193pjg.15.1610992249275; Mon, 18 Jan 2021 09:50:49 -0800 (PST) Received: from thinkpad ([2409:4072:6d10:e0cf:bf2b:fc5e:cb6d:136]) by smtp.gmail.com with ESMTPSA id d16sm4015534pfn.160.2021.01.18.09.50.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jan 2021 09:50:48 -0800 (PST) Date: Mon, 18 Jan 2021 23:20:42 +0530 From: Manivannan Sadhasivam To: Russell King - ARM Linux admin Subject: Re: [PATCH] ARM: kernel: Fix interrupted SMC calls Message-ID: <20210118175042.GA20457@thinkpad> References: <20210118155153.21520-1-manivannan.sadhasivam@linaro.org> <20210118160807.GF1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210118160807.GF1551@shell.armlinux.org.uk> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210118_125051_686116_BB14888F X-CRM114-Status: GOOD ( 15.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, will@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bjorn.andersson@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Russel, On Mon, Jan 18, 2021 at 04:08:07PM +0000, Russell King - ARM Linux admin wrote: > On Mon, Jan 18, 2021 at 09:21:53PM +0530, Manivannan Sadhasivam wrote: > > @@ -27,10 +29,18 @@ UNWIND( .fnstart) > > UNWIND( .save {r4-r7}) > > ldm r12, {r4-r7} > > \instr > > + mov r9, r6 // Copy r6 before popping from stack > > pop {r4-r7} > > ldr r12, [sp, #(4 * 4)] > > stm r12, {r0-r3} > > - bx lr > > + ldr r10, [sp, #20] > > + cmp r10, #0 > > + beq 1f // No quirk structure > > + ldr r11, [r10, #ARM_SMCCC_QUIRK_ID_OFFS] > > + cmp r11, #ARM_SMCCC_QUIRK_QCOM_A6 > > + bne 1f // No quirk present > > + str r9, [r10, #ARM_SMCCC_QUIRK_STATE_OFFS] > > +1: bx lr > > NAK. This patch shows little regard for the C ABI. You are corrupting > registers that must be preserved. Please find out about the C ABIs > that are used on ARM. > Sorry, my asm foo is not that great. Should've checked AAPCS. Will fix it in next revision. Thanks, Mani > Thanks. > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel