From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C231CC433DB for ; Tue, 19 Jan 2021 06:32:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5EF9922CB1 for ; Tue, 19 Jan 2021 06:32:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5EF9922CB1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zlingsmart.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=pnPihHmZeYps+R0RwD2S07YbzFAH2Wt3qpZP+wqkhrA=; b=N3Z5Pxcu5j53LzeXOcvVFKQXHY zuPcLKD2+xk8V8ssfS+yzMbGtrVXzov6sablYQHYUgalg2cc4QuIANsMtWnCR9L8H4ZgNETuDJ3Ei a6BJsYyOvflVmncMab9jl7cR0qM244lD64vtpEai6E0kfsZeIKZoqEos1RywfuAufNHNXFcikjJPU bOXrZMzqn8+44AVGys8I2kmD/N2MX170Yyhn8lJGsGX+YlLf2DlFLO+ophs67GN7Rwy1A/9ZbvJyr 8xk8Ibtoo69UOS2E+RumZNLeDbCRYn2yejRV2XZZcD+upKTBYStHJCI9bKmEm8z6jkRrMaLVhTHjD Z5KbDzmQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1kWA-0005Ss-Oj; Tue, 19 Jan 2021 06:29:30 +0000 Received: from out28-49.mail.aliyun.com ([115.124.28.49]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1kW6-0005R9-AT for linux-arm-kernel@lists.infradead.org; Tue, 19 Jan 2021 06:29:28 +0000 X-Alimail-AntiSpam: AC=CONTINUE; BC=0.1089962|-1; CH=green; DM=|CONTINUE|false|; DS=CONTINUE|ham_alarm|0.00400365-0.000545466-0.995451; FP=11637145905088366247|1|1|1|0|-1|-1|-1; HT=ay29a033018047203; MF=liu.xiang@zlingsmart.com; NM=1; PH=DS; RN=9; RT=9; SR=0; TI=SMTPD_---.JMd8d.7_1611037752; Received: from localhost(mailfrom:liu.xiang@zlingsmart.com fp:SMTPD_---.JMd8d.7_1611037752) by smtp.aliyun-inc.com(10.194.97.246); Tue, 19 Jan 2021 14:29:12 +0800 From: Liu Xiang To: linux-gpio@vger.kernel.org Subject: [PATCH] pinctrl: sunxi: fix use-after-free in sunxi_pmx_free() Date: Tue, 19 Jan 2021 14:29:08 +0800 Message-Id: <20210119062908.20169-1-liu.xiang@zlingsmart.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210119_012926_637408_08570F06 X-CRM114-Status: GOOD ( 11.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jernej.skrabec@siol.net, liuxiang_1999@126.com, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, mripard@kernel.org, Liu Xiang , wens@csie.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When CONFIG_REGULATOR is not set, sunxi_pmx_request() always return success. Even a group of pins call sunxi_pmx_request(), the refcount is only 1. This can cause a use-after-free warning in sunxi_pmx_free(). To solve this problem, go to err path if regulator_get() return NULL or error. Signed-off-by: Liu Xiang --- drivers/pinctrl/sunxi/pinctrl-sunxi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c index dc8d39ae0..d1a8974eb 100644 --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c @@ -777,7 +777,7 @@ static int sunxi_pmx_request(struct pinctrl_dev *pctldev, unsigned offset) snprintf(supply, sizeof(supply), "vcc-p%c", 'a' + bank); reg = regulator_get(pctl->dev, supply); - if (IS_ERR(reg)) { + if (IS_ERR_OR_NULL(reg)) { dev_err(pctl->dev, "Couldn't get bank P%c regulator\n", 'A' + bank); return PTR_ERR(reg); @@ -811,7 +811,7 @@ static int sunxi_pmx_free(struct pinctrl_dev *pctldev, unsigned offset) PINS_PER_BANK; struct sunxi_pinctrl_regulator *s_reg = &pctl->regulators[bank_offset]; - if (!refcount_dec_and_test(&s_reg->refcount)) + if (!s_reg->regulator || !refcount_dec_and_test(&s_reg->refcount)) return 0; regulator_disable(s_reg->regulator); -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel