From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F06D5C433E6 for ; Tue, 19 Jan 2021 08:58:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 901BA23103 for ; Tue, 19 Jan 2021 08:58:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 901BA23103 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3CjA733WbyJJ6THGDle1LfCoQKijR/mMfYIOguQsjCs=; b=XPoQZdDkHVNzGKVwMXCL8h2oz luH7iTXVpB/NJKR1XpVGJ4chIh+qc/CJCfwP7uhApBTxknGmhuPrt6kxwLhPaiwQU41R/sEmmhzUH v5K5In1kffT3VFh2Uk3LXAfa385+y+kQQo9Srn/zs9DeUbcA5YAzxEpQ312f939JEJlWq8DKpYxvQ 3rJDzQBgzUQyTDGW9BWC0Xr+ZWuLWypnK/71TFGlOL/nfZZwjoJZNYEeOQqLVIzfO0yAB924GmNzS B65Hs8UJtRbDi4owkhAU1VvzYox7gH/giap25uI4bOQT/pVs4uaLsm//2dQ+TuEWCsp7I3Bbsktv2 4X2Ole7lw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1mp6-0005A0-PD; Tue, 19 Jan 2021 08:57:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1mp3-00059Y-QJ for linux-arm-kernel@lists.infradead.org; Tue, 19 Jan 2021 08:57:11 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0470123103; Tue, 19 Jan 2021 08:57:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611046628; bh=FNcY0Ysa8mRAba5iHcXtcfQOnny/W/mDvHOHe7GEF0Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lpWQ49TouWfPuvM/2l87PgVTet3UyKx9kXsMTe8IcUcaf9NJxOooNf55QuaBflm58 QtF0WcrMXJmRPkbd7faM2Aw/41mG6G36eD2+EAnbZuue6Z0NXQj4j9L92zthdmTgKh NjMDIVXk0DbnDgTGYH0CwfV+hRtqAeDnlgTTabeSUiO9E0gdsb704cuh6v8+T/qBjP aWeD6T/T2YDup+KzPU5qCL0r8GEAA7FPfzb5zTNJeOUoVWuPdUJWlnM0+3EydtYUXv N9LwHz3PMt5IWA2K5VgrzUfwr5uvSMekCEQtqGJk/ArYj+1P+zxClXmjRshvDA2Ars 2FkRPfNS12rHw== Date: Tue, 19 Jan 2021 16:57:02 +0800 From: Shawn Guo To: Ahmad Fatoum Subject: Re: [RFC PATCH] ARM: dts: imx6qdl: specify vcc-supply for NOP USB PHYs Message-ID: <20210119085700.GB4356@dragon> References: <20201113152856.3758-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201113152856.3758-1-a.fatoum@pengutronix.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210119_035709_917923_AC495879 X-CRM114-Status: GOOD ( 24.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Sascha Hauer , linux-kernel@vger.kernel.org, Frieder Schrempf , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 13, 2020 at 04:28:55PM +0100, Ahmad Fatoum wrote: > The SoC dtsi lists a NOP USB PHY for each of the two HSIC-only USB > controllers. Their device tree node doesn't indicate a vcc-supply > resulting in: > > usb_phy_generic usbphynop1: supply vcc not found, using dummy regulator > usb_phy_generic usbphynop2: supply vcc not found, using dummy regulator So the patch is all for removing this kernel message, with introducing the following potential breakage? Shawn > > warnings on boot up. The USB IP vcc-supply - separate from the vusb - is > hardwired to LDO_2P5[1], which we already have a device tree node for. > Reference it for the dummy "phy" as well. > > This will lead to breakage (probe deferment) for kernels that: > - Use a HSIC USB controller > - Use this new device tree > - but have CONFIG_REGULATOR_ANATOP disabled > > Because while the regulator is always-on, it can't be resolved when > there is no driver for it. > > As there are > > - no affected upstream device trees > - existing device trees are unaffected without recompilation > - disabling CONFIG_REGULATOR_ANATOP is explicitly a non-recommended > configuration per symbol help text > > this potential breakage is deemed acceptable. > > [1]: i.MX 6Dual/6Quad Reference Manual, Rev. C, > Figure 53-1. Power System Overview > > Cc: Frieder Schrempf > Signed-off-by: Ahmad Fatoum > --- > arch/arm/boot/dts/imx6qdl.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi > index 43edbf1156c7..22e4c142de13 100644 > --- a/arch/arm/boot/dts/imx6qdl.dtsi > +++ b/arch/arm/boot/dts/imx6qdl.dtsi > @@ -131,11 +131,13 @@ pmu: pmu { > > usbphynop1: usbphynop1 { > compatible = "usb-nop-xceiv"; > + vcc-supply = <®_vdd2p5>; > #phy-cells = <0>; > }; > > usbphynop2: usbphynop2 { > compatible = "usb-nop-xceiv"; > + vcc-supply = <®_vdd2p5>; > #phy-cells = <0>; > }; > > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel