From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89821C433E0 for ; Tue, 19 Jan 2021 11:03:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C9212075F for ; Tue, 19 Jan 2021 11:03:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C9212075F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bo3asjTg4qJaSocr/1ozUlS+5D9mjw1KptjtAPsgy+w=; b=mQTwu/b7oitb136sgxFU/57/K tj5vObkOlQYV5insyuCfSyJUAffRQ0tx/cZxWnheOMQ5o9F+ti1IlCWy1VH++STDa6EFp5dY1yKMc 7ec5Av2/tiBviXj30BjDqF2sEzSa20bd6Q6pw644suPYQKRQBS8v5taP2CvWmnToExpYinkrJ7R5o gbifuJOte1geNi5rzyI/dL/nmMLU5w4Ldunb1mSU/XZRY/TWz2ZjxAsUQK/WVGth1eSZfz9A24R6C cHQxgvajjGsfILUuXP5XvQxkvzjZEkwPFDGczcbkjveAVBvO/KPKT5nPc+saekULBP7Z29dMj9rum OUdThgMoQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1olb-0001OF-Nf; Tue, 19 Jan 2021 11:01:43 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1olV-0001Mv-VR for linux-arm-kernel@lists.infradead.org; Tue, 19 Jan 2021 11:01:42 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1D5A32075F; Tue, 19 Jan 2021 11:01:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611054097; bh=tJqgnp4OxGV364DlbJ5Sda9VDJ/ZKg3Jw5QRNd0Sv2o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RCyW40xHeAT0nw1vEgT7YIgtn6sPL5CGXrZtBn+JAkph4OKidCA1ILfYh0Qie2bPj zjCcOrm45mn51shGhamdF1HjC5HOP/sp6fSmDv8SkBXIwc2go2Z+lLUJRk90Ui3i+b yhXEd4Q0bcs3KAy/3cX0x+x/xGYcvSWkS6ZGAdJkYzrhqurE86PPMK6pvMGaZIH4/D LB8JVKDvWepN5MB/pHLNBQLzyBtX1ACRarLWPtjTGPXgzY2NHMocjwyW/LMX6POwbi HEHtDYW/Sj/4MI6PKAFNMejw+89ssRf0OlTt5rSrfI69Bx3uD2w+W1cctUyV3Fe/2A YkSOEvuCaCq7g== Date: Tue, 19 Jan 2021 11:01:31 +0000 From: Will Deacon To: Liguang Zhang Subject: Re: [PATCH] arm64/cpuinfo: Show right CPU architecture information Message-ID: <20210119110131.GA18433@willie-the-truck> References: <20210119105510.27836-1-zhangliguang@linux.alibaba.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210119105510.27836-1-zhangliguang@linux.alibaba.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210119_060138_094361_B61ACA66 X-CRM114-Status: GOOD ( 14.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Suzuki K Poulose , Catalin Marinas , Anshuman Khandual , gustavoars@kernel.org, linux-kernel@vger.kernel.org, Mark Brown , Vincenzo Frascino , Dave Martin , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 19, 2021 at 06:55:10PM +0800, Liguang Zhang wrote: > CPU architecture is assigned to be a fixed value, it should be obtained > from midr register. > > Signed-off-by: Liguang Zhang > --- > arch/arm64/kernel/cpuinfo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c > index 77605aec25fe..0bd11e0fe9f2 100644 > --- a/arch/arm64/kernel/cpuinfo.c > +++ b/arch/arm64/kernel/cpuinfo.c > @@ -191,7 +191,7 @@ static int c_show(struct seq_file *m, void *v) > > seq_printf(m, "CPU implementer\t: 0x%02x\n", > MIDR_IMPLEMENTOR(midr)); > - seq_printf(m, "CPU architecture: 8\n"); > + seq_printf(m, "CPU architecture: %d\n", MIDR_ARCHITECTURE(midr)); Huh? Won't this always return 0xf? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel