From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A18EC433DB for ; Tue, 19 Jan 2021 12:05:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D584E20754 for ; Tue, 19 Jan 2021 12:05:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D584E20754 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nTrVFbUn95k1vtU23XtuP2/9BL83Dnrn8nwi9POAntQ=; b=mOl5q3g7K4lCH0/i03GfmnKkU sLzUqsMQ+TkveV3bF0PsAWWGx7L3N4Fp/IXfOt03tgQwMjh/rqDLi+BeKGvDBuSbd/H8bNOqsUbe4 9Mg71HQaUE4ojtwSja1/kN+hsEiH37DFyl4F4CJEX8SmQ+N6epcNdyckE9k0T6TSxlOBn5w/wa4zd Wx4EwOJnH1BIuAYdRIlizFfyIQ5bSTJiIu5bBErCoDK7aqeUaePdHIFx8ISZj8UJ7AV9XnOg5Gzos 8fjqnc3xCk0B8ekaGlOVorjx+2RuHjyIcBpu07O/7XMPCEGGSsZ9Q5S7mTTgaj7KLxRIoeKdGNHfG gPJzQ9z/g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1pkS-0007Xj-9Q; Tue, 19 Jan 2021 12:04:36 +0000 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1pkP-0007Ww-J0 for linux-arm-kernel@lists.infradead.org; Tue, 19 Jan 2021 12:04:34 +0000 Received: by mail-lf1-x12c.google.com with SMTP id h205so28654969lfd.5 for ; Tue, 19 Jan 2021 04:04:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Dj35Y10xvadEoj4O3QQAv08yPioskFbVaeePKmUZ9Uk=; b=OTt/HPQ18ep/L5BQjn0d2sUCrTGC/Eb4Pc7xsKgfQHwU8n7OQPpqQwwWnuLfwgSCwc moSPENoto5XgW6Xn2Icf6eRj2iQEoDviYkXjqAqtot/1l9nVW0HwZK+epzIl721H+Mzd 1QD+hVWp2vE3ofoDobxXyeJf3cjOqbK++JvdC9FkbzerJIzy+q9F6BPLfsbVBS3ZFY5l KfYz64mbFZNMrjIgCl9qJBk15ddrGeGhW03U8dCE8mssEOHWmsuqJ6emCHvym2/ar6nf 9FDnMXSJ0rU1Odei8mUWjPpWLYgh1DoWKNctx6tb/Nzk3B/GBYgiQNLgs5tSOeEZZJrc 0MdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Dj35Y10xvadEoj4O3QQAv08yPioskFbVaeePKmUZ9Uk=; b=fwjBaEMBvv7HCNIox6X81PyAvYBrPNaZ6ubi2qDLtzd+PH2KNTLre1j5jrlVi9M6Oy HOtjNuYAjbsG6XqONX4OSP4HM0azKVDABOUWb+7nhjIoqISJeqvCq2NZLPzsPqgrq5K2 rKlgnkiXQ3QsTKR88IbKD6BF+8paNr31gP2iXnQIRdhCYbwakB/A0mwVHgnC0FPZH06d /pIu3saZhAUMvxEpBpYz3uayq2ZaeF/WUoa1wpQ8OHhtnr0QOKkX07uwRYZWw+VRD9KC I+VuD9XSkiX5rQsOe4B853ei2kh7GDJOD0Q4bvjPqxbpSGWrEWDZhmFkSrg0x+XKHpcv iS0w== X-Gm-Message-State: AOAM533TZeXuw1tBIQdaRh+ye1u/7qjiNNlRJugpExjTazfbu7zOW2/N Fw6xKcO+BxGoCI8GOn8kOQo= X-Google-Smtp-Source: ABdhPJyKNYJ/6ghlt3pcnWSiKLntUja0K0OPnDzu3Ijj1aZpbb/PUweZfO0FMXBUIReFejQilX6ZPA== X-Received: by 2002:a05:6512:33a8:: with SMTP id i8mr1895774lfg.5.1611057872008; Tue, 19 Jan 2021 04:04:32 -0800 (PST) Received: from home.paul.comp (paulfertser.info. [2001:470:26:54b:226:9eff:fe70:80c2]) by smtp.gmail.com with ESMTPSA id h1sm2265819lfc.121.2021.01.19.04.04.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jan 2021 04:04:31 -0800 (PST) Received: from home.paul.comp (home.paul.comp [IPv6:0:0:0:0:0:0:0:1]) by home.paul.comp (8.15.2/8.15.2/Debian-14~deb10u1) with ESMTP id 10JC4RAh015519; Tue, 19 Jan 2021 15:04:28 +0300 Received: (from paul@localhost) by home.paul.comp (8.15.2/8.15.2/Submit) id 10JC4QTg015518; Tue, 19 Jan 2021 15:04:26 +0300 Date: Tue, 19 Jan 2021 15:04:26 +0300 From: Paul Fertser To: Ernesto Corona Subject: Re: [PATCH v29 2/6] dt-binding: jtag: Aspeed 2400 and 2500 series Message-ID: <20210119120426.GE2971@home.paul.comp> References: <20200413222920.4722-1-ernesto.corona@intel.com> <20200413222920.4722-3-ernesto.corona@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200413222920.4722-3-ernesto.corona@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210119_070433_632670_4DE78F26 X-CRM114-Status: GOOD ( 13.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Alexandre Belloni , Theodore Ts'o , Arnd Bergmann , linux-aspeed@lists.ozlabs.org, linux-doc@vger.kernel.org, Andrew Jeffery , Steven Filary , Jonathan Corbet , linux-kernel@vger.kernel.org, Amithash Prasad , Jiri Pirko , Rgrs , Eric Biggers , Joel Stanley , Mauro Carvalho Chehab , Oleksandr Shamray , Patrick Williams , linux-arm-kernel@lists.infradead.org, Vadim Pasternak Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 13, 2020 at 03:29:16PM -0700, Ernesto Corona wrote: > --- /dev/null > +++ b/Documentation/devicetree/bindings/jtag/aspeed-jtag.yaml > +examples: > + - | > + #include > + #include > + > + jtag: jtag@1e6e4000 { > + compatible = "aspeed,ast2500-jtag"; > + reg = <0x1e6e4000 0x1c>; > + clocks = <&syscon ASPEED_CLK_APB>; > + resets = <&syscon ASPEED_RESET_JTAG_MASTER>; > + interrupts = <43>; > + }; It's nice to have an example but shouldn't it also be included in aspeed-g5.dtsi as part of the patch series if it's known that the driver works on those SoCs and the peripheral is always present? -- Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software! mailto:fercerpav@gmail.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel