* [PATCH 00/20] Rid W=1 warnings from Clock
@ 2021-01-20 9:30 Lee Jones
2021-01-20 9:30 ` [PATCH 01/20] clk: rockchip: clk: Demote non-conformant kernel-doc headers Lee Jones
` (11 more replies)
0 siblings, 12 replies; 19+ messages in thread
From: Lee Jones @ 2021-01-20 9:30 UTC (permalink / raw)
To: lee.jones
Cc: Heiko Stuebner, Michael Turquette, Stephen Gallimore, Zong Li,
linux-riscv, Fabio Estevam, linux-clk, Xing Zheng,
Emilio López, Gregory Clement, Michal Simek, linux-rockchip,
Chen-Yu Tsai, Thomas Abraham, bcm-kernel-feedback-list,
NXP Linux Team, Philipp Zabel, Linus Walleij, Kees Cook,
Arnd Bergmann, Ray Jui, Sascha Hauer, Omri Itach, Maxime Ripard,
Paul Walmsley, linux-omap, linux-arm-kernel, Sören Brinkmann,
Jernej Skrabec, Tero Kristo, Scott Branden, Stephen Boyd,
linux-kernel, Julia Lawall, Dinh Nguyen, Pankaj Dev,
Palmer Dabbelt, Pengutronix Kernel Team, Shawn Guo,
Pragnesh Patel
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
We should have these nailed in ~2 patchsets.
Lee Jones (20):
clk: rockchip: clk: Demote non-conformant kernel-doc headers
clk: rockchip: clk-cpu: Remove unused/undocumented struct members
clk: rockchip: clk-pll: Demote kernel-doc abuses to standard comment
blocks
clk: rockchip: clk-half-divider: Demote non-conformant kernel-doc
header
clk: bcm: clk-iproc-pll: Demote kernel-doc abuse
clk: sifive: fu540-prci: Declare static const variable
'prci_clk_fu540' where it's used
clk: socfpga: clk-pll: Remove unused variable 'rc'
clk: socfpga: clk-pll-a10: Remove set but unused variable 'rc'
clk: mvebu: ap-cpu-clk: Demote non-conformant kernel-doc header
clk: imx: clk-imx31: Remove unused static const table 'uart_clks'
clk: st: clkgen-pll: Demote unpopulated kernel-doc header
clk: st: clkgen-fsyn: Fix worthy struct documentation demote partially
filled one
clk: ti: clockdomain: Fix description for 'omap2_init_clk_clkdm's hw
param
clk: sunxi: clk-sunxi: Demote a bunch of non-conformant kernel-doc
headers
clk: ti: dpll: Fix misnaming of '_register_dpll()'s 'user' parameter
clk: ti: gate: Fix possible doc-rot in
'omap36xx_gate_clk_enable_with_hsdiv_restore'
clk: sunxi: clk-a10-ve: Demote obvious kernel-doc abuse
clk: sunxi: clk-mod0: Demote non-conformant kernel-doc header
clk: versatile: clk-icst: Fix worthy struct documentation block
clk: zynq: clkc: Remove various instances of an unused variable 'clk'
drivers/clk/bcm/clk-iproc-pll.c | 2 +-
drivers/clk/imx/clk-imx31.c | 10 ----
drivers/clk/mvebu/ap-cpu-clk.c | 2 +-
drivers/clk/rockchip/clk-cpu.c | 4 --
drivers/clk/rockchip/clk-half-divider.c | 2 +-
drivers/clk/rockchip/clk-pll.c | 6 +-
drivers/clk/rockchip/clk.c | 4 +-
drivers/clk/sifive/fu540-prci.h | 5 --
drivers/clk/sifive/sifive-prci.c | 5 ++
drivers/clk/socfpga/clk-pll-a10.c | 3 +-
drivers/clk/socfpga/clk-pll.c | 3 +-
drivers/clk/st/clkgen-fsyn.c | 6 +-
drivers/clk/st/clkgen-pll.c | 3 +-
drivers/clk/sunxi/clk-a10-ve.c | 2 +-
drivers/clk/sunxi/clk-mod0.c | 2 +-
drivers/clk/sunxi/clk-sunxi.c | 32 +++++------
drivers/clk/ti/clockdomain.c | 2 +-
drivers/clk/ti/dpll.c | 2 +-
drivers/clk/ti/gate.c | 2 +-
drivers/clk/versatile/clk-icst.c | 7 ++-
drivers/clk/zynq/clkc.c | 73 ++++++++++++-------------
21 files changed, 79 insertions(+), 98 deletions(-)
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: bcm-kernel-feedback-list@broadcom.com
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Dinh Nguyen <dinguyen@kernel.org>
Cc: "Emilio López" <emilio@elopez.com.ar>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Gregory Clement <gregory.clement@bootlin.com>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>
Cc: Julia Lawall <Julia.Lawall@inria.fr>
Cc: Kees Cook <keescook@chromium.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-clk@vger.kernel.org
Cc: linux-omap@vger.kernel.org
Cc: linux-riscv@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: Omri Itach <omrii@marvell.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Pankaj Dev <pankaj.dev@st.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Pragnesh Patel <Pragnesh.patel@sifive.com>
Cc: Ray Jui <rjui@broadcom.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: Stephen Gallimore <stephen.gallimore@st.com>
Cc: Tero Kristo <kristo@kernel.org>
Cc: Thomas Abraham <thomas.ab@samsung.com>
Cc: Xing Zheng <zhengxing@rock-chips.com>
Cc: Zong Li <zong.li@sifive.com>
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 19+ messages in thread* [PATCH 01/20] clk: rockchip: clk: Demote non-conformant kernel-doc headers 2021-01-20 9:30 [PATCH 00/20] Rid W=1 warnings from Clock Lee Jones @ 2021-01-20 9:30 ` Lee Jones 2021-01-20 9:30 ` [PATCH 02/20] clk: rockchip: clk-cpu: Remove unused/undocumented struct members Lee Jones ` (10 subsequent siblings) 11 siblings, 0 replies; 19+ messages in thread From: Lee Jones @ 2021-01-20 9:30 UTC (permalink / raw) To: lee.jones Cc: Heiko Stuebner, Xing Zheng, Stephen Boyd, Michael Turquette, linux-kernel, linux-rockchip, Thomas Abraham, linux-clk, linux-arm-kernel Fixes the following W=1 kernel build warning(s): drivers/clk/rockchip/clk.c:45: warning: Function parameter or member 'name' not described in 'rockchip_clk_register_branch' drivers/clk/rockchip/clk.c:45: warning: Function parameter or member 'parent_names' not described in 'rockchip_clk_register_branch' drivers/clk/rockchip/clk.c:45: warning: Function parameter or member 'num_parents' not described in 'rockchip_clk_register_branch' drivers/clk/rockchip/clk.c:45: warning: Function parameter or member 'base' not described in 'rockchip_clk_register_branch' drivers/clk/rockchip/clk.c:45: warning: Function parameter or member 'muxdiv_offset' not described in 'rockchip_clk_register_branch' drivers/clk/rockchip/clk.c:45: warning: Function parameter or member 'mux_shift' not described in 'rockchip_clk_register_branch' drivers/clk/rockchip/clk.c:45: warning: Function parameter or member 'mux_width' not described in 'rockchip_clk_register_branch' drivers/clk/rockchip/clk.c:45: warning: Function parameter or member 'mux_flags' not described in 'rockchip_clk_register_branch' drivers/clk/rockchip/clk.c:45: warning: Function parameter or member 'div_offset' not described in 'rockchip_clk_register_branch' drivers/clk/rockchip/clk.c:45: warning: Function parameter or member 'div_shift' not described in 'rockchip_clk_register_branch' drivers/clk/rockchip/clk.c:45: warning: Function parameter or member 'div_width' not described in 'rockchip_clk_register_branch' drivers/clk/rockchip/clk.c:45: warning: Function parameter or member 'div_flags' not described in 'rockchip_clk_register_branch' drivers/clk/rockchip/clk.c:45: warning: Function parameter or member 'div_table' not described in 'rockchip_clk_register_branch' drivers/clk/rockchip/clk.c:45: warning: Function parameter or member 'gate_offset' not described in 'rockchip_clk_register_branch' drivers/clk/rockchip/clk.c:45: warning: Function parameter or member 'gate_shift' not described in 'rockchip_clk_register_branch' drivers/clk/rockchip/clk.c:45: warning: Function parameter or member 'gate_flags' not described in 'rockchip_clk_register_branch' drivers/clk/rockchip/clk.c:45: warning: Function parameter or member 'flags' not described in 'rockchip_clk_register_branch' drivers/clk/rockchip/clk.c:45: warning: Function parameter or member 'lock' not described in 'rockchip_clk_register_branch' drivers/clk/rockchip/clk.c:180: warning: Function parameter or member 'hw' not described in 'rockchip_fractional_approximation' drivers/clk/rockchip/clk.c:180: warning: Function parameter or member 'rate' not described in 'rockchip_fractional_approximation' drivers/clk/rockchip/clk.c:180: warning: Function parameter or member 'parent_rate' not described in 'rockchip_fractional_approximation' drivers/clk/rockchip/clk.c:180: warning: Function parameter or member 'm' not described in 'rockchip_fractional_approximation' drivers/clk/rockchip/clk.c:180: warning: Function parameter or member 'n' not described in 'rockchip_fractional_approximation' Cc: Michael Turquette <mturquette@baylibre.com> Cc: Stephen Boyd <sboyd@kernel.org> Cc: Heiko Stuebner <heiko@sntech.de> Cc: Xing Zheng <zhengxing@rock-chips.com> Cc: Thomas Abraham <thomas.ab@samsung.com> Cc: linux-clk@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-rockchip@lists.infradead.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/clk/rockchip/clk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c index 336481bc6cc72..049e5e0b64f62 100644 --- a/drivers/clk/rockchip/clk.c +++ b/drivers/clk/rockchip/clk.c @@ -24,7 +24,7 @@ #include <linux/rational.h> #include "clk.h" -/** +/* * Register a clock branch. * Most clock branches have a form like * @@ -170,7 +170,7 @@ static int rockchip_clk_frac_notifier_cb(struct notifier_block *nb, return notifier_from_errno(ret); } -/** +/* * fractional divider must set that denominator is 20 times larger than * numerator to generate precise clock frequency. */ -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 02/20] clk: rockchip: clk-cpu: Remove unused/undocumented struct members 2021-01-20 9:30 [PATCH 00/20] Rid W=1 warnings from Clock Lee Jones 2021-01-20 9:30 ` [PATCH 01/20] clk: rockchip: clk: Demote non-conformant kernel-doc headers Lee Jones @ 2021-01-20 9:30 ` Lee Jones 2021-01-20 9:30 ` [PATCH 03/20] clk: rockchip: clk-pll: Demote kernel-doc abuses to standard comment blocks Lee Jones ` (9 subsequent siblings) 11 siblings, 0 replies; 19+ messages in thread From: Lee Jones @ 2021-01-20 9:30 UTC (permalink / raw) To: lee.jones Cc: Heiko Stuebner, Stephen Boyd, Michael Turquette, linux-kernel, linux-rockchip, Thomas Abraham, linux-clk, linux-arm-kernel Fixes the following W=1 kernel build warning(s): drivers/clk/rockchip/clk-cpu.c:65: warning: Function parameter or member 'cpu_mux' not described in 'rockchip_cpuclk' drivers/clk/rockchip/clk-cpu.c:65: warning: Function parameter or member 'cpu_mux_ops' not described in 'rockchip_cpuclk' Cc: Michael Turquette <mturquette@baylibre.com> Cc: Stephen Boyd <sboyd@kernel.org> Cc: Heiko Stuebner <heiko@sntech.de> Cc: Thomas Abraham <thomas.ab@samsung.com> Cc: linux-clk@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-rockchip@lists.infradead.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/clk/rockchip/clk-cpu.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/clk/rockchip/clk-cpu.c b/drivers/clk/rockchip/clk-cpu.c index 0dc478a19451b..fa9027fb1920a 100644 --- a/drivers/clk/rockchip/clk-cpu.c +++ b/drivers/clk/rockchip/clk-cpu.c @@ -51,10 +51,6 @@ */ struct rockchip_cpuclk { struct clk_hw hw; - - struct clk_mux cpu_mux; - const struct clk_ops *cpu_mux_ops; - struct clk *alt_parent; void __iomem *reg_base; struct notifier_block clk_nb; -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 03/20] clk: rockchip: clk-pll: Demote kernel-doc abuses to standard comment blocks 2021-01-20 9:30 [PATCH 00/20] Rid W=1 warnings from Clock Lee Jones 2021-01-20 9:30 ` [PATCH 01/20] clk: rockchip: clk: Demote non-conformant kernel-doc headers Lee Jones 2021-01-20 9:30 ` [PATCH 02/20] clk: rockchip: clk-cpu: Remove unused/undocumented struct members Lee Jones @ 2021-01-20 9:30 ` Lee Jones 2021-01-20 9:30 ` [PATCH 04/20] clk: rockchip: clk-half-divider: Demote non-conformant kernel-doc header Lee Jones ` (8 subsequent siblings) 11 siblings, 0 replies; 19+ messages in thread From: Lee Jones @ 2021-01-20 9:30 UTC (permalink / raw) To: lee.jones Cc: Heiko Stuebner, Xing Zheng, Stephen Boyd, Michael Turquette, linux-kernel, linux-rockchip, linux-clk, linux-arm-kernel Fixes the following W=1 kernel build warning(s): drivers/clk/rockchip/clk-pll.c:104: warning: Function parameter or member 'i' not described in 'RK3036_PLLCON' drivers/clk/rockchip/clk-pll.c:365: warning: Function parameter or member 'nr' not described in 'RK3066_PLL_RESET_DELAY' drivers/clk/rockchip/clk-pll.c:584: warning: Function parameter or member 'i' not described in 'RK3399_PLLCON' Cc: Michael Turquette <mturquette@baylibre.com> Cc: Stephen Boyd <sboyd@kernel.org> Cc: Heiko Stuebner <heiko@sntech.de> Cc: Xing Zheng <zhengxing@rock-chips.com> Cc: linux-clk@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-rockchip@lists.infradead.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/clk/rockchip/clk-pll.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/rockchip/clk-pll.c b/drivers/clk/rockchip/clk-pll.c index 4c6c9167ef509..fe937bcdb4876 100644 --- a/drivers/clk/rockchip/clk-pll.c +++ b/drivers/clk/rockchip/clk-pll.c @@ -97,7 +97,7 @@ static int rockchip_pll_wait_lock(struct rockchip_clk_pll *pll) return ret; } -/** +/* * PLL used in RK3036 */ @@ -358,7 +358,7 @@ static const struct clk_ops rockchip_rk3036_pll_clk_ops = { .init = rockchip_rk3036_pll_init, }; -/** +/* * PLL used in RK3066, RK3188 and RK3288 */ @@ -577,7 +577,7 @@ static const struct clk_ops rockchip_rk3066_pll_clk_ops = { .init = rockchip_rk3066_pll_init, }; -/** +/* * PLL used in RK3399 */ -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 04/20] clk: rockchip: clk-half-divider: Demote non-conformant kernel-doc header 2021-01-20 9:30 [PATCH 00/20] Rid W=1 warnings from Clock Lee Jones ` (2 preceding siblings ...) 2021-01-20 9:30 ` [PATCH 03/20] clk: rockchip: clk-pll: Demote kernel-doc abuses to standard comment blocks Lee Jones @ 2021-01-20 9:30 ` Lee Jones 2021-01-20 9:30 ` [PATCH 05/20] clk: bcm: clk-iproc-pll: Demote kernel-doc abuse Lee Jones ` (7 subsequent siblings) 11 siblings, 0 replies; 19+ messages in thread From: Lee Jones @ 2021-01-20 9:30 UTC (permalink / raw) To: lee.jones Cc: Heiko Stuebner, Stephen Boyd, Michael Turquette, linux-kernel, linux-rockchip, linux-clk, linux-arm-kernel Fixes the following W=1 kernel build warning(s): drivers/clk/rockchip/clk-half-divider.c:168: warning: Function parameter or member 'name' not described in 'rockchip_clk_register_halfdiv' drivers/clk/rockchip/clk-half-divider.c:168: warning: Function parameter or member 'parent_names' not described in 'rockchip_clk_register_halfdiv' drivers/clk/rockchip/clk-half-divider.c:168: warning: Function parameter or member 'num_parents' not described in 'rockchip_clk_register_halfdiv' drivers/clk/rockchip/clk-half-divider.c:168: warning: Function parameter or member 'base' not described in 'rockchip_clk_register_halfdiv' drivers/clk/rockchip/clk-half-divider.c:168: warning: Function parameter or member 'muxdiv_offset' not described in 'rockchip_clk_register_halfdiv' drivers/clk/rockchip/clk-half-divider.c:168: warning: Function parameter or member 'mux_shift' not described in 'rockchip_clk_register_halfdiv' drivers/clk/rockchip/clk-half-divider.c:168: warning: Function parameter or member 'mux_width' not described in 'rockchip_clk_register_halfdiv' drivers/clk/rockchip/clk-half-divider.c:168: warning: Function parameter or member 'mux_flags' not described in 'rockchip_clk_register_halfdiv' drivers/clk/rockchip/clk-half-divider.c:168: warning: Function parameter or member 'div_shift' not described in 'rockchip_clk_register_halfdiv' drivers/clk/rockchip/clk-half-divider.c:168: warning: Function parameter or member 'div_width' not described in 'rockchip_clk_register_halfdiv' drivers/clk/rockchip/clk-half-divider.c:168: warning: Function parameter or member 'div_flags' not described in 'rockchip_clk_register_halfdiv' drivers/clk/rockchip/clk-half-divider.c:168: warning: Function parameter or member 'gate_offset' not described in 'rockchip_clk_register_halfdiv' drivers/clk/rockchip/clk-half-divider.c:168: warning: Function parameter or member 'gate_shift' not described in 'rockchip_clk_register_halfdiv' drivers/clk/rockchip/clk-half-divider.c:168: warning: Function parameter or member 'gate_flags' not described in 'rockchip_clk_register_halfdiv' drivers/clk/rockchip/clk-half-divider.c:168: warning: Function parameter or member 'flags' not described in 'rockchip_clk_register_halfdiv' drivers/clk/rockchip/clk-half-divider.c:168: warning: Function parameter or member 'lock' not described in 'rockchip_clk_register_halfdiv' Cc: Michael Turquette <mturquette@baylibre.com> Cc: Stephen Boyd <sboyd@kernel.org> Cc: Heiko Stuebner <heiko@sntech.de> Cc: linux-clk@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-rockchip@lists.infradead.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/clk/rockchip/clk-half-divider.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/rockchip/clk-half-divider.c b/drivers/clk/rockchip/clk-half-divider.c index ccd5c270c2132..64f7faad2148f 100644 --- a/drivers/clk/rockchip/clk-half-divider.c +++ b/drivers/clk/rockchip/clk-half-divider.c @@ -145,7 +145,7 @@ static const struct clk_ops clk_half_divider_ops = { .set_rate = clk_half_divider_set_rate, }; -/** +/* * Register a clock branch. * Most clock branches have a form like * -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 05/20] clk: bcm: clk-iproc-pll: Demote kernel-doc abuse 2021-01-20 9:30 [PATCH 00/20] Rid W=1 warnings from Clock Lee Jones ` (3 preceding siblings ...) 2021-01-20 9:30 ` [PATCH 04/20] clk: rockchip: clk-half-divider: Demote non-conformant kernel-doc header Lee Jones @ 2021-01-20 9:30 ` Lee Jones 2021-02-11 19:49 ` Stephen Boyd 2021-01-20 9:30 ` [PATCH 10/20] clk: imx: clk-imx31: Remove unused static const table 'uart_clks' Lee Jones ` (6 subsequent siblings) 11 siblings, 1 reply; 19+ messages in thread From: Lee Jones @ 2021-01-20 9:30 UTC (permalink / raw) To: lee.jones Cc: Scott Branden, Stephen Boyd, Ray Jui, Michael Turquette, linux-kernel, bcm-kernel-feedback-list, linux-clk, linux-arm-kernel Fixes the following W=1 kernel build warning(s): drivers/clk/bcm/clk-iproc-pll.c:712: warning: Function parameter or member 'pll' not described in 'iproc_pll_sw_cfg' Cc: Michael Turquette <mturquette@baylibre.com> Cc: Stephen Boyd <sboyd@kernel.org> Cc: Ray Jui <rjui@broadcom.com> Cc: Scott Branden <sbranden@broadcom.com> Cc: bcm-kernel-feedback-list@broadcom.com Cc: linux-clk@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/clk/bcm/clk-iproc-pll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/bcm/clk-iproc-pll.c b/drivers/clk/bcm/clk-iproc-pll.c index 274441e2ddb28..33da30f99c79b 100644 --- a/drivers/clk/bcm/clk-iproc-pll.c +++ b/drivers/clk/bcm/clk-iproc-pll.c @@ -704,7 +704,7 @@ static const struct clk_ops iproc_clk_ops = { .set_rate = iproc_clk_set_rate, }; -/** +/* * Some PLLs require the PLL SW override bit to be set before changes can be * applied to the PLL */ -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH 05/20] clk: bcm: clk-iproc-pll: Demote kernel-doc abuse 2021-01-20 9:30 ` [PATCH 05/20] clk: bcm: clk-iproc-pll: Demote kernel-doc abuse Lee Jones @ 2021-02-11 19:49 ` Stephen Boyd 0 siblings, 0 replies; 19+ messages in thread From: Stephen Boyd @ 2021-02-11 19:49 UTC (permalink / raw) To: lee.jones Cc: Scott Branden, Ray Jui, Michael Turquette, linux-kernel, bcm-kernel-feedback-list, linux-clk, linux-arm-kernel Quoting Lee Jones (2021-01-20 01:30:25) > Fixes the following W=1 kernel build warning(s): > > drivers/clk/bcm/clk-iproc-pll.c:712: warning: Function parameter or member 'pll' not described in 'iproc_pll_sw_cfg' > > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: Ray Jui <rjui@broadcom.com> > Cc: Scott Branden <sbranden@broadcom.com> > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: linux-clk@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- Applied to clk-next _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 10/20] clk: imx: clk-imx31: Remove unused static const table 'uart_clks' 2021-01-20 9:30 [PATCH 00/20] Rid W=1 warnings from Clock Lee Jones ` (4 preceding siblings ...) 2021-01-20 9:30 ` [PATCH 05/20] clk: bcm: clk-iproc-pll: Demote kernel-doc abuse Lee Jones @ 2021-01-20 9:30 ` Lee Jones 2021-01-29 13:32 ` Shawn Guo 2021-01-20 9:30 ` [PATCH 14/20] clk: sunxi: clk-sunxi: Demote a bunch of non-conformant kernel-doc headers Lee Jones ` (5 subsequent siblings) 11 siblings, 1 reply; 19+ messages in thread From: Lee Jones @ 2021-01-20 9:30 UTC (permalink / raw) To: lee.jones Cc: Arnd Bergmann, Stephen Boyd, Fabio Estevam, Michael Turquette, linux-kernel, linux-clk, NXP Linux Team, Pengutronix Kernel Team, Shawn Guo, Sascha Hauer, linux-arm-kernel Fixes the following W=1 kernel build warning(s): drivers/clk/imx/clk-imx31.c:54:28: warning: ‘uart_clks’ defined but not used [-Wunused-const-variable=] Cc: Michael Turquette <mturquette@baylibre.com> Cc: Stephen Boyd <sboyd@kernel.org> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Sascha Hauer <s.hauer@pengutronix.de> Cc: Pengutronix Kernel Team <kernel@pengutronix.de> Cc: Fabio Estevam <festevam@gmail.com> Cc: NXP Linux Team <linux-imx@nxp.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: linux-clk@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/clk/imx/clk-imx31.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/clk/imx/clk-imx31.c b/drivers/clk/imx/clk-imx31.c index 7b13fb57d8428..c44e18c6f63f7 100644 --- a/drivers/clk/imx/clk-imx31.c +++ b/drivers/clk/imx/clk-imx31.c @@ -51,16 +51,6 @@ enum mx31_clks { static struct clk *clk[clk_max]; static struct clk_onecell_data clk_data; -static struct clk ** const uart_clks[] __initconst = { - &clk[ipg], - &clk[uart1_gate], - &clk[uart2_gate], - &clk[uart3_gate], - &clk[uart4_gate], - &clk[uart5_gate], - NULL -}; - static void __init _mx31_clocks_init(void __iomem *base, unsigned long fref) { clk[dummy] = imx_clk_fixed("dummy", 0); -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH 10/20] clk: imx: clk-imx31: Remove unused static const table 'uart_clks' 2021-01-20 9:30 ` [PATCH 10/20] clk: imx: clk-imx31: Remove unused static const table 'uart_clks' Lee Jones @ 2021-01-29 13:32 ` Shawn Guo 0 siblings, 0 replies; 19+ messages in thread From: Shawn Guo @ 2021-01-29 13:32 UTC (permalink / raw) To: Lee Jones Cc: Arnd Bergmann, Stephen Boyd, Michael Turquette, linux-kernel, linux-clk, NXP Linux Team, Pengutronix Kernel Team, Fabio Estevam, Sascha Hauer, linux-arm-kernel On Wed, Jan 20, 2021 at 09:30:30AM +0000, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/clk/imx/clk-imx31.c:54:28: warning: ‘uart_clks’ defined but not used [-Wunused-const-variable=] > > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Sascha Hauer <s.hauer@pengutronix.de> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: NXP Linux Team <linux-imx@nxp.com> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: linux-clk@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Applied, thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 14/20] clk: sunxi: clk-sunxi: Demote a bunch of non-conformant kernel-doc headers 2021-01-20 9:30 [PATCH 00/20] Rid W=1 warnings from Clock Lee Jones ` (5 preceding siblings ...) 2021-01-20 9:30 ` [PATCH 10/20] clk: imx: clk-imx31: Remove unused static const table 'uart_clks' Lee Jones @ 2021-01-20 9:30 ` Lee Jones 2021-01-20 9:30 ` [PATCH 17/20] clk: sunxi: clk-a10-ve: Demote obvious kernel-doc abuse Lee Jones ` (4 subsequent siblings) 11 siblings, 0 replies; 19+ messages in thread From: Lee Jones @ 2021-01-20 9:30 UTC (permalink / raw) To: lee.jones Cc: Jernej Skrabec, Emilio López, Michael Turquette, linux-kernel, Maxime Ripard, Stephen Boyd, Chen-Yu Tsai, linux-clk, linux-arm-kernel Fixes the following W=1 kernel build warning(s): drivers/clk/sunxi/clk-sunxi.c:34: warning: Function parameter or member 'req' not described in 'sun4i_get_pll1_factors' drivers/clk/sunxi/clk-sunxi.c:81: warning: Function parameter or member 'req' not described in 'sun6i_a31_get_pll1_factors' drivers/clk/sunxi/clk-sunxi.c:158: warning: Function parameter or member 'req' not described in 'sun8i_a23_get_pll1_factors' drivers/clk/sunxi/clk-sunxi.c:202: warning: Function parameter or member 'req' not described in 'sun4i_get_pll5_factors' drivers/clk/sunxi/clk-sunxi.c:229: warning: Function parameter or member 'req' not described in 'sun6i_a31_get_pll6_factors' drivers/clk/sunxi/clk-sunxi.c:250: warning: Function parameter or member 'req' not described in 'sun5i_a13_get_ahb_factors' drivers/clk/sunxi/clk-sunxi.c:289: warning: Function parameter or member 'req' not described in 'sun6i_get_ahb1_factors' drivers/clk/sunxi/clk-sunxi.c:328: warning: Function parameter or member 'req' not described in 'sun6i_ahb1_recalc' drivers/clk/sunxi/clk-sunxi.c:346: warning: Function parameter or member 'req' not described in 'sun4i_get_apb1_factors' drivers/clk/sunxi/clk-sunxi.c:385: warning: Function parameter or member 'req' not described in 'sun7i_a20_get_out_factors' drivers/clk/sunxi/clk-sunxi.c:415: warning: cannot understand function prototype: 'const struct clk_factors_config sun4i_pll1_config = ' drivers/clk/sunxi/clk-sunxi.c:724: warning: cannot understand function prototype: 'struct div_data ' drivers/clk/sunxi/clk-sunxi.c:945: warning: Function parameter or member 'node' not described in 'sunxi_divs_clk_setup' drivers/clk/sunxi/clk-sunxi.c:945: warning: Function parameter or member 'data' not described in 'sunxi_divs_clk_setup' Cc: "Emilio López" <emilio@elopez.com.ar> Cc: Michael Turquette <mturquette@baylibre.com> Cc: Stephen Boyd <sboyd@kernel.org> Cc: Maxime Ripard <mripard@kernel.org> Cc: Chen-Yu Tsai <wens@csie.org> Cc: Jernej Skrabec <jernej.skrabec@siol.net> Cc: linux-clk@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/clk/sunxi/clk-sunxi.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c index e1aa1fbac48a0..5fe7049ea693a 100644 --- a/drivers/clk/sunxi/clk-sunxi.c +++ b/drivers/clk/sunxi/clk-sunxi.c @@ -23,7 +23,7 @@ static DEFINE_SPINLOCK(clk_lock); /* Maximum number of parents our clocks have */ #define SUNXI_MAX_PARENTS 5 -/** +/* * sun4i_get_pll1_factors() - calculates n, k, m, p factors for PLL1 * PLL1 rate is calculated as follows * rate = (parent_rate * n * (k + 1) >> p) / (m + 1); @@ -71,7 +71,7 @@ static void sun4i_get_pll1_factors(struct factors_request *req) req->n = div / 4; } -/** +/* * sun6i_a31_get_pll1_factors() - calculates n, k and m factors for PLL1 * PLL1 rate is calculated as follows * rate = parent_rate * (n + 1) * (k + 1) / (m + 1); @@ -147,7 +147,7 @@ static void sun6i_a31_get_pll1_factors(struct factors_request *req) } } -/** +/* * sun8i_a23_get_pll1_factors() - calculates n, k, m, p factors for PLL1 * PLL1 rate is calculated as follows * rate = (parent_rate * (n + 1) * (k + 1) >> p) / (m + 1); @@ -191,7 +191,7 @@ static void sun8i_a23_get_pll1_factors(struct factors_request *req) req->n = div / 4 - 1; } -/** +/* * sun4i_get_pll5_factors() - calculates n, k factors for PLL5 * PLL5 rate is calculated as follows * rate = parent_rate * n * (k + 1) @@ -218,7 +218,7 @@ static void sun4i_get_pll5_factors(struct factors_request *req) req->n = DIV_ROUND_UP(div, (req->k + 1)); } -/** +/* * sun6i_a31_get_pll6_factors() - calculates n, k factors for A31 PLL6x2 * PLL6x2 rate is calculated as follows * rate = parent_rate * (n + 1) * (k + 1) @@ -240,7 +240,7 @@ static void sun6i_a31_get_pll6_factors(struct factors_request *req) req->n = DIV_ROUND_UP(div, (req->k + 1)) - 1; } -/** +/* * sun5i_a13_get_ahb_factors() - calculates m, p factors for AHB * AHB rate is calculated as follows * rate = parent_rate >> p @@ -276,7 +276,7 @@ static void sun5i_a13_get_ahb_factors(struct factors_request *req) #define SUN6I_AHB1_PARENT_PLL6 3 -/** +/* * sun6i_a31_get_ahb_factors() - calculates m, p factors for AHB * AHB rate is calculated as follows * rate = parent_rate >> p @@ -320,7 +320,7 @@ static void sun6i_get_ahb1_factors(struct factors_request *req) req->m = calcm - 1; } -/** +/* * sun6i_ahb1_recalc() - calculates AHB clock rate from m, p factors and * parent index */ @@ -336,7 +336,7 @@ static void sun6i_ahb1_recalc(struct factors_request *req) req->rate >>= req->p; } -/** +/* * sun4i_get_apb1_factors() - calculates m, p factors for APB1 * APB1 rate is calculated as follows * rate = (parent_rate >> p) / (m + 1); @@ -375,7 +375,7 @@ static void sun4i_get_apb1_factors(struct factors_request *req) -/** +/* * sun7i_a20_get_out_factors() - calculates m, p factors for CLK_OUT_A/B * CLK_OUT rate is calculated as follows * rate = (parent_rate >> p) / (m + 1); @@ -408,7 +408,7 @@ static void sun7i_a20_get_out_factors(struct factors_request *req) req->p = calcp; } -/** +/* * sunxi_factors_clk_setup() - Setup function for factor clocks */ @@ -625,7 +625,7 @@ CLK_OF_DECLARE(sun7i_out, "allwinner,sun7i-a20-out-clk", sun7i_out_clk_setup); -/** +/* * sunxi_mux_clk_setup() - Setup function for muxes */ @@ -717,7 +717,7 @@ CLK_OF_DECLARE(sun8i_ahb2, "allwinner,sun8i-h3-ahb2-clk", sun8i_ahb2_clk_setup); -/** +/* * sunxi_divider_clk_setup() - Setup function for simple divider clocks */ @@ -853,7 +853,7 @@ CLK_OF_DECLARE(sun8i_axi, "allwinner,sun8i-a23-axi-clk", -/** +/* * sunxi_gates_clk_setup() - Setup function for leaf gates on clocks */ @@ -863,7 +863,7 @@ struct gates_data { DECLARE_BITMAP(mask, SUNXI_GATES_MAX_SIZE); }; -/** +/* * sunxi_divs_clk_setup() helper data */ @@ -929,7 +929,7 @@ static const struct divs_data sun6i_a31_pll6_divs_data __initconst = { } }; -/** +/* * sunxi_divs_clk_setup() - Setup function for leaf divisors on clocks * * These clocks look something like this -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 17/20] clk: sunxi: clk-a10-ve: Demote obvious kernel-doc abuse 2021-01-20 9:30 [PATCH 00/20] Rid W=1 warnings from Clock Lee Jones ` (6 preceding siblings ...) 2021-01-20 9:30 ` [PATCH 14/20] clk: sunxi: clk-sunxi: Demote a bunch of non-conformant kernel-doc headers Lee Jones @ 2021-01-20 9:30 ` Lee Jones 2021-01-20 9:30 ` [PATCH 18/20] clk: sunxi: clk-mod0: Demote non-conformant kernel-doc header Lee Jones ` (3 subsequent siblings) 11 siblings, 0 replies; 19+ messages in thread From: Lee Jones @ 2021-01-20 9:30 UTC (permalink / raw) To: lee.jones Cc: Jernej Skrabec, Emilio López, Michael Turquette, linux-kernel, Maxime Ripard, Stephen Boyd, Chen-Yu Tsai, Philipp Zabel, linux-clk, linux-arm-kernel Fixes the following W=1 kernel build warning(s): drivers/clk/sunxi/clk-a10-ve.c:27: warning: cannot understand function prototype: 'struct ve_reset_data ' Cc: "Emilio López" <emilio@elopez.com.ar> Cc: Michael Turquette <mturquette@baylibre.com> Cc: Stephen Boyd <sboyd@kernel.org> Cc: Maxime Ripard <mripard@kernel.org> Cc: Chen-Yu Tsai <wens@csie.org> Cc: Jernej Skrabec <jernej.skrabec@siol.net> Cc: Philipp Zabel <p.zabel@pengutronix.de> Cc: linux-clk@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/clk/sunxi/clk-a10-ve.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/sunxi/clk-a10-ve.c b/drivers/clk/sunxi/clk-a10-ve.c index cb5daa4b37db7..65810937a13a1 100644 --- a/drivers/clk/sunxi/clk-a10-ve.c +++ b/drivers/clk/sunxi/clk-a10-ve.c @@ -20,7 +20,7 @@ static DEFINE_SPINLOCK(ve_lock); #define SUN4I_VE_DIVIDER_WIDTH 3 #define SUN4I_VE_RESET 0 -/** +/* * sunxi_ve_reset... - reset bit in ve clk registers handling */ -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 18/20] clk: sunxi: clk-mod0: Demote non-conformant kernel-doc header 2021-01-20 9:30 [PATCH 00/20] Rid W=1 warnings from Clock Lee Jones ` (7 preceding siblings ...) 2021-01-20 9:30 ` [PATCH 17/20] clk: sunxi: clk-a10-ve: Demote obvious kernel-doc abuse Lee Jones @ 2021-01-20 9:30 ` Lee Jones 2021-01-20 9:58 ` Maxime Ripard 2021-01-20 9:30 ` [PATCH 19/20] clk: versatile: clk-icst: Fix worthy struct documentation block Lee Jones ` (2 subsequent siblings) 11 siblings, 1 reply; 19+ messages in thread From: Lee Jones @ 2021-01-20 9:30 UTC (permalink / raw) To: lee.jones Cc: Jernej Skrabec, Emilio López, Michael Turquette, linux-kernel, Maxime Ripard, Stephen Boyd, Chen-Yu Tsai, linux-clk, linux-arm-kernel Fixes the following W=1 kernel build warning(s): drivers/clk/sunxi/clk-mod0.c:24: warning: Function parameter or member 'req' not described in 'sun4i_a10_get_mod0_factors' Cc: "Emilio López" <emilio@elopez.com.ar> Cc: Michael Turquette <mturquette@baylibre.com> Cc: Stephen Boyd <sboyd@kernel.org> Cc: Maxime Ripard <mripard@kernel.org> Cc: Chen-Yu Tsai <wens@csie.org> Cc: Jernej Skrabec <jernej.skrabec@siol.net> Cc: linux-clk@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/clk/sunxi/clk-mod0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/sunxi/clk-mod0.c b/drivers/clk/sunxi/clk-mod0.c index 0cca91e075a53..f9d715ec99087 100644 --- a/drivers/clk/sunxi/clk-mod0.c +++ b/drivers/clk/sunxi/clk-mod0.c @@ -14,7 +14,7 @@ #include "clk-factors.h" -/** +/* * sun4i_a10_get_mod0_factors() - calculates m, n factors for MOD0-style clocks * MOD0 rate is calculated as follows * rate = (parent_rate >> p) / (m + 1); -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH 18/20] clk: sunxi: clk-mod0: Demote non-conformant kernel-doc header 2021-01-20 9:30 ` [PATCH 18/20] clk: sunxi: clk-mod0: Demote non-conformant kernel-doc header Lee Jones @ 2021-01-20 9:58 ` Maxime Ripard 0 siblings, 0 replies; 19+ messages in thread From: Maxime Ripard @ 2021-01-20 9:58 UTC (permalink / raw) To: Lee Jones Cc: Jernej Skrabec, Emilio López, Michael Turquette, linux-kernel, Stephen Boyd, Chen-Yu Tsai, linux-clk, linux-arm-kernel [-- Attachment #1.1: Type: text/plain, Size: 681 bytes --] On Wed, Jan 20, 2021 at 09:30:38AM +0000, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/clk/sunxi/clk-mod0.c:24: warning: Function parameter or member 'req' not described in 'sun4i_a10_get_mod0_factors' > > Cc: "Emilio López" <emilio@elopez.com.ar> > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: Maxime Ripard <mripard@kernel.org> > Cc: Chen-Yu Tsai <wens@csie.org> > Cc: Jernej Skrabec <jernej.skrabec@siol.net> > Cc: linux-clk@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Applied all three sunxi patches Maxime [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 19/20] clk: versatile: clk-icst: Fix worthy struct documentation block 2021-01-20 9:30 [PATCH 00/20] Rid W=1 warnings from Clock Lee Jones ` (8 preceding siblings ...) 2021-01-20 9:30 ` [PATCH 18/20] clk: sunxi: clk-mod0: Demote non-conformant kernel-doc header Lee Jones @ 2021-01-20 9:30 ` Lee Jones 2021-01-21 8:31 ` Linus Walleij 2021-02-11 19:53 ` Stephen Boyd 2021-01-20 9:30 ` [PATCH 20/20] clk: zynq: clkc: Remove various instances of an unused variable 'clk' Lee Jones 2021-01-25 23:56 ` (subset) [PATCH 00/20] Rid W=1 warnings from Clock Heiko Stuebner 11 siblings, 2 replies; 19+ messages in thread From: Lee Jones @ 2021-01-20 9:30 UTC (permalink / raw) To: lee.jones Cc: Stephen Boyd, Michael Turquette, linux-kernel, linux-clk, Linus Walleij, linux-arm-kernel Also demote non-worthy header to standard comment block. Fixes the following W=1 kernel build warning(s): drivers/clk/versatile/clk-icst.c:53: warning: Function parameter or member 'map' not described in 'clk_icst' drivers/clk/versatile/clk-icst.c:53: warning: Function parameter or member 'vcoreg_off' not described in 'clk_icst' drivers/clk/versatile/clk-icst.c:53: warning: Function parameter or member 'lockreg_off' not described in 'clk_icst' drivers/clk/versatile/clk-icst.c:435: warning: cannot understand function prototype: 'const struct icst_params icst525_apcp_cm_params = ' Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Michael Turquette <mturquette@baylibre.com> Cc: Stephen Boyd <sboyd@kernel.org> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-clk@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/clk/versatile/clk-icst.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/clk/versatile/clk-icst.c b/drivers/clk/versatile/clk-icst.c index 692be2fd9261a..fdd6aa3cb1fc8 100644 --- a/drivers/clk/versatile/clk-icst.c +++ b/drivers/clk/versatile/clk-icst.c @@ -36,8 +36,9 @@ /** * struct clk_icst - ICST VCO clock wrapper * @hw: corresponding clock hardware entry - * @vcoreg: VCO register address - * @lockreg: VCO lock register address + * @map: register map + * @vcoreg_off: VCO register address + * @lockreg_off: VCO lock register address * @params: parameters for this ICST instance * @rate: current rate * @ctype: the type of control register for the ICST @@ -428,7 +429,7 @@ static const struct icst_params icst307_params = { .idx2s = icst307_idx2s, }; -/** +/* * The core modules on the Integrator/AP and Integrator/CP have * especially crippled ICST525 control. */ -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH 19/20] clk: versatile: clk-icst: Fix worthy struct documentation block 2021-01-20 9:30 ` [PATCH 19/20] clk: versatile: clk-icst: Fix worthy struct documentation block Lee Jones @ 2021-01-21 8:31 ` Linus Walleij 2021-02-11 19:53 ` Stephen Boyd 1 sibling, 0 replies; 19+ messages in thread From: Linus Walleij @ 2021-01-21 8:31 UTC (permalink / raw) To: Lee Jones Cc: Stephen Boyd, Michael Turquette, linux-kernel@vger.kernel.org, Linux ARM, linux-clk On Wed, Jan 20, 2021 at 10:31 AM Lee Jones <lee.jones@linaro.org> wrote: > Also demote non-worthy header to standard comment block. > > Fixes the following W=1 kernel build warning(s): > > drivers/clk/versatile/clk-icst.c:53: warning: Function parameter or member 'map' not described in 'clk_icst' > drivers/clk/versatile/clk-icst.c:53: warning: Function parameter or member 'vcoreg_off' not described in 'clk_icst' > drivers/clk/versatile/clk-icst.c:53: warning: Function parameter or member 'lockreg_off' not described in 'clk_icst' > drivers/clk/versatile/clk-icst.c:435: warning: cannot understand function prototype: 'const struct icst_params icst525_apcp_cm_params = ' > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-clk@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 19/20] clk: versatile: clk-icst: Fix worthy struct documentation block 2021-01-20 9:30 ` [PATCH 19/20] clk: versatile: clk-icst: Fix worthy struct documentation block Lee Jones 2021-01-21 8:31 ` Linus Walleij @ 2021-02-11 19:53 ` Stephen Boyd 1 sibling, 0 replies; 19+ messages in thread From: Stephen Boyd @ 2021-02-11 19:53 UTC (permalink / raw) To: lee.jones Cc: Michael Turquette, Linus Walleij, linux-kernel, linux-arm-kernel, linux-clk Quoting Lee Jones (2021-01-20 01:30:39) > Also demote non-worthy header to standard comment block. > > Fixes the following W=1 kernel build warning(s): > > drivers/clk/versatile/clk-icst.c:53: warning: Function parameter or member 'map' not described in 'clk_icst' > drivers/clk/versatile/clk-icst.c:53: warning: Function parameter or member 'vcoreg_off' not described in 'clk_icst' > drivers/clk/versatile/clk-icst.c:53: warning: Function parameter or member 'lockreg_off' not described in 'clk_icst' > drivers/clk/versatile/clk-icst.c:435: warning: cannot understand function prototype: 'const struct icst_params icst525_apcp_cm_params = ' > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-clk@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- Applied to clk-next _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 20/20] clk: zynq: clkc: Remove various instances of an unused variable 'clk' 2021-01-20 9:30 [PATCH 00/20] Rid W=1 warnings from Clock Lee Jones ` (9 preceding siblings ...) 2021-01-20 9:30 ` [PATCH 19/20] clk: versatile: clk-icst: Fix worthy struct documentation block Lee Jones @ 2021-01-20 9:30 ` Lee Jones 2021-02-11 19:53 ` Stephen Boyd 2021-01-25 23:56 ` (subset) [PATCH 00/20] Rid W=1 warnings from Clock Heiko Stuebner 11 siblings, 1 reply; 19+ messages in thread From: Lee Jones @ 2021-01-20 9:30 UTC (permalink / raw) To: lee.jones Cc: Stephen Boyd, Michael Turquette, linux-kernel, Michal Simek, linux-arm-kernel, linux-clk, Sören Brinkmann Fixes the following W=1 kernel build warning(s): drivers/clk/zynq/clkc.c: In function ‘zynq_clk_register_fclk’: drivers/clk/zynq/clkc.c:106:14: warning: variable ‘clk’ set but not used [-Wunused-but-set-variable] drivers/clk/zynq/clkc.c: In function ‘zynq_clk_register_periph_clk’: drivers/clk/zynq/clkc.c:179:14: warning: variable ‘clk’ set but not used [-Wunused-but-set-variable] drivers/clk/zynq/clkc.c: In function ‘zynq_clk_setup’: drivers/clk/zynq/clkc.c:220:14: warning: variable ‘clk’ set but not used [-Wunused-but-set-variable] Cc: Michael Turquette <mturquette@baylibre.com> Cc: Stephen Boyd <sboyd@kernel.org> Cc: Michal Simek <michal.simek@xilinx.com> Cc: "Sören Brinkmann" <soren.brinkmann@xilinx.com> Cc: linux-clk@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/clk/zynq/clkc.c | 73 ++++++++++++++++++++--------------------- 1 file changed, 35 insertions(+), 38 deletions(-) diff --git a/drivers/clk/zynq/clkc.c b/drivers/clk/zynq/clkc.c index ffbb9008c1c99..204b83d911b90 100644 --- a/drivers/clk/zynq/clkc.c +++ b/drivers/clk/zynq/clkc.c @@ -103,7 +103,6 @@ static void __init zynq_clk_register_fclk(enum zynq_clk fclk, const char *clk_name, void __iomem *fclk_ctrl_reg, const char **parents, int enable) { - struct clk *clk; u32 enable_reg; char *mux_name; char *div0_name; @@ -131,15 +130,15 @@ static void __init zynq_clk_register_fclk(enum zynq_clk fclk, if (!div1_name) goto err_div1_name; - clk = clk_register_mux(NULL, mux_name, parents, 4, + clk_register_mux(NULL, mux_name, parents, 4, CLK_SET_RATE_NO_REPARENT, fclk_ctrl_reg, 4, 2, 0, fclk_lock); - clk = clk_register_divider(NULL, div0_name, mux_name, + clk_register_divider(NULL, div0_name, mux_name, 0, fclk_ctrl_reg, 8, 6, CLK_DIVIDER_ONE_BASED | CLK_DIVIDER_ALLOW_ZERO, fclk_lock); - clk = clk_register_divider(NULL, div1_name, div0_name, + clk_register_divider(NULL, div1_name, div0_name, CLK_SET_RATE_PARENT, fclk_ctrl_reg, 20, 6, CLK_DIVIDER_ONE_BASED | CLK_DIVIDER_ALLOW_ZERO, fclk_lock); @@ -176,7 +175,6 @@ static void __init zynq_clk_register_periph_clk(enum zynq_clk clk0, const char *clk_name1, void __iomem *clk_ctrl, const char **parents, unsigned int two_gates) { - struct clk *clk; char *mux_name; char *div_name; spinlock_t *lock; @@ -189,10 +187,10 @@ static void __init zynq_clk_register_periph_clk(enum zynq_clk clk0, mux_name = kasprintf(GFP_KERNEL, "%s_mux", clk_name0); div_name = kasprintf(GFP_KERNEL, "%s_div", clk_name0); - clk = clk_register_mux(NULL, mux_name, parents, 4, + clk_register_mux(NULL, mux_name, parents, 4, CLK_SET_RATE_NO_REPARENT, clk_ctrl, 4, 2, 0, lock); - clk = clk_register_divider(NULL, div_name, mux_name, 0, clk_ctrl, 8, 6, + clk_register_divider(NULL, div_name, mux_name, 0, clk_ctrl, 8, 6, CLK_DIVIDER_ONE_BASED | CLK_DIVIDER_ALLOW_ZERO, lock); clks[clk0] = clk_register_gate(NULL, clk_name0, div_name, @@ -217,7 +215,6 @@ static void __init zynq_clk_setup(struct device_node *np) int i; u32 tmp; int ret; - struct clk *clk; char *clk_name; unsigned int fclk_enable = 0; const char *clk_output_name[clk_max]; @@ -257,19 +254,19 @@ static void __init zynq_clk_setup(struct device_node *np) ps_clk = clk_register_fixed_rate(NULL, "ps_clk", NULL, 0, tmp); /* PLLs */ - clk = clk_register_zynq_pll("armpll_int", "ps_clk", SLCR_ARMPLL_CTRL, + clk_register_zynq_pll("armpll_int", "ps_clk", SLCR_ARMPLL_CTRL, SLCR_PLL_STATUS, 0, &armpll_lock); clks[armpll] = clk_register_mux(NULL, clk_output_name[armpll], armpll_parents, 2, CLK_SET_RATE_NO_REPARENT, SLCR_ARMPLL_CTRL, 4, 1, 0, &armpll_lock); - clk = clk_register_zynq_pll("ddrpll_int", "ps_clk", SLCR_DDRPLL_CTRL, + clk_register_zynq_pll("ddrpll_int", "ps_clk", SLCR_DDRPLL_CTRL, SLCR_PLL_STATUS, 1, &ddrpll_lock); clks[ddrpll] = clk_register_mux(NULL, clk_output_name[ddrpll], ddrpll_parents, 2, CLK_SET_RATE_NO_REPARENT, SLCR_DDRPLL_CTRL, 4, 1, 0, &ddrpll_lock); - clk = clk_register_zynq_pll("iopll_int", "ps_clk", SLCR_IOPLL_CTRL, + clk_register_zynq_pll("iopll_int", "ps_clk", SLCR_IOPLL_CTRL, SLCR_PLL_STATUS, 2, &iopll_lock); clks[iopll] = clk_register_mux(NULL, clk_output_name[iopll], iopll_parents, 2, CLK_SET_RATE_NO_REPARENT, @@ -277,10 +274,10 @@ static void __init zynq_clk_setup(struct device_node *np) /* CPU clocks */ tmp = readl(SLCR_621_TRUE) & 1; - clk = clk_register_mux(NULL, "cpu_mux", cpu_parents, 4, + clk_register_mux(NULL, "cpu_mux", cpu_parents, 4, CLK_SET_RATE_NO_REPARENT, SLCR_ARM_CLK_CTRL, 4, 2, 0, &armclk_lock); - clk = clk_register_divider(NULL, "cpu_div", "cpu_mux", 0, + clk_register_divider(NULL, "cpu_div", "cpu_mux", 0, SLCR_ARM_CLK_CTRL, 8, 6, CLK_DIVIDER_ONE_BASED | CLK_DIVIDER_ALLOW_ZERO, &armclk_lock); @@ -288,20 +285,20 @@ static void __init zynq_clk_setup(struct device_node *np) "cpu_div", CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, SLCR_ARM_CLK_CTRL, 24, 0, &armclk_lock); - clk = clk_register_fixed_factor(NULL, "cpu_3or2x_div", "cpu_div", 0, + clk_register_fixed_factor(NULL, "cpu_3or2x_div", "cpu_div", 0, 1, 2); clks[cpu_3or2x] = clk_register_gate(NULL, clk_output_name[cpu_3or2x], "cpu_3or2x_div", CLK_IGNORE_UNUSED, SLCR_ARM_CLK_CTRL, 25, 0, &armclk_lock); - clk = clk_register_fixed_factor(NULL, "cpu_2x_div", "cpu_div", 0, 1, + clk_register_fixed_factor(NULL, "cpu_2x_div", "cpu_div", 0, 1, 2 + tmp); clks[cpu_2x] = clk_register_gate(NULL, clk_output_name[cpu_2x], "cpu_2x_div", CLK_IGNORE_UNUSED, SLCR_ARM_CLK_CTRL, 26, 0, &armclk_lock); clk_prepare_enable(clks[cpu_2x]); - clk = clk_register_fixed_factor(NULL, "cpu_1x_div", "cpu_div", 0, 1, + clk_register_fixed_factor(NULL, "cpu_1x_div", "cpu_div", 0, 1, 4 + 2 * tmp); clks[cpu_1x] = clk_register_gate(NULL, clk_output_name[cpu_1x], "cpu_1x_div", CLK_IGNORE_UNUSED, SLCR_ARM_CLK_CTRL, 27, @@ -324,23 +321,23 @@ static void __init zynq_clk_setup(struct device_node *np) &swdtclk_lock); /* DDR clocks */ - clk = clk_register_divider(NULL, "ddr2x_div", "ddrpll", 0, + clk_register_divider(NULL, "ddr2x_div", "ddrpll", 0, SLCR_DDR_CLK_CTRL, 26, 6, CLK_DIVIDER_ONE_BASED | CLK_DIVIDER_ALLOW_ZERO, &ddrclk_lock); clks[ddr2x] = clk_register_gate(NULL, clk_output_name[ddr2x], "ddr2x_div", 0, SLCR_DDR_CLK_CTRL, 1, 0, &ddrclk_lock); clk_prepare_enable(clks[ddr2x]); - clk = clk_register_divider(NULL, "ddr3x_div", "ddrpll", 0, + clk_register_divider(NULL, "ddr3x_div", "ddrpll", 0, SLCR_DDR_CLK_CTRL, 20, 6, CLK_DIVIDER_ONE_BASED | CLK_DIVIDER_ALLOW_ZERO, &ddrclk_lock); clks[ddr3x] = clk_register_gate(NULL, clk_output_name[ddr3x], "ddr3x_div", 0, SLCR_DDR_CLK_CTRL, 0, 0, &ddrclk_lock); clk_prepare_enable(clks[ddr3x]); - clk = clk_register_divider(NULL, "dci_div0", "ddrpll", 0, + clk_register_divider(NULL, "dci_div0", "ddrpll", 0, SLCR_DCI_CLK_CTRL, 8, 6, CLK_DIVIDER_ONE_BASED | CLK_DIVIDER_ALLOW_ZERO, &dciclk_lock); - clk = clk_register_divider(NULL, "dci_div1", "dci_div0", + clk_register_divider(NULL, "dci_div1", "dci_div0", CLK_SET_RATE_PARENT, SLCR_DCI_CLK_CTRL, 20, 6, CLK_DIVIDER_ONE_BASED | CLK_DIVIDER_ALLOW_ZERO, &dciclk_lock); @@ -385,17 +382,17 @@ static void __init zynq_clk_setup(struct device_node *np) gem0_mux_parents[i + 1] = of_clk_get_parent_name(np, idx); } - clk = clk_register_mux(NULL, "gem0_mux", periph_parents, 4, + clk_register_mux(NULL, "gem0_mux", periph_parents, 4, CLK_SET_RATE_NO_REPARENT, SLCR_GEM0_CLK_CTRL, 4, 2, 0, &gem0clk_lock); - clk = clk_register_divider(NULL, "gem0_div0", "gem0_mux", 0, + clk_register_divider(NULL, "gem0_div0", "gem0_mux", 0, SLCR_GEM0_CLK_CTRL, 8, 6, CLK_DIVIDER_ONE_BASED | CLK_DIVIDER_ALLOW_ZERO, &gem0clk_lock); - clk = clk_register_divider(NULL, "gem0_div1", "gem0_div0", + clk_register_divider(NULL, "gem0_div1", "gem0_div0", CLK_SET_RATE_PARENT, SLCR_GEM0_CLK_CTRL, 20, 6, CLK_DIVIDER_ONE_BASED | CLK_DIVIDER_ALLOW_ZERO, &gem0clk_lock); - clk = clk_register_mux(NULL, "gem0_emio_mux", gem0_mux_parents, 2, + clk_register_mux(NULL, "gem0_emio_mux", gem0_mux_parents, 2, CLK_SET_RATE_PARENT | CLK_SET_RATE_NO_REPARENT, SLCR_GEM0_CLK_CTRL, 6, 1, 0, &gem0clk_lock); @@ -410,17 +407,17 @@ static void __init zynq_clk_setup(struct device_node *np) gem1_mux_parents[i + 1] = of_clk_get_parent_name(np, idx); } - clk = clk_register_mux(NULL, "gem1_mux", periph_parents, 4, + clk_register_mux(NULL, "gem1_mux", periph_parents, 4, CLK_SET_RATE_NO_REPARENT, SLCR_GEM1_CLK_CTRL, 4, 2, 0, &gem1clk_lock); - clk = clk_register_divider(NULL, "gem1_div0", "gem1_mux", 0, + clk_register_divider(NULL, "gem1_div0", "gem1_mux", 0, SLCR_GEM1_CLK_CTRL, 8, 6, CLK_DIVIDER_ONE_BASED | CLK_DIVIDER_ALLOW_ZERO, &gem1clk_lock); - clk = clk_register_divider(NULL, "gem1_div1", "gem1_div0", + clk_register_divider(NULL, "gem1_div1", "gem1_div0", CLK_SET_RATE_PARENT, SLCR_GEM1_CLK_CTRL, 20, 6, CLK_DIVIDER_ONE_BASED | CLK_DIVIDER_ALLOW_ZERO, &gem1clk_lock); - clk = clk_register_mux(NULL, "gem1_emio_mux", gem1_mux_parents, 2, + clk_register_mux(NULL, "gem1_emio_mux", gem1_mux_parents, 2, CLK_SET_RATE_PARENT | CLK_SET_RATE_NO_REPARENT, SLCR_GEM1_CLK_CTRL, 6, 1, 0, &gem1clk_lock); @@ -442,27 +439,27 @@ static void __init zynq_clk_setup(struct device_node *np) can_mio_mux_parents[i] = dummy_nm; } kfree(clk_name); - clk = clk_register_mux(NULL, "can_mux", periph_parents, 4, + clk_register_mux(NULL, "can_mux", periph_parents, 4, CLK_SET_RATE_NO_REPARENT, SLCR_CAN_CLK_CTRL, 4, 2, 0, &canclk_lock); - clk = clk_register_divider(NULL, "can_div0", "can_mux", 0, + clk_register_divider(NULL, "can_div0", "can_mux", 0, SLCR_CAN_CLK_CTRL, 8, 6, CLK_DIVIDER_ONE_BASED | CLK_DIVIDER_ALLOW_ZERO, &canclk_lock); - clk = clk_register_divider(NULL, "can_div1", "can_div0", + clk_register_divider(NULL, "can_div1", "can_div0", CLK_SET_RATE_PARENT, SLCR_CAN_CLK_CTRL, 20, 6, CLK_DIVIDER_ONE_BASED | CLK_DIVIDER_ALLOW_ZERO, &canclk_lock); - clk = clk_register_gate(NULL, "can0_gate", "can_div1", + clk_register_gate(NULL, "can0_gate", "can_div1", CLK_SET_RATE_PARENT, SLCR_CAN_CLK_CTRL, 0, 0, &canclk_lock); - clk = clk_register_gate(NULL, "can1_gate", "can_div1", + clk_register_gate(NULL, "can1_gate", "can_div1", CLK_SET_RATE_PARENT, SLCR_CAN_CLK_CTRL, 1, 0, &canclk_lock); - clk = clk_register_mux(NULL, "can0_mio_mux", + clk_register_mux(NULL, "can0_mio_mux", can_mio_mux_parents, 54, CLK_SET_RATE_PARENT | CLK_SET_RATE_NO_REPARENT, SLCR_CAN_MIOCLK_CTRL, 0, 6, 0, &canmioclk_lock); - clk = clk_register_mux(NULL, "can1_mio_mux", + clk_register_mux(NULL, "can1_mio_mux", can_mio_mux_parents, 54, CLK_SET_RATE_PARENT | CLK_SET_RATE_NO_REPARENT, SLCR_CAN_MIOCLK_CTRL, 16, 6, 0, &canmioclk_lock); @@ -482,13 +479,13 @@ static void __init zynq_clk_setup(struct device_node *np) dbg_emio_mux_parents[i + 1] = of_clk_get_parent_name(np, idx); } - clk = clk_register_mux(NULL, "dbg_mux", periph_parents, 4, + clk_register_mux(NULL, "dbg_mux", periph_parents, 4, CLK_SET_RATE_NO_REPARENT, SLCR_DBG_CLK_CTRL, 4, 2, 0, &dbgclk_lock); - clk = clk_register_divider(NULL, "dbg_div", "dbg_mux", 0, + clk_register_divider(NULL, "dbg_div", "dbg_mux", 0, SLCR_DBG_CLK_CTRL, 8, 6, CLK_DIVIDER_ONE_BASED | CLK_DIVIDER_ALLOW_ZERO, &dbgclk_lock); - clk = clk_register_mux(NULL, "dbg_emio_mux", dbg_emio_mux_parents, 2, + clk_register_mux(NULL, "dbg_emio_mux", dbg_emio_mux_parents, 2, CLK_SET_RATE_NO_REPARENT, SLCR_DBG_CLK_CTRL, 6, 1, 0, &dbgclk_lock); clks[dbg_trc] = clk_register_gate(NULL, clk_output_name[dbg_trc], -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH 20/20] clk: zynq: clkc: Remove various instances of an unused variable 'clk' 2021-01-20 9:30 ` [PATCH 20/20] clk: zynq: clkc: Remove various instances of an unused variable 'clk' Lee Jones @ 2021-02-11 19:53 ` Stephen Boyd 0 siblings, 0 replies; 19+ messages in thread From: Stephen Boyd @ 2021-02-11 19:53 UTC (permalink / raw) To: lee.jones Cc: Michael Turquette, linux-kernel, Michal Simek, Sören Brinkmann, linux-clk, linux-arm-kernel Quoting Lee Jones (2021-01-20 01:30:40) > Fixes the following W=1 kernel build warning(s): > > drivers/clk/zynq/clkc.c: In function ‘zynq_clk_register_fclk’: > drivers/clk/zynq/clkc.c:106:14: warning: variable ‘clk’ set but not used [-Wunused-but-set-variable] > drivers/clk/zynq/clkc.c: In function ‘zynq_clk_register_periph_clk’: > drivers/clk/zynq/clkc.c:179:14: warning: variable ‘clk’ set but not used [-Wunused-but-set-variable] > drivers/clk/zynq/clkc.c: In function ‘zynq_clk_setup’: > drivers/clk/zynq/clkc.c:220:14: warning: variable ‘clk’ set but not used [-Wunused-but-set-variable] > > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: Michal Simek <michal.simek@xilinx.com> > Cc: "Sören Brinkmann" <soren.brinkmann@xilinx.com> > Cc: linux-clk@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- Applied to clk-next _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: (subset) [PATCH 00/20] Rid W=1 warnings from Clock 2021-01-20 9:30 [PATCH 00/20] Rid W=1 warnings from Clock Lee Jones ` (10 preceding siblings ...) 2021-01-20 9:30 ` [PATCH 20/20] clk: zynq: clkc: Remove various instances of an unused variable 'clk' Lee Jones @ 2021-01-25 23:56 ` Heiko Stuebner 11 siblings, 0 replies; 19+ messages in thread From: Heiko Stuebner @ 2021-01-25 23:56 UTC (permalink / raw) To: Lee Jones Cc: Heiko Stuebner, Michael Turquette, Michal Simek, Zong Li, linux-riscv, Fabio Estevam, linux-clk, Xing Zheng, Emilio López, Gregory Clement, Stephen Gallimore, linux-rockchip, Chen-Yu Tsai, Thomas Abraham, bcm-kernel-feedback-list, NXP Linux Team, Philipp Zabel, Linus Walleij, Kees Cook, Arnd Bergmann, Ray Jui, Sascha Hauer, Omri Itach, Maxime Ripard, Paul Walmsley, linux-omap, linux-arm-kernel, Sören Brinkmann, Jernej Skrabec, Scott Branden, Tero Kristo, Stephen Boyd, linux-kernel, Julia Lawall, Dinh Nguyen, Pankaj Dev, Palmer Dabbelt, Pengutronix Kernel Team, Shawn Guo, Pragnesh Patel On Wed, 20 Jan 2021 09:30:20 +0000, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > We should have these nailed in ~2 patchsets. > > Lee Jones (20): > clk: rockchip: clk: Demote non-conformant kernel-doc headers > clk: rockchip: clk-cpu: Remove unused/undocumented struct members > clk: rockchip: clk-pll: Demote kernel-doc abuses to standard comment > blocks > clk: rockchip: clk-half-divider: Demote non-conformant kernel-doc > header > clk: bcm: clk-iproc-pll: Demote kernel-doc abuse > clk: sifive: fu540-prci: Declare static const variable > 'prci_clk_fu540' where it's used > clk: socfpga: clk-pll: Remove unused variable 'rc' > clk: socfpga: clk-pll-a10: Remove set but unused variable 'rc' > clk: mvebu: ap-cpu-clk: Demote non-conformant kernel-doc header > clk: imx: clk-imx31: Remove unused static const table 'uart_clks' > clk: st: clkgen-pll: Demote unpopulated kernel-doc header > clk: st: clkgen-fsyn: Fix worthy struct documentation demote partially > filled one > clk: ti: clockdomain: Fix description for 'omap2_init_clk_clkdm's hw > param > clk: sunxi: clk-sunxi: Demote a bunch of non-conformant kernel-doc > headers > clk: ti: dpll: Fix misnaming of '_register_dpll()'s 'user' parameter > clk: ti: gate: Fix possible doc-rot in > 'omap36xx_gate_clk_enable_with_hsdiv_restore' > clk: sunxi: clk-a10-ve: Demote obvious kernel-doc abuse > clk: sunxi: clk-mod0: Demote non-conformant kernel-doc header > clk: versatile: clk-icst: Fix worthy struct documentation block > clk: zynq: clkc: Remove various instances of an unused variable 'clk' > > [...] Applied, thanks! [01/20] clk: rockchip: clk: Demote non-conformant kernel-doc headers commit: 415173712003ad7e54de7198979d68a428440ed6 [02/20] clk: rockchip: clk-cpu: Remove unused/undocumented struct members commit: 274ae6da4b3275fea32f0807e6e20715695dd210 [03/20] clk: rockchip: clk-pll: Demote kernel-doc abuses to standard comment blocks commit: eee7b95589e61bd7250cada52ddd8039c63535ef [04/20] clk: rockchip: clk-half-divider: Demote non-conformant kernel-doc header commit: d48fbef962b095f7cc22017642fb9055d57fdb53 Best regards, -- Heiko Stuebner <heiko@sntech.de> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2021-02-11 19:54 UTC | newest] Thread overview: 19+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-01-20 9:30 [PATCH 00/20] Rid W=1 warnings from Clock Lee Jones 2021-01-20 9:30 ` [PATCH 01/20] clk: rockchip: clk: Demote non-conformant kernel-doc headers Lee Jones 2021-01-20 9:30 ` [PATCH 02/20] clk: rockchip: clk-cpu: Remove unused/undocumented struct members Lee Jones 2021-01-20 9:30 ` [PATCH 03/20] clk: rockchip: clk-pll: Demote kernel-doc abuses to standard comment blocks Lee Jones 2021-01-20 9:30 ` [PATCH 04/20] clk: rockchip: clk-half-divider: Demote non-conformant kernel-doc header Lee Jones 2021-01-20 9:30 ` [PATCH 05/20] clk: bcm: clk-iproc-pll: Demote kernel-doc abuse Lee Jones 2021-02-11 19:49 ` Stephen Boyd 2021-01-20 9:30 ` [PATCH 10/20] clk: imx: clk-imx31: Remove unused static const table 'uart_clks' Lee Jones 2021-01-29 13:32 ` Shawn Guo 2021-01-20 9:30 ` [PATCH 14/20] clk: sunxi: clk-sunxi: Demote a bunch of non-conformant kernel-doc headers Lee Jones 2021-01-20 9:30 ` [PATCH 17/20] clk: sunxi: clk-a10-ve: Demote obvious kernel-doc abuse Lee Jones 2021-01-20 9:30 ` [PATCH 18/20] clk: sunxi: clk-mod0: Demote non-conformant kernel-doc header Lee Jones 2021-01-20 9:58 ` Maxime Ripard 2021-01-20 9:30 ` [PATCH 19/20] clk: versatile: clk-icst: Fix worthy struct documentation block Lee Jones 2021-01-21 8:31 ` Linus Walleij 2021-02-11 19:53 ` Stephen Boyd 2021-01-20 9:30 ` [PATCH 20/20] clk: zynq: clkc: Remove various instances of an unused variable 'clk' Lee Jones 2021-02-11 19:53 ` Stephen Boyd 2021-01-25 23:56 ` (subset) [PATCH 00/20] Rid W=1 warnings from Clock Heiko Stuebner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).