linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: Stephen Boyd <sboyd@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 19/20] clk: versatile: clk-icst: Fix worthy struct documentation block
Date: Wed, 20 Jan 2021 09:30:39 +0000	[thread overview]
Message-ID: <20210120093040.1719407-20-lee.jones@linaro.org> (raw)
In-Reply-To: <20210120093040.1719407-1-lee.jones@linaro.org>

Also demote non-worthy header to standard comment block.

Fixes the following W=1 kernel build warning(s):

 drivers/clk/versatile/clk-icst.c:53: warning: Function parameter or member 'map' not described in 'clk_icst'
 drivers/clk/versatile/clk-icst.c:53: warning: Function parameter or member 'vcoreg_off' not described in 'clk_icst'
 drivers/clk/versatile/clk-icst.c:53: warning: Function parameter or member 'lockreg_off' not described in 'clk_icst'
 drivers/clk/versatile/clk-icst.c:435: warning: cannot understand function prototype: 'const struct icst_params icst525_apcp_cm_params = '

Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-clk@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/clk/versatile/clk-icst.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/versatile/clk-icst.c b/drivers/clk/versatile/clk-icst.c
index 692be2fd9261a..fdd6aa3cb1fc8 100644
--- a/drivers/clk/versatile/clk-icst.c
+++ b/drivers/clk/versatile/clk-icst.c
@@ -36,8 +36,9 @@
 /**
  * struct clk_icst - ICST VCO clock wrapper
  * @hw: corresponding clock hardware entry
- * @vcoreg: VCO register address
- * @lockreg: VCO lock register address
+ * @map: register map
+ * @vcoreg_off: VCO register address
+ * @lockreg_off: VCO lock register address
  * @params: parameters for this ICST instance
  * @rate: current rate
  * @ctype: the type of control register for the ICST
@@ -428,7 +429,7 @@ static const struct icst_params icst307_params = {
 	.idx2s		= icst307_idx2s,
 };
 
-/**
+/*
  * The core modules on the Integrator/AP and Integrator/CP have
  * especially crippled ICST525 control.
  */
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-01-20  9:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20  9:30 [PATCH 00/20] Rid W=1 warnings from Clock Lee Jones
2021-01-20  9:30 ` [PATCH 01/20] clk: rockchip: clk: Demote non-conformant kernel-doc headers Lee Jones
2021-01-20  9:30 ` [PATCH 02/20] clk: rockchip: clk-cpu: Remove unused/undocumented struct members Lee Jones
2021-01-20  9:30 ` [PATCH 03/20] clk: rockchip: clk-pll: Demote kernel-doc abuses to standard comment blocks Lee Jones
2021-01-20  9:30 ` [PATCH 04/20] clk: rockchip: clk-half-divider: Demote non-conformant kernel-doc header Lee Jones
2021-01-20  9:30 ` [PATCH 05/20] clk: bcm: clk-iproc-pll: Demote kernel-doc abuse Lee Jones
2021-02-11 19:49   ` Stephen Boyd
2021-01-20  9:30 ` [PATCH 10/20] clk: imx: clk-imx31: Remove unused static const table 'uart_clks' Lee Jones
2021-01-29 13:32   ` Shawn Guo
2021-01-20  9:30 ` [PATCH 14/20] clk: sunxi: clk-sunxi: Demote a bunch of non-conformant kernel-doc headers Lee Jones
2021-01-20  9:30 ` [PATCH 17/20] clk: sunxi: clk-a10-ve: Demote obvious kernel-doc abuse Lee Jones
2021-01-20  9:30 ` [PATCH 18/20] clk: sunxi: clk-mod0: Demote non-conformant kernel-doc header Lee Jones
2021-01-20  9:58   ` Maxime Ripard
2021-01-20  9:30 ` Lee Jones [this message]
2021-01-21  8:31   ` [PATCH 19/20] clk: versatile: clk-icst: Fix worthy struct documentation block Linus Walleij
2021-02-11 19:53   ` Stephen Boyd
2021-01-20  9:30 ` [PATCH 20/20] clk: zynq: clkc: Remove various instances of an unused variable 'clk' Lee Jones
2021-02-11 19:53   ` Stephen Boyd
2021-01-25 23:56 ` (subset) [PATCH 00/20] Rid W=1 warnings from Clock Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210120093040.1719407-20-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).